[Wikitech-l] TechCom Radar 2020-05-13

[Kate Chapman]

Hi All,

Here are the minutes from this week's TechCom meeting:

* RFC Approved: RFC: Remove Android 2 from basic support in
compatibility matrix. 

* On Last Call ending 27th of May RFC: Wikimedia Push Notification
Service 

* Reviewed: RFC: Remove IE 8 from basic support
 clarifying with folks on
ticket what removing support means

* Moved to define stage: RFC: HTML element for inline media from
wikitext 

* Moved to tune stage: Introduce PageIdentity to be used instead of
Title. 

You can also find our meeting minutes at


See also the TechCom RFC board
.

If you prefer you can subscribe to our newsletter here


Thanks,
Kate

-- 
Kate Chapman (she/her/hers)
Director of Architecture, Architecture Team
Wikimedia Foundation
kchap...@wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] [Train] 1.35.0-wmf.32 status update

[Antoine Musso]

Hello,

The 1.35.0-wmf.32 train is deployed on group 0 / 1.

It has been blocked due to a large increase of writes on the databases
(T247028). An issue that will need coordination with the database
administrators for monitoring.

There is also a regression in the Vector skin which prevents adding
links in other languages when the page does not have any links yet. T252800.

* https://phabricator.wikimedia.org/T247028
* https://phabricator.wikimedia.org/T252800

We are in a bit odd position since this week had no train deployment
planned. We might try to push 1.35.0-wmf.32 to the remaining wikis this
week, but most probably we might end up delaying until Monday May 25th.

cheers,

-- 
Antoine "hashar" Musso

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] CodeReview to be removed from mediawiki.org, dumps available

[Kunal Mehta]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi,

On 2020-05-18 14:46, Zoran Dori wrote:
> Hello,
>> We're planning to review the CodeReview extension, which was
>> used during the SVN era, from mediawiki.org soon.
>
> You mean to "remove extension" from mediawiki.org, right? :)

Yep, my bad. Thanks :)

- -- Kunal / Legoktm
-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAl7EJcwACgkQUvyOe+23
/KJEBA/+IG0H9IoCP6QKq/80loU9Z0F0Hg/QQS1ruthnESTLMceVp4vWI+J3JxHR
wHFecVIsJg7DSwul/7PbyLHkDrlu2DEBn6E5KfA7L6TscHRt2kuMIUAjnF5k4pRJ
Ec31tw5u4fQEK/INy9qYg24FCWxHwJxSLWnkBLJmWV+6c9amYOn9TM8M1IeCyyP4
RB9u9b9CkBGtr5bcGz49BuhDB2qN8xxYOYdFJ+m9OJPrIotiDe0Yw7yo190pUfmJ
meJzHfFaRZxrkvd+QbK885mEB9EXESBE46v6qTQ2CfC6OIMpHPAZDCVogxAfTh+A
TzinQP/3rhPIitqae5mYNDPpLbiBXNksQXe6tSLW8/z2YYYUegFydYCTqV4HlXXn
4yXWO2+CXDciqb9ZW3h6sW9FKEbt/KWNQvm6e35zx2Uf0kOkfUYWvAxGsomhceQZ
z/c1LfTy48OSxjnqnunau2LRJWHTP++KaHjTrSH+BttIPIjIZBvsfxhr6CBxg+3/
QnXFJfEOzGupAJGTxG9kpqPf5WmLWrY7jky+wvsQKtnpfVveRZ3TAkcskgZKrbll
ab6JYvF56ARi1GxzSvw+sQEDkuUvT/4yGXSQQN+r5NYRvGl7mqLED3vJFCUrF8YO
BvjyWy35ZtJwBlhOFc+9Yfr7XHRs4Ii8sjipZU6KWMFpHlAL6nE=
=rsLW
-END PGP SIGNATURE-

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Abstract Schema and Schema changes, request for help

[Amir Sarabadani]

Oh thanks for the great idea. I started "abstract-schema" hashtag and added
them to as many as possible:
https://gerrit.wikimedia.org/r/q/hashtag:%22abstract-schema%22+(status:open%20OR%20status:merged)

I just want to say these three still need reviewing:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/595311
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/595316
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/595289

Best

On Mon, May 18, 2020 at 1:47 PM Gergo Tisza  wrote:

> Thank you so much for working on this, it was one of the most painful
> aspects of core development!
>
> It might be worth using a consistent gerrit topic or hashtag to make
> finding the relevant patches easy.
>
> On Sat, May 9, 2020 at 3:21 AM Amir Sarabadani 
> wrote:
>
> > Hello,
> > In case you haven't done any changes on database schema of mediawiki
> core,
> > let me explain the process to you (if you know this, feel free to skip
> this
> > paragraph):
> > * Mediawiki core supports three types of RDBMS: MySQL, Sqlite, Postgres.
> It
> > used to be five (plus Oracle and MSSQL)
> > * For each one of these types, you need to do three parts: 1- Change the
> > tables.sql file so new installations get the new schema 2- Make .sql
> schema
> > change file, like an "ALTER TABLE" for current installations so they can
> > upgrade. 3- Wire that schema change file into *Updater.php file.
> > * For example, this is a patch to drop a column:
> > https://gerrit.wikimedia.org/r/c/mediawiki/core/+/473601 This file
> touches
> > 14 different files, adds 94 lines and removes 30.
> >
> > This is bad for several reasons:
> > * It is extremely complicated to do a even a simple schema change.
> Usually
> > something as simple as adding an column takes a whole day for me. There
> are
> > lots of complicating factors, like Sqlite doesn't have ALTER TABLE, so
> when
> > you want to make a patch for adding a column, you need to make a
> temporary
> > table with the new column, copy the old table data to it, drop the old
> > table and then rename the old table.
> > ** Imagine the pain and sorrow when you want to normalize a table meaning
> > you need to do several schema changes: 1- Add a table, 2- Add a column on
> > the old table, 3- make the column not-nullable when it's filled and make
> > the old column nullable instead 4- drop the old column.
> > * It's almost impossible to test all DBMS types, I don't have MSSQL or
> > Oracle installed and I don't even know their differences with MySQL. I
> > assume most other developers are good in one type, not all.
> > * Writing raw sqls, specially duplicated ones, and doubly specially when
> we
> > don't have CI to test (because we won't install propriety software in our
> > infra) is pretty much prone to error. My favourite one was that a new
> > column on a table was actually added to the wrong table in MSSQL and it
> > went unnoticed for two years (four releases, including one LTS).
> > * It's impossible to support more DBMS types through extensions or other
> > third party systems. Because the maintainer needs to keep up with all
> > patches we add to core and write their equivalents.
> > * For lots of reasons, these schemas are diverging, there have been
> several
> > work to just reduce this to a minimum.
> >
> > There was a RFC to introduce abstract schema and schema changes and it
> got
> > accepted and I have been working to implement this:
> > https://phabricator.wikimedia.org/T191231
> >
> > This is not a small task, and like any big work, it's important to cut it
> > to small pieces and gradually improve things. So my plan is first, I
> > abstract the schema (tables.sql files), then slowly I abstract schema
> > changes. For now, the plan is to make these .sql files automatically
> > generated through maintenance scripts. So we will have a file called
> > tables.json and when running something like:
> > php maintenance/generateSchemaSql.php --json maintenance/tables.json
> --sql
> > maintenance/tables-generated.sql --type=mysql
> > It would produce tables-generated.sql file. The code that produces it is
> > Doctrine DBAL and this is already installed as a dev dependency of core
> > because you would need Doctrine if you want to make a schema change, if
> you
> > maintain an instance, you should not need anything. Most of the work for
> > automatically generating schema is already merged and the last part that
> > wires it (and migrates two tables) is up for review:
> > https://gerrit.wikimedia.org/r/c/mediawiki/core/+/595240
> >
> > My request is that I need to make lots of patches and since I'm doing
> this
> > in my volunteer capacity, I need developers to review (and potentially
> help
> > with the work if you're excited about this like me). Let me know if
> you're
> > willing to be added in future patches and the current patch also welcomes
> > any feedback: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/595240
> >
> > I have added the documentation in
> >