[MediaWiki-CodeReview] [MediaWiki r106426]: New comment added

2011-12-18 Thread MediaWiki Mail 
Raymond posted a comment on MediaWiki.r106426.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106426#c27952

Commit summary for MediaWiki.r106426:

Initial release of the SolrStore Extension

Raymond's comment:

{{messagedocumentation}}

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r106426]: New comment added

2011-12-16 Thread MediaWiki Mail 
Nikerabbit posted a comment on MediaWiki.r106426.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106426#c27845

Commit summary for MediaWiki.r106426:

Initial release of the SolrStore Extension

Nikerabbit's comment:

Searchprovieder - Search provider

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r106426]: New comment added

2011-12-16 Thread MediaWiki Mail 
Reedy posted a comment on MediaWiki.r106426.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106426#c27852

Commit summary for MediaWiki.r106426:

Initial release of the SolrStore Extension

Reedy's comment:

Also, it's generally recommended to have the loader file of the extension the 
same name as the folder, so rename SolrConnector.php (with svn mv) to 
SolrStore.php. This makes it so the new installer can pick up the extensions 
automagically

Also, we use tabs, not spaces for leading whitespace

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview