[MediaWiki-CodeReview] [MediaWiki r106559]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail 
"Brion VIBBER" changed the status of MediaWiki.r106559 to "reverted" and 
commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106559#c28117

Old Status: fixme
> New Status: reverted

Commit summary for MediaWiki.r106559:

Make the output consistent when no second parameter is given and second 
parameter equals first parameter. This gives preference to names defined in 
MediaWiki, but when it is not in MediaWiki, it also sees whether there is one 
defined in the translated language names.

Brion VIBBER's comment:

Reverted for now in r106864.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r106559]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail 
"Brion VIBBER" changed the status of MediaWiki.r106559 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106559#c28112

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r106559:

Make the output consistent when no second parameter is given and second 
parameter equals first parameter. This gives preference to names defined in 
MediaWiki, but when it is not in MediaWiki, it also sees whether there is one 
defined in the translated language names.

Brion VIBBER's comment:

This is screaming for a unit test / regression test.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r106559]: New comment added

2011-12-18 Thread MediaWiki Mail 
"SPQRobin" posted a comment on MediaWiki.r106559.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106559#c27937

Commit summary for MediaWiki.r106559:

Make the output consistent when no second parameter is given and second 
parameter equals first parameter. This gives preference to names defined in 
MediaWiki, but when it is not in MediaWiki, it also sees whether there is one 
defined in the translated language names.

SPQRobin's comment:

Examples:
* {{#language:nl-be}} gave "nl-be",  
{{#language:nl-be|nl-be}} gave "Vlaams" with CLDR enabled
* When "nl-be" was added in MediaWiki through wgExtraLanguageNames,  
{{#language:nl-be}} was that value, but  
{{#language:nl-be|nl-be}} was still the CLDR value
With this change, both are the MediaWiki value (including 
wgExtraLanguageNames), and fall back to the CLDR when not in MediaWiki

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview