[MediaWiki-CodeReview] [MediaWiki r113669]: New comment added, and revision status changed

2012-03-20 Thread MediaWiki Mail 
Amire80 changed the status of MediaWiki.r113669 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669#c32374

Old Status: fixme
New Status: new

Commit summary for MediaWiki.r113669:

Completing the form fields.

Amire80's comment:

Addressed in r114128.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113669]: New comment added, and revision status changed

2012-03-20 Thread MediaWiki Mail 
Santhosh.thottingal changed the status of MediaWiki.r113669 to fixme and 
commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669#c32376

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r113669:

Completing the form fields.

Santhosh.thottingal's comment:

The comment for getDataModel  is wrong. It always returns an array.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113669]: New comment added, and revision status changed

2012-03-20 Thread MediaWiki Mail 
^demon changed the status of MediaWiki.r113669 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669#c32406

Old Status: fixme
New Status: new

Commit summary for MediaWiki.r113669:

Completing the form fields.

^demon's comment:

Not true, see line 62.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113669]: New comment added, and revision status changed

2012-03-18 Thread MediaWiki Mail 
Santhosh.thottingal changed the status of MediaWiki.r113669 to fixme and 
commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669#c32302

Old Status: ok
New Status: fixme

Commit summary for MediaWiki.r113669:

Completing the form fields.

Santhosh.thottingal's comment:

Please define the variable $m as array() somewhere in the beginning. And it 
would be better if the variable is renamed to a more descriptive name.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview