[MediaWiki-CodeReview] [MediaWiki r114252]: New comment added

2012-03-20 Thread MediaWiki Mail 
MaxSem posted a comment on MediaWiki.r114252.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114252#c32375

Commit summary for MediaWiki.r114252:

Refactoring dumpTextPass's error handling

MaxSem's comment:

Aa... ssert! :P

I thought we convinced you?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r114252]: New comment added

2012-03-20 Thread MediaWiki Mail 
QChris posted a comment on MediaWiki.r114252.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114252#c32377

Commit summary for MediaWiki.r114252:

Refactoring dumpTextPass's error handling

QChris's comment:

Sorry. Yes.
This patch was a few days old, before I got ... 'convinced' ;)
I will provide a fix today.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r114252]: New comment added, and revision status changed

2012-03-20 Thread MediaWiki Mail 
QChris changed the status of MediaWiki.r114252 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114252#c32378

Old Status: fixme
New Status: new

Commit summary for MediaWiki.r114252:

Refactoring dumpTextPass's error handling

QChris's comment:

See r114256, and r114257.

I transformed one assert into an if-guard, but removed the other asserts, as 
they were a double safety net for future updates.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview