[MediaWiki-CodeReview] [MediaWiki r83080]: New comment added, and revision status changed

[MediaWiki Mail]

User IAlex changed the status of MediaWiki.r83080.

Old Status: fixme
New Status: new

User IAlex also posted a comment on MediaWiki.r83080.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/83080#c20916
Commit summary:

Per Platonides, fix for r82686: make ApiUploadTest work again

Added option request parameter to User::editToken() and User::matchEditToken() 
and use them where possible from the api.
Also removed $_SESSION usage since it's no longer needed

Comment:

Fixed in r94640.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83080]: New comment added

[MediaWiki Mail]

User Tbleher posted a comment on MediaWiki.r83080.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83080#c15695

Comment:

This change breaks the CommentBox extension, which has a special page to add 
comments to pages. The special page creates a FauxRequest which it submits to 
the API (see 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Commentbox/SpecialAddComment_body.php?revision=84686view=markup
 , line 79). The FauxRequest needs a token parameter, but to create a token, 
one now needs an already constructed request.

The code now fails with an invalid token error when logged in; it works fine 
when not logged in. When reverting this and the two followup revisions, the 
extension works fine.

How should such a request be constructed using the new method?
(The easiest way would probably be to change the token parameter in FauxRequest 
later; currently, there is now way to do this using the FauxRequest API 
however, and I don't have core commit access to do it myself)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview