[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r84475.
Old Status: new
New Status: fixme
User Aaron Schulz also posted a comment on MediaWiki.r84475.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18340
Commit summary:
Blame hashar for this giant commit; he teased me for making so many smaller
ones earlier... :D
* Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as
getTarget(), getBlockers(), isAutoblocking(), getId().
* This required editing AbuseFilter and CheckUser backwards-incompatibly, so
push the rest of the changes out to those extensions.
* Attack the evil 14-parameter constructor and gratuitously-confusing
newFromDB( $notVeryImportantParameter, $moreImportantParameter)
* Reimplement the hack for bug 13611 in a slightly less fragile fashion; could
still do with further cleanup, but then again the login frontend is its own can
of worms... :S
* Remove transitionary getTargetAndType() and newFromTargetAndType() methods
* Some optimisation in parseTarget()
* Fix the broken phpunit test mentioned in r84251
Comment:
pre+ if ( $block-getType == Block::TYPE_RANGE ) {/pre
Typo, gives error message.
pre+ $this-userBlockedMessage( $wgUser-isBlockedFromCreateAccount() );/pre
Does this expect a Block input?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r84475. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17718 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: I'll assume so since the bug is marked FIXED. Resetting to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r84475. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17118 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: That's certainly not right. Fixed in r88664, don't know whether it fixes the bug you mentioned. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r84475. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17142 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: Marking FIXME; problems that are still present implicated in bug 29116 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r84475. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c16982 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: You change the decleration of userBlockedMessage() in SpecialUserlogin, but didn't update its caller at line 714 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
