[MediaWiki-CodeReview] [MediaWiki r85151]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85151.

Old Status: fixme
New Status: new

User ^demon also posted a comment on MediaWiki.r85151.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85151#c15696

Comment:

Yay for followups :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r85151]: New comment added, and revision status changed

2011-04-03 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r85151.

Old Status: new
New Status: fixme

User Catrope also posted a comment on MediaWiki.r85151.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85151#c15642

Comment:

The merge of r81960 is broken: mergeMagicWords() is added, but the other 
changes in that rev are not applied.

In Resources.php:
pre
+   'scripts' = 
'resources/mediawiki.util/mediawiki.util.jpegmeta.js',
/pre
but this file isn't in REL1_17 and the jpegmeta module isn't referenced by any 
code in REL1_17/phase3/includes

Resources.php also contains a few changes from r81719, r81721 and r81722. These 
revs weren't tagged 1.17 but should be merged, so I tagged them.

The rest is OK.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview