[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87326. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17749 Commit summary: Fix Bug 28354: Edit tab is shown as view source for blocked users, which breaks squid caching * Skip user block checks for Title::quickUserCan(). This restores the behavior from 1.16 rsp. before r65504. * Remove unnecessary check for $short count($errors), this is already handled by getUserPermissionsErrorsInternal(). Comment: This removes handling of the $short parameter. Is this intended? What differences in behavior are expected with this parameter on/off? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87326. Old Status: fixme New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17806 Commit summary: Fix Bug 28354: Edit tab is shown as view source for blocked users, which breaks squid caching * Skip user block checks for Title::quickUserCan(). This restores the behavior from 1.16 rsp. before r65504. * Remove unnecessary check for $short count($errors), this is already handled by getUserPermissionsErrorsInternal(). Comment: I'll leave that as an exercise for future cleanup then. :) No clear problems standing out otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview