[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Tim Starling posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c21571 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: The problems with this revision have been fixed. I checked the relevant fixes against IE 6 at the time. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Reedy posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c21393 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: Is this still broken? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Catrope posted a comment on MediaWiki.r87482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87482#c21394 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: I believe this is fixed now, but someone should break out an IE6 VM and check. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c17745 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: IE6 bits are follow-up to r85844. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Catrope posted a comment on MediaWiki.r87482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87482#c16711 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: It's checking against QUERY_STRING, so the actual value fed is not codeload.php/code but something more like codedebug=falsemodules=jquery.ui.foo|jquery.ui.barskin=vector/code . But the general principle is the same: this contains dots, so it matches the regex and triggers 403s for IE clients. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Duplicatebug posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c16648 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: preg_match( '/\.[^\\/:*?|%]+(#|\?|$)/i', 'load.php' ); is true. That breaks the loading of stylesheets in some cases for IE. For example bug 28840 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
