[MediaWiki-CodeReview] [MediaWiki r88871]: New comment added
User "Mormegil" posted a comment on MediaWiki.r88871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88871#c20616 Commit summary: * (bug 27465) Fix metadata extraction for SVG files using unusual namespace names The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly. Fixed up a test case (for RDF extraction) and added trimming on the whitespace. Also added another test case file that doesn't use a namespace name on the root. Comment: There is one missing “reader->” there, breaking the whole thing. See [[bugzilla:30322]]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88871]: New comment added
User "Catrope" posted a comment on MediaWiki.r88871. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88871#c17736 Commit summary: * (bug 27465) Fix metadata extraction for SVG files using unusual namespace names The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly. Fixed up a test case (for RDF extraction) and added trimming on the whitespace. Also added another test case file that doesn't use a namespace name on the root. Comment: Combine with itself?!? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88871]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r88871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88871#c17186 Commit summary: * (bug 27465) Fix metadata extraction for SVG files using unusual namespace names The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly. Fixed up a test case (for RDF extraction) and added trimming on the whitespace. Also added another test case file that doesn't use a namespace name on the root. Comment: Note that the test cases can be left out for merging to 1.17 since the dir structure is different; if want to merge them, they're started in r88865 on trunk. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88871]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r88871. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88871#c17185 Commit summary: * (bug 27465) Fix metadata extraction for SVG files using unusual namespace names The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly. Fixed up a test case (for RDF extraction) and added trimming on the whitespace. Also added another test case file that doesn't use a namespace name on the root. Comment: Combines with r88871 to make the second diff cleaner. Needs merge to 1.17, 1.17-wmf, 1.18 branches and deployment fix for http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Problems_with_SVG_images ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
