[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added, and revision status changed

2011-06-24 Thread MediaWiki Mail 
User Aaron Schulz changed the status of MediaWiki.r89576.

Old Status: new
New Status: fixme

User Aaron Schulz also posted a comment on MediaWiki.r89576.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c18676
Commit summary:

Followup r89542, validate hashes

Comment:

Yeah, these functions should be moved up.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added

2011-06-07 Thread MediaWiki Mail 
User Bryan posted a comment on MediaWiki.r89576.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89576#c17713
Commit summary:

Followup r89542, validate hashes

Comment:

ApiQueryAllimages seems to be a rather arbitrary place for 
validateSha1Base36Hash(). Isn't ApiQueryBase or ApiBase a better location?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added

2011-06-07 Thread MediaWiki Mail 
User Reedy posted a comment on MediaWiki.r89576.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c17714
Commit summary:

Followup r89542, validate hashes

Comment:

Indeed

Well, tbh, we should probably move the whole validation bit up a level or 2, 
and move the actual validation routines to somewhere in the file/similar classes

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added

2011-06-07 Thread MediaWiki Mail 
User Reedy posted a comment on MediaWiki.r89576.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c17716
Commit summary:

Followup r89542, validate hashes

Comment:

But of course, they were put there originally, as that was the only place using 
them at the time

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview