[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed

2011-07-22 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89594.

Old Status: new
New Status: resolved

User ^demon also posted a comment on MediaWiki.r89594.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89594#c1
Commit summary:

Followup r89588, adding the DISTINCT keyword is somewhat helpful

Comment:

Resolved by r89645.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89594.

Old Status: new
New Status: ok

User Hashar also posted a comment on MediaWiki.r89594.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89594#c17726
Commit summary:

Followup r89588, adding the DISTINCT keyword is somewhat helpful

Comment:

IIRC, DISTINCT does not use index on MySQL 4 and does a full scan.

Since live use some MySQL 5 version ... We should be fine :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89594.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89594#c17727
Commit summary:

Followup r89588, adding the DISTINCT keyword is somewhat helpful

Comment:

Don't computers suck?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89594.

Old Status: ok
New Status: new

User Hashar also posted a comment on MediaWiki.r89594.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89594#c17728
Commit summary:

Followup r89588, adding the DISTINCT keyword is somewhat helpful

Comment:

Resetting to new, you might want to force the index use. In bug 29287, the 
query does not seem to use repo_path index. See comment 7 :
https://bugzilla.wikimedia.org/show_bug.cgi?id=29287#c7

Follow up on bug report :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview