User "Hashar" posted a comment on MediaWiki.r89623. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89623#c17712 Commit summary:
* fixed table duplication for unit tests * fixed sequence handling when using DB prefix * deferring constraints on transaction, switching back to immediate on commit/rollback * hardcoded NLS_NUMERIC_CHARACTERS as it breaks using floats in sql if connection is in a non-US-like NLS_LANG (all vars are bound as chars) Comment: To get it reviewed, we need an oracle user :) I personally trust freakolowsky enough :b _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview