[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail 
User F.trott posted a comment on MediaWiki.r91749.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19416
Commit summary:

r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms 
Extension

Comment:

Do we need a version switch here? SF still states compatibility back to 1.15.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail 
User DieBuche posted a comment on MediaWiki.r91749.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19417
Commit summary:

r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms 
Extension

Comment:

We're already inside a pseudo version switch: if ( method_exists( $wgOut, 
'addModules' ) eg. if 1.17 or later

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail 
User F.trott posted a comment on MediaWiki.r91749.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19419
Commit summary:

r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms 
Extension

Comment:

Yes, but it does not cover the switch from mediawiki.legacy.edit to 
mediawiki.action.edit, right?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91749]: New comment added

2011-07-11 Thread MediaWiki Mail 
User DieBuche posted a comment on MediaWiki.r91749.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91749#c19421
Commit summary:

r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms 
Extension

Comment:

Right. I'll add one later

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview