[MediaWiki-CodeReview] [MediaWiki r91817]: New comment added

2011-07-11 Thread MediaWiki Mail 
User "IAlex" posted a comment on MediaWiki.r91817.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91817#c19415
Commit summary:

Now that the hooks ArticleDelete and ArticleDeleteComplete are called from 
WikiPage::doDeleteArticle() and not anymore from Article::doDelete(), let's 
call the former and handle ourself the output

Comment:

Done in r91860.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91817]: New comment added

2011-07-10 Thread MediaWiki Mail 
User "SPQRobin" posted a comment on MediaWiki.r91817.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91817#c19412
Commit summary:

Now that the hooks ArticleDelete and ArticleDeleteComplete are called from 
WikiPage::doDeleteArticle() and not anymore from Article::doDelete(), let's 
call the former and handle ourself the output

Comment:

I have not tested it, but won't [[$1]] fail for categories, so 
[[:$1]] should be used?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91817]: New comment added

2011-07-10 Thread MediaWiki Mail 
User "Nikerabbit" posted a comment on MediaWiki.r91817.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91817#c19401
Commit summary:

Now that the hooks ArticleDelete and ArticleDeleteComplete are called from 
WikiPage::doDeleteArticle() and not anymore from Article::doDelete(), let's 
call the former and handle ourself the output

Comment:

Is there no error message besides true/false?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview