[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added
User Reedy posted a comment on MediaWiki.r91882.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19423
Commit summary:
Added Global statistics support
Comment:
1 very minor issue is
pre
if(! $is_new_rating ) {
/pre
Should really be
pre
if( !$is_new_rating ) {
/pre
The other is the usage of empty... [[Manual:Coding_conventions#PHP_pitfalls]]
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added
User Yuvipanda posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19424 Commit summary: Added Global statistics support Comment: Ow, isn't !$ kinda weird? Is there any particular reasoning for this? Doesn't the ! get lost with the $? /whine ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added
User ^demon posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19425 Commit summary: Added Global statistics support Comment: No, it's the way we format our code :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91882]: New comment added
User Yuvipanda posted a comment on MediaWiki.r91882. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19427 Commit summary: Added Global statistics support Comment: Dammit, whining doesn't seem to get me anywhere. Will fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
