[MediaWiki-CodeReview] [MediaWiki r91885]: New comment added
User "Bawolff" posted a comment on MediaWiki.r91885. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91885#c21047 Commit summary: (follow-up r90256) Unit tests. Comment: Thanks. Addressed in r94825 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91885]: New comment added
User "Bawolff" posted a comment on MediaWiki.r91885. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91885#c21013 Commit summary: (follow-up r90256) Unit tests. Comment: The built in tiff handler doesn't have the ability to select pages, so it can't lose that ability (Built in tiff handler only uses the metadata to display to user in the little box on the file page, it doesn't change the way it handles a file based on its metadata). Previously it misunderstood the metadata from pagedTiffHandler and displayed garbage to the user, so just dropping it is an improvement. Code could be added to check for, and handle PagedTiffHandler style metadata appropriately, if we wanted to. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91885]: New comment added
User "Bryan" posted a comment on MediaWiki.r91885.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91885#c19764
Commit summary:
(follow-up r90256) Unit tests.
Comment:
+ // Hopefully php always serializes things in the same order.
You can unserialize and and compare the resulting arrays.
+ public function testTiffFile() {
This test can be better named.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91885]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r91885. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91885#c19456 Commit summary: (follow-up r90256) Unit tests. Comment: Hmm... this seems to sound like it'll *drop* metadata from a paged tiff file proxied from another site via an API repo. This would presumably lose ability to select pages etc or...? Should ExifBitmapHandler ever be testing metadata from a PagedTiffHandler? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
