[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r91949.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c20432
Commit summary:
Revert r91942, r91943 reimplement. wgActions doesn't contain all possible
actions!
Comment:
RevisionDelete broken for history buttons:
preif ( $request-getVal( 'action' ) == 'historysubmit' ) {/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User ^demon posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c20162 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Suggest reversion of this and related revs until we have a sane canonical way of doing actions per Brion's comment above. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c20005 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Note that I worked around this in the SpecialInterwiki extension, but it is still needed to fix this commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User DieBuche posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19590 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: EditWatchlist is fixed in r92156 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19591 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: That is a hack only for EditWatchlist, while the syntax code$request-getVal( 'action', $par )/code is used on a lot of (special) pages, so this commit should be fixed so that it works again everywhere (and r92156 is not necessary). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19592 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: In other words, it is/was expected that the action is empty when it is actually view. Another observation due to this commit: Going to Special:Random redirects you to a page with the action=view in the URL, which was not the case before this commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added, and revision status changed
User SPQRobin changed the status of MediaWiki.r91949.
Old Status: ok
New Status: fixme
User SPQRobin also posted a comment on MediaWiki.r91949.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19547
Commit summary:
Revert r91942, r91943 reimplement. wgActions doesn't contain all possible
actions!
Comment:
Stuff like code$action = $wgRequest-getVal( 'action', $par );/code in
special pages like EditWatchlist/raw return the default action ('view'
probably) instead of the $par, which is 'raw' in the case of EditWatchlist.
Another example is the Interwiki extension: Special:Interwiki/add does not
work, but Special:Interwiki?action=add does.
This is probably due to this commit, so marking as FIXME.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19548 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Indeed, it worked until r91941. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19555 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Looks like r3 tried to fix this problem in EditWatchlist (for another case where running on a particular web server config the action was always set), but it was reverted in r34462, I'm guessing due to r3 mistakenly doing an === compare between null and ). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r91949. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19488 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Ah this should work nicely. :) Longer-term we should see about putting the canonicalized 'action' var into the Context state, but for now it's read back out of the request in many places, and this should usually clear it up. One thing to watch out for might be extra 'action' parameters sneaking into URL generation when back-forming from existing links, but this shouldn't I think be a problem from what I'm seeing so far. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
