[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added, and revision status changed
User "SPQRobin" changed the status of MediaWiki.r91949.
Old Status: ok
New Status: fixme
User "SPQRobin" also posted a comment on MediaWiki.r91949.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19547
Commit summary:
Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible
actions!
Comment:
Stuff like $action = $wgRequest->getVal( 'action', $par ); in
special pages like EditWatchlist/raw return the default action ('view'
probably) instead of the $par, which is 'raw' in the case of EditWatchlist.
Another example is the Interwiki extension: Special:Interwiki/add does not
work, but Special:Interwiki?action=add does.
This is probably due to this commit, so marking as FIXME.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r91949. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19488 Commit summary: Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible actions! Comment: Ah this should work nicely. :) Longer-term we should see about putting the canonicalized 'action' var into the Context state, but for now it's read back out of the request in many places, and this should usually clear it up. One thing to watch out for might be extra 'action' parameters sneaking into URL generation when back-forming from existing links, but this shouldn't I think be a problem from what I'm seeing so far. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
