[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92112. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c20296 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Addressed points related to the original script and the changes made here and in the follow-ups in r93351. Marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User DieBuche posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c20117 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Done in r93090 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User Schnark posted a comment on MediaWiki.r92112.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19757
Commit summary:
Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit
categories and more). Move styles from shared.css into own stylesheet. Fix
regex bugs
Comment:
Just a few things I saw when reading the code (I don't want to open a bug for
each of these things, if you want to have bugs for it, you must open them
yourself):
* code_doEdit/code should check whether the edit was successful or whether
the API returned an error.
* codecontainsCat/code and code_buildRegex/code assume that the first
letter in category namespace is case-insensitive. This needn't always be the
case, use codewgCaseSensitiveNamespaces/code to test this.
* code_makeCaseInsensitive/code and code_buildRegex/code could produce
a regular expression with [--] in it if there is an alias for Category: with a
hyphen in it resp. the first character of the category is a hyphen. A similar
problem occurs with code^/code.
* codecombinedFn/code in code_handleStashedCategories/code should abort
early if one of the functions returns codefalse/code.
* Categories are changed even in nowiki tags, HTML comments etc. Things like
syntaxhighlight lang=text enclose=none{{Foo}} !-- Note: [[Category:Foo]]
is added by this template! --/syntaxhighlight probably occur in reality.
* The regular expressions for changing/removing categories aren't really
fool-proof: At least you must take spaces after codeCategory:/code into
consideration and the equivalence of space and underscore. Other things to
consider are %-encoding and HTML-entities: [[:Category:Ä]] could be represented
as syntaxhighlight lang=text
enclose=none[[Category:_%C2%A0auml;]]/syntaxhighlight in the source. If
you really program something that takes care of all that nonsense then put it
somewhere where it can be reused in gadgets/user scripts, at least I would want
to reuse it in one of my user scripts.
* Adding a category just puts it at the end of the text. If there already are
categories it should be put after the last one. For other wishes (like: put the
category before the first interwiki link) hooks that run ''after'' the change
would be helpful.
* Hooked functions should be allowed to return codefalse/code to abort
editing.
* The category to be added/changed/removed should be passed to the hook
functions in some way.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User DieBuche posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19758 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Thanks for the comments. Two things I don't agree with: * 3: [--] is not exactly beautiful, but it doesn't matter since it only matches - ( and not maybe -- ) * 6: I'm not gonna tackle those weird entities. It'll throw an error and those should be rare enough for it not to happen to often. If we wan't a 100% foolproof system, we should move away from storing stuff like this inside the wikitext. I'll implement the other ones ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92112. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19682 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Why did you change it from an object oriented script into separate variables and functions ? The original wasn't perfect and wasn't a a proper object constructor with prototype functions and an options object either, but going away from that into even less object orientation seems wrong to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19572 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Rewrite? Where is the old code? Why isn't this enabled by default? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User DieBuche posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19578 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: I opened some bugs: Bug 29880 Bug 29881 Bug 29882 Bug 29883 Bug 29885 Bug 29886 Bug 29887 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User DieBuche posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19574 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: The old code slumbered in /branches/js2 for 1 1/2 years. Enabled per default: Not yet, there are a few kinks left. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
