[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added, and revision status changed

2012-02-28 Thread MediaWiki Mail 
Awjrichards changed the status of Wikimedia.r1336 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31576

Old Status: new
New Status: fixme

Commit summary for Wikimedia.r1336:

Added two methods to query the database for payments: 
_civicrm_recurring_globalcollect_get_next_sched_contribution() and 
_civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335.

Awjrichards's comment:

Putting back to fixme per r1370. Once r1370 is resolved, this should be OK.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added, and revision status changed

2012-02-27 Thread MediaWiki Mail 
Jpostlethwaite changed the status of Wikimedia.r1336 to new and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31514

Old Status: fixme
New Status: new

Commit summary for Wikimedia.r1336:

Added two methods to query the database for payments: 
_civicrm_recurring_globalcollect_get_next_sched_contribution() and 
_civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335.

Jpostlethwaite's comment:

Why can we not do this?

This is the proper way to use the schema?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail 
Khorn (WMF) changed the status of Wikimedia.r1336 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31177

Old Status: new
New Status: fixme

Commit summary for Wikimedia.r1336:

Added two methods to query the database for payments: 
_civicrm_recurring_globalcollect_get_next_sched_contribution() and 
_civicrm_recurring_globalcollect_get_failure_retry_date(). See r1335.

Khorn (WMF)'s comment:

Same as the comment Peter made in r1329: We can't really join with 
civicrm_payment_processor on line 58. Instead, look for the transaction ID to 
be like 'GLOBALCOLLECT RECURRING%'. Bonus: No joins necessary, already indexed, 
way way faster. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview