[Wikitech-l] Gerrit/Jenkins Verification
I've noticed that sometimes Jenkins +1s changes and other times it +2s them (for Verified, that is). Is there any specific pattern to this? It's not a problem or anything; I'm just curious. I feel like it was explained back when the system was changed to +1 and +2 but I forget and can't seem to find anything in the archives. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit/Jenkins Verification
On 2013-03-22 9:24 AM, Tyler Romeo tylerro...@gmail.com wrote: I've noticed that sometimes Jenkins +1s changes and other times it +2s them (for Verified, that is). Is there any specific pattern to this? It's not a problem or anything; I'm just curious. I feel like it was explained back when the system was changed to +1 and +2 but I forget and can't seem to find anything in the archives. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l I think +1 is a merge and lint check where +2 is tests that actully execute the code, so only happens if your on the trusted list of users. Jenkins posts which tests its doing in a gerrit comment. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit/Jenkins Verification
On Fri, Mar 22, 2013 at 9:42 AM, Brian Wolff bawo...@gmail.com wrote: I think +1 is a merge and lint check where +2 is tests that actully execute the code, so only happens if your on the trusted list of users. Jenkins posts which tests its doing in a gerrit comment. -bawolff Ah, OK. That makes sense. Thanks. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
