Re: [Wikitech-l] Small tweak to Gerrit Verified category - tomorrow
On Dec 18, 2012, at 6:01 AM, Liangent liang...@gmail.com wrote: On Tue, Dec 18, 2012 at 12:45 PM, Chad innocentkil...@gmail.com wrote: Linting jobs will receive Verified ±1 votes. Unit tests jobs (triggered after someone votes CR+2, as it currently is) will receive Verified ±2 votes. Actually I prefer running unit tests on every new patchset as what we did in the past. Some issues in my code were caught by it. Afaik everybody prefers tests to be ran on submission, including yours truly. However this thread does not discuss that change. This change was made a few weeks back. Now that everything is in place we can elaborate on this. Antoine and I sent out a mai to wikitech-l just now: http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/065202.html -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Small tweak to Gerrit Verified category - tomorrow
On Mon, Dec 17, 2012 at 11:45 PM, Chad innocentkil...@gmail.com wrote: Hello, After some of the recent changes to the Gerrit workflow with Jenkins and Zuul, we've received some complaints about how Jenkins is reporting its results. Right now, it is using both the Verified and Code Review categories. This is bad because it gives you a false sense of what has been reviewed for most queries and dashboards. So tomorrow, we are going to tweak the way Jenkins reports back to Gerrit by extending the Verified vote range from -1..+1 to -2..+2. This will allow Jenkins to give a range of results, all in the Verified category (and keeping it out of Code Review, which will once again only be for humans). The new Verified range will behave as Code Review does now (-2 is veto, +2 for submit). Linting jobs will receive Verified ±1 votes. Unit tests jobs (triggered after someone votes CR+2, as it currently is) will receive Verified ±2 votes. So, anyone who's got Verified permissions on a repository (project owners, this means you), beginning tomorrow at around 13:00 UTC you will see extended Verified options. We'll let everyone know when this is complete. This is complete. We noticed this morning that there was actually a mistake in last night's e-mail: we did not add a Verified category for -2. The current Verified options look as follows: -1 : Fails 0 : No Score 1 : Checked 2 : Verified Code Review is now back to being human-only. As always, please reach out to us if you have any problems at all. -Chad Antoine ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Small tweak to Gerrit Verified category - tomorrow
Hello, After some of the recent changes to the Gerrit workflow with Jenkins and Zuul, we've received some complaints about how Jenkins is reporting its results. Right now, it is using both the Verified and Code Review categories. This is bad because it gives you a false sense of what has been reviewed for most queries and dashboards. So tomorrow, we are going to tweak the way Jenkins reports back to Gerrit by extending the Verified vote range from -1..+1 to -2..+2. This will allow Jenkins to give a range of results, all in the Verified category (and keeping it out of Code Review, which will once again only be for humans). The new Verified range will behave as Code Review does now (-2 is veto, +2 for submit). Linting jobs will receive Verified ±1 votes. Unit tests jobs (triggered after someone votes CR+2, as it currently is) will receive Verified ±2 votes. So, anyone who's got Verified permissions on a repository (project owners, this means you), beginning tomorrow at around 13:00 UTC you will see extended Verified options. We'll let everyone know when this is complete. -- The Gerrit/CI guys Chad Antoine ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Small tweak to Gerrit Verified category - tomorrow
On Tue, Dec 18, 2012 at 12:45 PM, Chad innocentkil...@gmail.com wrote: Hello, After some of the recent changes to the Gerrit workflow with Jenkins and Zuul, we've received some complaints about how Jenkins is reporting its results. Right now, it is using both the Verified and Code Review categories. This is bad because it gives you a false sense of what has been reviewed for most queries and dashboards. So tomorrow, we are going to tweak the way Jenkins reports back to Gerrit by extending the Verified vote range from -1..+1 to -2..+2. This will allow Jenkins to give a range of results, all in the Verified category (and keeping it out of Code Review, which will once again only be for humans). The new Verified range will behave as Code Review does now (-2 is veto, +2 for submit). Linting jobs will receive Verified ±1 votes. Unit tests jobs (triggered after someone votes CR+2, as it currently is) will receive Verified ±2 votes. Actually I prefer running unit tests on every new patchset as what we did in the past. Some issues in my code were caught by it. So, anyone who's got Verified permissions on a repository (project owners, this means you), beginning tomorrow at around 13:00 UTC you will see extended Verified options. We'll let everyone know when this is complete. -- The Gerrit/CI guys Chad Antoine ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -Liangent ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
