Re: [Wikitech-l] jenkins: unit test whitelist
Security concerns when running tests with arbitrary code (from anyone since labsconsole account registration opened...) from what I understand. I have requested that I am added to the whitelist here:https://gerrit.wikimedia.org/r/#/c/39712/2 Hoo also did so:https://gerrit.wikimedia.org/r/#/c/39711 (yay, merge conflicts) I really think that everyone who has +2 on a WMF-deployed extension should be on this whitelist. Hashar told me in #mediawiki that he thinks this as well. Alex On 19/12/12 10:34, Denny Vrandečić wrote: Just curious -- I probably missed it in a previous mail -- why are the tests switched off? To preserve processing power? To speed up tests for the whitelisted? Security concerns when running tests with arbitrary code? Other? Cheers, Denny 2012/12/19 Antoine Musso hashar+...@free.fr Hello, As you surely have noticed, the unit tests for mediawiki/core are no more run when a patch is submitted. I have just enabled a feature that whitelist people to have unit tests run for them on patch submission. The patch still need to be reviewed and approved with a CR+2 though. Basically any user with a @wikimedia.org or @wikimedia.de email address is whitelisted by default. I have also added a few contractors using their personal emails and several long term users. The related change is: https://gerrit.wikimedia.org/r/#/c/39310/ This is only enabled for mediawiki/core for now, I will look at applying such a whitelist on extensions too in January. There is no process to be added in the whitelist, I guess you could talk about it on IRC. If there is no obvious veto there, you could probably just amend layout.yaml in integration/zuul-config.git file and get it approved :) cheers, -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] jenkins: unit test whitelist
On Thu, Dec 20, 2012 at 8:10 PM, Krenair kren...@gmail.com wrote: Security concerns when running tests with arbitrary code (from anyone since labsconsole account registration opened...) from what I understand. I have requested that I am added to the whitelist here:https://gerrit.wikimedia.org/r/#/c/39712/2 Hoo also did so:https://gerrit.wikimedia.org/r/#/c/39711 (yay, merge conflicts) I really think that everyone who has +2 on a WMF-deployed extension should be on this whitelist. Hashar told me in #mediawiki that he thinks this as well. Alex Seems kind of odd to only run unit tests for code from experienced people. While everyone benefits from the unit tests, I imagine inexperienced new developers would benefit the most (One assumes people with @wikimedia.org emails ought to be experienced ;) -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] jenkins: unit test whitelist
On 12/20/2012 07:50 PM, bawolff wrote: Seems kind of odd to only run unit tests for code from experienced people. While everyone benefits from the unit tests, I imagine inexperienced new developers would benefit the most (One assumes people with @wikimedia.org emails ought to be experienced ;) They run for all changes, the question is when. Currently, it's when a human approves it. After some security issues are resolved (probably using Vagrant sandboxes), the plan is to run them on upload. Matt Flaschen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] jenkins: unit test whitelist
Hello, As you surely have noticed, the unit tests for mediawiki/core are no more run when a patch is submitted. I have just enabled a feature that whitelist people to have unit tests run for them on patch submission. The patch still need to be reviewed and approved with a CR+2 though. Basically any user with a @wikimedia.org or @wikimedia.de email address is whitelisted by default. I have also added a few contractors using their personal emails and several long term users. The related change is: https://gerrit.wikimedia.org/r/#/c/39310/ This is only enabled for mediawiki/core for now, I will look at applying such a whitelist on extensions too in January. There is no process to be added in the whitelist, I guess you could talk about it on IRC. If there is no obvious veto there, you could probably just amend layout.yaml in integration/zuul-config.git file and get it approved :) cheers, -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] jenkins: unit test whitelist
Just curious -- I probably missed it in a previous mail -- why are the tests switched off? To preserve processing power? To speed up tests for the whitelisted? Security concerns when running tests with arbitrary code? Other? Cheers, Denny 2012/12/19 Antoine Musso hashar+...@free.fr Hello, As you surely have noticed, the unit tests for mediawiki/core are no more run when a patch is submitted. I have just enabled a feature that whitelist people to have unit tests run for them on patch submission. The patch still need to be reviewed and approved with a CR+2 though. Basically any user with a @wikimedia.org or @wikimedia.de email address is whitelisted by default. I have also added a few contractors using their personal emails and several long term users. The related change is: https://gerrit.wikimedia.org/r/#/c/39310/ This is only enabled for mediawiki/core for now, I will look at applying such a whitelist on extensions too in January. There is no process to be added in the whitelist, I guess you could talk about it on IRC. If there is no obvious veto there, you could probably just amend layout.yaml in integration/zuul-config.git file and get it approved :) cheers, -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Project director Wikidata Wikimedia Deutschland e.V. | Obentrautstr. 72 | 10963 Berlin Tel. +49-30-219 158 26-0 | http://wikimedia.de Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e.V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/681/51985. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
