Re: [dx61] d3d9 guid + d3d9 header fixes

2003-06-30 Thread Alexandre Julliard
Raphaël Junqueira [EMAIL PROTECTED] writes:

 Index: include/d3d9types.h
 ===
 RCS file: /home/wine/wine/include/d3d9types.h,v
 retrieving revision 1.2
 diff -u -r1.2 d3d9types.h
 --- include/d3d9types.h   24 Jun 2003 19:26:51 -  1.2
 +++ include/d3d9types.h   27 Jun 2003 22:14:40 -
 @@ -1131,8 +1131,10 @@
  typedef struct _D3DADAPTER_IDENTIFIER9 {
  charDriver[MAX_DEVICE_IDENTIFIER_STRING];
  charDescription[MAX_DEVICE_IDENTIFIER_STRING];
 -charDeviceName[32]; /* Device name for GDI (ex. 
 \\.\DISPLAY1) */
 -LARGE_INTEGER   DriverVersion;
 +charDeviceName[32];
 +DWORD   DriverVersionLowPart; 
 +DWORD   DriverVersionHighPart;
 +

Isn't DriverVersionLow/HighPart supposed to be for 16-bit code?  Why
do you need to use that instead of DriverVersion?

-- 
Alexandre Julliard
[EMAIL PROTECTED]




Re: [dx61] d3d9 guid + d3d9 header fixes

2003-06-30 Thread Raphaël Junqueira
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Le Lundi 30 Juin 2003 20:13, Alexandre Julliard a écrit :
 Raphaël Junqueira [EMAIL PROTECTED] writes:
  Index: include/d3d9types.h
  ===
  RCS file: /home/wine/wine/include/d3d9types.h,v
  retrieving revision 1.2
  diff -u -r1.2 d3d9types.h
  --- include/d3d9types.h 24 Jun 2003 19:26:51 -  1.2
  +++ include/d3d9types.h 27 Jun 2003 22:14:40 -
  @@ -1131,8 +1131,10 @@
   typedef struct _D3DADAPTER_IDENTIFIER9 {
   charDriver[MAX_DEVICE_IDENTIFIER_STRING];
   charDescription[MAX_DEVICE_IDENTIFIER_STRING];
  -charDeviceName[32]; /* Device name for GDI (ex.
  \\.\DISPLAY1) */ -LARGE_INTEGER   DriverVersion;
  +charDeviceName[32];
  +DWORD   DriverVersionLowPart;
  +DWORD   DriverVersionHighPart;
  +

 Isn't DriverVersionLow/HighPart supposed to be for 16-bit code?  Why
 do you need to use that instead of DriverVersion?

Hi Alexandre,

Yes, they are here for 16bit drivers. But for me its more easier to play 
that way than with LARGE_INTEGERs.

I'll fix it when the code will work.

Regards,
Raphael
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/AJ4Pp7NA3AmQTU4RAgXBAJ95odyutmGomMkjPlqUEUf9YlNLOgCfRvID
lz41UJRDBvVm9c0W9895dJM=
=5qR1
-END PGP SIGNATURE-




Re: [dx61] d3d9 guid + d3d9 header fixes

2003-06-30 Thread Alexandre Julliard
Raphaël Junqueira [EMAIL PROTECTED] writes:

 Yes, they are here for 16bit drivers. But for me its more easier to play 
 that way than with LARGE_INTEGERs.

 I'll fix it when the code will work.

I'm not sure I like that idea, I'm worried that if code starts
depending on that it will be a pain to fix later on. If you want to
write the code using 16-bit fields you can do that locally, but I'd
prefer that you then fix it before submitting, so that we don't need
to put wrong headers in CVS.

-- 
Alexandre Julliard
[EMAIL PROTECTED]




Re: [dx61] d3d9 guid + d3d9 header fixes

2003-06-30 Thread Raphaël Junqueira
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Le Lundi 30 Juin 2003 22:51, Alexandre Julliard a écrit :
 Raphaël Junqueira [EMAIL PROTECTED] writes:
  Yes, they are here for 16bit drivers. But for me its more easier to
  play that way than with LARGE_INTEGERs.
 
  I'll fix it when the code will work.

 I'm not sure I like that idea, I'm worried that if code starts
 depending on that it will be a pain to fix later on. If you want to
 write the code using 16-bit fields you can do that locally, but I'd
 prefer that you then fix it before submitting, so that we don't need
 to put wrong headers in CVS.

ok ok,
i'll fix it on next patch

Regards,
Raphael
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/AKZdp7NA3AmQTU4RAng4AJ9Km80wb+5oR8kgX4cX7GjY0Z7/GQCfTdn0
gCHwLEKAcKc1sT7AV3ybC5w=
=ZCIS
-END PGP SIGNATURE-