Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
If you get any feedback about a proposed patch on the mailing list, you need to deal with the feedback one way or another before the patch will be applied. I'm familiar with that approach from other projects. Unfortunately I haven't received * any * feedback. However, I just did some digging in the wine-devel archive and I see Alexandre Julliard is having an ongoing discussion with Robert Lunnon regarding the Solaris ADDRESS_SPACE_LIMIT issue: http://www.winehq.com/hypermail/wine-devel/2003/01/0179.html so I guess I'll wait and see what Robert comes up with. -- John - | Feith Systems | Voice: 1-215-646-8000 | Email: [EMAIL PROTECTED] | |John Wehle| Fax: 1-215-540-5495 | | -
Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
On Fri, Jan 17, 2003 at 01:52:08PM -0500, John Wehle wrote: Currently wine exits after complaining about an invalid heap during startup on Solaris 8 x86. What happens is mmap is returning an address above 0xc000 which HEAP_InitSubHeap passes to NtAllocateVirtualMemory who rejects it. Perhaps someone familar with the code can suggest a better solution or explain why the ADDRESS_SPACE_LIMIT check is there. Correct me if I'm wrong, but AFAICS this is even the third time that you submit this. Don't you think that it would have been time to ask Alexandre what the hell he's been thinking about constantly rejecting it ? ;-) Have a nice day ! -- Andreas MohrStauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604http://mohr.de.tt
Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
Andreas Mohr [EMAIL PROTECTED] writes: Correct me if I'm wrong, but AFAICS this is even the third time that you submit this. Don't you think that it would have been time to ask Alexandre what the hell he's been thinking about constantly rejecting it ? ;-) I have explained this a number of times already. Please check the archives. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86
John Wehle wrote: Don't you think that it would have been time to ask Alexandre what the hell he's been thinking about constantly rejecting it ? ;-) Didn't know it had been rejected. I'm really not up on how wine development is done. In general I'm suppose to email [EMAIL PROTECTED] if I don't receive an ACK / NACK regarding a patch? I think it's more like: If you get any feedback about a proposed patch on the mailing list, you need to deal with the feedback one way or another before the patch will be applied. That allows Alexandre to just snoop the mailing list to get a feel for what patches pass muster. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
