Re: new wine, me whining

2002-10-19 Thread Lionel Ulmer
 Ok, now because I don't have really much time to spend on debugging
 (hope that will change soon), here is the full log with +ddraw debugmsg
 set on.

Could you try with the attached patch ? I really do not understand why the
game gave you negative values for the call to the BltFast method (it would
need a lot more debugging time to try to understand), but at least with this
patch Wine won't crash.

And it may even fix the game if these values only happen once :-)

Lionel

-- 
 Lionel Ulmer - http://www.bbrox.org/

? END
? PATCH_DDRAW
? START
Index: dlls/ddraw/dsurface/dib.c
===
RCS file: /home/wine/wine/dlls/ddraw/dsurface/dib.c,v
retrieving revision 1.17
diff -u -r1.17 dib.c
--- dlls/ddraw/dsurface/dib.c   18 Oct 2002 23:48:59 -  1.17
+++ dlls/ddraw/dsurface/dib.c   19 Oct 2002 08:51:40 -
 -802,14 +802,22 
 ddesc.dwSize = sizeof(ddesc);
 IDirectDrawSurface7_Lock(iface,NULL,ddesc,DDLOCK_WRITEONLY,0);
 
-   if (!rsrc) {
+if (!rsrc) {
   WARN(rsrc is NULL!\n);
   rsrc = rsrc2;
   rsrc-left = rsrc-top = 0;
   rsrc-right = sdesc.dwWidth;
   rsrc-bottom = sdesc.dwHeight;
-   }
-
+}
+
+if (((rsrc-left  0) || (rsrc-left  sdesc.dwWidth)) ||  
+   ((rsrc-right  0) || (rsrc-right  sdesc.dwWidth)) ||
+   ((rsrc-top  0) || (rsrc-top  sdesc.dwHeight)) ||
+   ((rsrc-bottom  0) || (rsrc-bottom  sdesc.dwHeight))) {
+WARN(Negative values in blit rectangles. Unhandled for now.\n);
+   return DDERR_UNSUPPORTED;
+}
+
 bpp = GET_BPP(This-surface_desc);
 sbuf = (BYTE *)sdesc.lpSurface+(rsrc-top*sdesc.u1.lPitch)+rsrc-left*bpp;
 dbuf = (BYTE *)ddesc.lpSurface+(dsty*ddesc.u1.lPitch)+dstx* bpp;



Re: new wine, me whining

2002-10-19 Thread sauer
  Ok, now because I don't have really much time to spend on debugging
  (hope that will change soon), here is the full log with +ddraw debugmsg
  set on.

 Could you try with the attached patch ? I really do not understand why the
 game gave you negative values for the call to the BltFast method (it would
 need a lot more debugging time to try to understand), but at least with this
 patch Wine won't crash.

 And it may even fix the game if these values only happen once :-)

Ok, it stops wine from crashing at this point (it still crashes when
exiting the program, but that is ... irrelevant), but the ingame graphics
are not drawn.
I'm attaching another debug output.

mIc



log.txt.bz2
Description: Binary data


Re: new wine, me whining

2002-10-18 Thread Lionel Ulmer
 1. when will this be fixed ?
 fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or
 DDBLT_ASYNC: can't handle right now.

Did you actually read any DirectX doc before complaining ? These flags are
completely useless when emulating a blit and have sense only when doing it
in hardware.

 wine: Unhandled exception, starting debugger...

Did you send us a backtrace of the problem ? A trace ?

 3. where can i get the old wine sources (not with first implementation of
 dx8)

CVS is your friend.

 4. why not split development of wine and DX so, that anyone can install
 the DX version he wants.

Well, what would be the advantage of that ? Do you know other
implementations of DX than the one in Wine ?

 5. what can i do to speed up development?

Start coding ?

   Lionel

-- 
 Lionel Ulmer - http://www.bbrox.org/




Re: new wine, me whining

2002-10-18 Thread sauer
  1. when will this be fixed ?
  fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or
  DDBLT_ASYNC: can't handle right now.

 Did you actually read any DirectX doc before complaining ? These flags are
 completely useless when emulating a blit and have sense only when doing it
 in hardware.

Ok, i did not and I should have done it before :(

  wine: Unhandled exception, starting debugger...

 Did you send us a backtrace of the problem ? A trace ?

here it comes:
=0 0x402acdc7 (NTDLL.DLL.memcpy+0x27 in libc.so.6) (ebp=406a29e4)
  1 0x40c90844 (DIB_DirectDrawSurface_BltFast+0x51c(iface=0x403c2da8,
dstx=0x28, dsty=0x23, src=0x403c3878, rsrc=0x406a2b8c, trans=0x10)
[dib.c:870] in ddraw.dll.so) (ebp=406a2b34)
  2 0x40c937df (IDirectDrawSurface3Impl_BltFast+0x47(This=0x403c2dac,
x=0x28, y=0x23, pSrcSurf=0x403c387c, prcSrc=0x406a2b8c, dwTrans=0x10)
[thunks.c:94] in ddraw.dll.so) (ebp=406a2b5c)
  3 0x0044ecfe (Panzer3d.exe..text+0x4dcfe in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2b9c)
  4 0x0041e30d (Panzer3d.exe..text+0x1d30d in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2bdc)
  5 0x0044e86f (Panzer3d.exe..text+0x4d86f in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2c00)
  6 0x00421ba2 (Panzer3d.exe..text+0x20ba2 in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2c14)
  7 0x004036e8 (Panzer3d.exe..text+0x26e8 in C:\games\pgiiid\Panzer3d.exe)
(ebp=406a2c30)
  8 0x0041e648 (Panzer3d.exe..text+0x1d648 in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2c4c)
  9 0x00404e08 (Panzer3d.exe..text+0x3e08 in C:\games\pgiiid\Panzer3d.exe)
(ebp=406a2c68)
  10 0x0040c3a8 (Panzer3d.exe..text+0xb3a8 in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2c84)
  11 0x00403024 (Panzer3d.exe..text+0x2024 in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2ca4)
  12 0x00421218 (Panzer3d.exe..text+0x20218 in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2cd8)
  13 0x00421716 (Panzer3d.exe..text+0x20716 in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2d00)
  14 0x407b4787 (WINPROC_wrapper+0x17 in user32.dll.so) (ebp=406a2d24)
  15 0x407b481d (WINPROC_CallWndProc+0x8d(proc=0x4215b9, hwnd=0x10021,
msg=0x202, wParam=0x0, lParam=0x1b0026a) [winproc.c:183] in user32.dll.so)
(ebp=406a2d54)
  16 0x407ba958 (CallWindowProcA+0x88(func=0x413e06c8, hwnd=0x10021,
msg=0x202, wParam=0x0, lParam=0x1b0026a) [winproc.c:2788] in
user32.dll.so) (ebp=406a2d7c)
  17 0x4079d451 (DispatchMessageA+0x121(msg=0x406a2ddc) [message.c:1079]
in user32.dll.so) (ebp=406a2dc0)
  18 0x00421fad (Panzer3d.exe..text+0x20fad in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2e08)
  19 0x0047db2e (Panzer3d.exe.EntryPoint+0x15e in
C:\games\pgiiid\Panzer3d.exe) (ebp=406a2e9c)
  20 0x400b4120 (start_process+0x21c [process.c:564] in libntdll.dll.so)
(ebp=406a2f38)
  21 0x400b829d (call_on_thread_stack+0x1d(func=0x400b3f04)
[sysdeps.c:112] in libntdll.dll.so) (ebp=406a2ff4)
  22 0x400b8430 (SYSDEPS_CallOnStack+0x14 in libntdll.dll.so)
(ebp=)

0x402acdc7 (NTDLL.DLL.memcpy+0x27 in libc.so.6): repe movsl
(%esi),%es:(%edi)

  5. what can i do to speed up development?

 Start coding ?


I did about 4 month ago and asked questions about how to go on patching
wine to get wizardry 8 running (i got it running on my system, but with
wine patched this way nothing else runs with it).

mIc





Re: new wine, me whining

2002-10-18 Thread Andreas Mohr
On Fri, Oct 18, 2002 at 09:44:17AM +0200, [EMAIL PROTECTED] wrote:
   1. when will this be fixed ?
   fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or
   DDBLT_ASYNC: can't handle right now.
 
  Did you actually read any DirectX doc before complaining ? These flags are
  completely useless when emulating a blit and have sense only when doing it
  in hardware.
 
 Ok, i did not and I should have done it before :(
 
   wine: Unhandled exception, starting debugger...
 
  Did you send us a backtrace of the problem ? A trace ?
 
 here it comes:
 =0 0x402acdc7 (NTDLL.DLL.memcpy+0x27 in libc.so.6) (ebp=406a29e4)
   1 0x40c90844 (DIB_DirectDrawSurface_BltFast+0x51c(iface=0x403c2da8,
 dstx=0x28, dsty=0x23, src=0x403c3878, rsrc=0x406a2b8c, trans=0x10)
 [dib.c:870] in ddraw.dll.so) (ebp=406a2b34)
   2 0x40c937df (IDirectDrawSurface3Impl_BltFast+0x47(This=0x403c2dac,
 x=0x28, y=0x23, pSrcSurf=0x403c387c, prcSrc=0x406a2b8c, dwTrans=0x10)
OK, that very much sounds like we've got some graphics geometry wrong
and the memcpy() done by DIB_DirectDrawSurface_BltFast() thus
catches a wrong number of bytes to copy...
Try finding out why that graphics buffer copying uses the wrong size
arguments...

-- 
The Declaration of Software Freedom:
http://freedevelopers.net/freedomdec/index.php




Re: new wine, me whining

2002-10-18 Thread Lionel Ulmer
 here it comes:
 =0 0x402acdc7 (NTDLL.DLL.memcpy+0x27 in libc.so.6) (ebp=406a29e4)
   1 0x40c90844 (DIB_DirectDrawSurface_BltFast+0x51c(iface=0x403c2da8,
 dstx=0x28, dsty=0x23, src=0x403c3878, rsrc=0x406a2b8c, trans=0x10)
 [dib.c:870] in ddraw.dll.so) (ebp=406a2b34)
   2 0x40c937df (IDirectDrawSurface3Impl_BltFast+0x47(This=0x403c2dac,
 x=0x28, y=0x23, pSrcSurf=0x403c387c, prcSrc=0x406a2b8c, dwTrans=0x10)
 [thunks.c:94] in ddraw.dll.so) (ebp=406a2b5c)
   3 0x0044ecfe (Panzer3d.exe..text+0x4dcfe in
 C:\games\pgiiid\Panzer3d.exe) (ebp=406a2b9c)

Well, could you either send me a +ddraw log of the problem or create a bug
on Bugzilla and attach the log there.

   Lionel

PS: sorry to have been a bit harsh in my first reply, but 'useless' debug
reports are annoying me :-)

-- 
 Lionel Ulmer - http://www.bbrox.org/




Re: new wine, me whining

2002-10-18 Thread sauer
  =0 0x402acdc7 (NTDLL.DLL.memcpy+0x27 in libc.so.6) (ebp=406a29e4)
1 0x40c90844 (DIB_DirectDrawSurface_BltFast+0x51c(iface=0x403c2da8,
  dstx=0x28, dsty=0x23, src=0x403c3878, rsrc=0x406a2b8c, trans=0x10)
  [dib.c:870] in ddraw.dll.so) (ebp=406a2b34)
2 0x40c937df (IDirectDrawSurface3Impl_BltFast+0x47(This=0x403c2dac,
  x=0x28, y=0x23, pSrcSurf=0x403c387c, prcSrc=0x406a2b8c, dwTrans=0x10)
  [thunks.c:94] in ddraw.dll.so) (ebp=406a2b5c)
3 0x0044ecfe (Panzer3d.exe..text+0x4dcfe in
  C:\games\pgiiid\Panzer3d.exe) (ebp=406a2b9c)

 Well, could you either send me a +ddraw log of the problem or create a bug
 on Bugzilla and attach the log there.

Ok, now because I don't have really much time to spend on debugging
(hope that will change soon), here is the full log with +ddraw debugmsg
set on. But before I will really debug this thingy, I will first try to
complete about the bugfix for wizardry 8 I mentioned about a month before
(and have also written a workaround for this game only).

mIc

P.S.: be aware that the log.txt has 3.7MB after decompressing it.

PPS: No problem with the mail beeing harsh, in fact my first mail about
this _WAS_ useless



log.txt.bz2
Description: Binary data


new wine, me whining

2002-10-17 Thread sauer
1. when will this be fixed ?
fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or
DDBLT_ASYNC: can't handle right now.
wine: Unhandled exception, starting debugger...
2. I need this to play panzer general!
3. where can i get the old wine sources (not with first implementation of
dx8)

4. why not split development of wine and DX so, that anyone can install
the DX version he wants.
5. what can i do to speed up development?

mIc