Re: richedit: Added tests to show that options are stored internally.

2009-01-11 Thread Paul Vriens 
Dylan Smith wrote:
 Wine is currently getting the window styles and using them directly, but
 the tests I added show that an internal copy is being stored by native
 richedit controls.
 ---
  dlls/riched20/tests/editor.c |   23 +++
  1 files changed, 23 insertions(+), 0 deletions(-)
 
 
 
 
 
Hi Dylan,

Care to change the GetWindowLongW and SetWindowLongW to use the A-version (or 
remove the W)? These tests will not work on Win9x I guess.

-- 
Cheers,

Paul.

Re: richedit: Added tests to show that options are stored internally.

2009-01-11 Thread Detlef Riekenberg 
On So, 2009-01-11 at 02:58 -0500, Dylan Smith wrote:

Hi Dylan.
First of all, thanks for working on riched*

 +/* EM_SETOPTIONS changes the window style, but changing the
 + * window style does not change the options. */
 +dwStyle = GetWindowLongW(hwndRichEdit, GWL_STYLE);

Almost all UNICODE functions do not work on Win9x

 +ok(dwStyle  ES_READONLY, Readonly style not set by
 EM_SETOPTIONS\n);
 +SetWindowLongW(hwndRichEdit, GWL_STYLE, dwStyle  ~ES_READONLY);

This also does not work on Win9x.
 +options = SendMessage(hwndRichEdit, EM_GETOPTIONS, 0, 0);
 +todo_wine ok(options  ES_READONLY, Readonly option set by
 SetWindowLong\n);

I tested your patch on win98se. 
As expected from reading the patch, you introduced a failure.


-- 
 
By by ... Detlef