[Wireshark-bugs] [Bug 14422] [oss-fuzz] 6LoWPAN: infinite loop (dissect_6lowpan_6loRH)

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14422

Michael Mann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Group|private, core   |
 Status|IN_PROGRESS |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14423] [oss-fuzz] S7COMM: infinite loop (s7comm_decode_ud_cpu_alarm_main)

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14423

Michael Mann  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
  Group|core, private   |
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14441] New: DIS: Malformed packet in SISO-STD-002 transmitter

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14441

Bug ID: 14441
   Summary: DIS: Malformed packet in SISO-STD-002 transmitter
   Product: Wireshark
   Version: 2.4.4
  Hardware: x86-64
OS: Windows 7
Status: UNCONFIRMED
  Severity: Normal
  Priority: Low
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: graham.sha...@blueyonder.co.uk
  Target Milestone: ---

Created attachment 16140
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16140=edit
DIS Transmitter PDU for Link 16

Build Information:
Version 2.4.4 (v2.4.4-0-g90a7be11a4)

Copyright 1998-2018 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.6.3, with WinPcap (4_1_3), with GLib 2.42.0, with
zlib 1.2.8, with SMI 0.4.8, with c-ares 1.12.0, with Lua 5.2.4, with GnuTLS
3.4.11, with Gcrypt 1.7.6, with MIT Kerberos, with GeoIP, with nghttp2 1.14.0,
with LZ4, with Snappy, with libxml2 2.9.4, with QtMultimedia, with AirPcap,
with
SBC, with SpanDSP.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with Intel(R) Core(TM)
i7-4800MQ CPU @ 2.70GHz (with SSE4.2), with 7833 MB of physical memory, with
locale English_United Kingdom.1252, with WinPcap version 4.1.3 (packet.dll
version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008),
with GnuTLS 3.4.11, with Gcrypt 1.7.6, without AirPcap.

Built using Microsoft Visual C++ 14.0 build 24215
--
DIS Transmitter PDUs for the SISO-STD-002-2006 [1] are showing [Malformed
packet: DIS].

The issue is that the modulation parameter field (function
dissect_DIS_FIELDS_MOD_PARAMS_JTIDS_MIDS) is extracting 16 bytes but the
modulation parameter record is 8 bytes long.

The attached pcap file shows a valid Transmitter PDU

[1] SISO-STD-002-2006 -
https://www.sisostds.org/DigitalLibrary.aspx?Command=Core_Download=43048

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14121] Change placement of "double chevron" in Filter Toolbar to eliminate overlap

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14121

--- Comment #9 from Gerrit Code Review  ---
Change 25840 merged by Stig Bjørlykke:
Qt: Another filter expression toolbar layout attempt.

https://code.wireshark.org/review/25840

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14121] Change placement of "double chevron" in Filter Toolbar to eliminate overlap

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14121

--- Comment #8 from Gerrit Code Review  ---
Change 25840 had a related patch set uploaded by Gerald Combs:
Qt: Another filter expression toolbar layout attempt.

https://code.wireshark.org/review/25840

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14424] Newline "\n" in packet list field increase line height for all rows

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14424

--- Comment #11 from Gerrit Code Review  ---
Change 25834 merged by Stig Bjørlykke:
ldap: Format text used in COL_INFO

https://code.wireshark.org/review/25834

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14440] Support for SDP over TLS (RFC 8122)

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14440

Kashyap Sivasubramanian  changed:

   What|Removed |Added

 CC||ksiv...@ncsu.edu

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14428] [oss-fuzz] #6296 thread_meshcop: infinite loop (get_chancount)

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14428

--- Comment #4 from Gerrit Code Review  ---
Change 25833 merged by Michael Mann:
Thread: use wider variables to prevent overflow and infinite loops

https://code.wireshark.org/review/25833

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14424] Newline "\n" in packet list field increase line height for all rows

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14424

--- Comment #10 from Gerrit Code Review  ---
Change 25834 had a related patch set uploaded by Michael Mann:
ldap: Format text used in COL_INFO

https://code.wireshark.org/review/25834

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14424] Newline "\n" in packet list field increase line height for all rows

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14424

Michael Mann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|IN_PROGRESS |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14424] Newline "\n" in packet list field increase line height for all rows

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14424

--- Comment #9 from Gerrit Code Review  ---
Change 25808 merged by Michael Mann:
ldap: Format text used in COL_INFO

https://code.wireshark.org/review/25808

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14428] [oss-fuzz] #6296 thread_meshcop: infinite loop (get_chancount)

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14428

Michael Mann  changed:

   What|Removed |Added

  Group|core, private   |

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14428] [oss-fuzz] #6296 thread_meshcop: infinite loop (get_chancount)

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14428

--- Comment #3 from Gerrit Code Review  ---
Change 25833 had a related patch set uploaded by Michael Mann:
Thread: use wider variables to prevent overflow and infinite loops

https://code.wireshark.org/review/25833

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14434] Some ENIP packets are not decoded as ENIP anymore

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14434

--- Comment #2 from Michael Mann  ---
(In reply to Michael Mann from comment #1)
> If you turn off the "Allow subdissectors to reassemble TCP streams" option,
> you will see packet 3 dissected as ENIP.

By "option", I mean "TCP dissector preference"

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14434] Some ENIP packets are not decoded as ENIP anymore

2018-02-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14434

--- Comment #1 from Michael Mann  ---
How was this trace generated that the device at 192.168.0.90 is sending only 1
byte on the stream?

The changes in I78034307b56aa537943191a6887166577936a6a3 were to handle cases
where 1-byte TCP segments were *intentionally* sent and then the data would end
up successfully reassembled.  Otherwise (ENIP and other) dissectors would
reject the packet as "not mine".

I've never seen an ENIP device *intentionally* send a 1 byte packet.  And for
the provided capture Wireshark 2.5.0/git is putting packets 1 & 3 together as a
single "ENIP packet" and because of the "extra byte" isn't getting a valid
EtherNet/IP message.  The other clue is the "[TCP segment of a reassembled
PDU]" text in the Info column.

If you turn off the "Allow subdissectors to reassemble TCP streams" option, you
will see packet 3 dissected as ENIP.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe