[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #38 from Gerrit Code Review  ---
Change 37060 had a related patch set uploaded by Guy Harris:
Fix some issues seen with a fresh run of PVS Studio

https://code.wireshark.org/review/37060

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #37 from Gerrit Code Review  ---
Change 37059 merged by Guy Harris:
Fix some issues seen with a fresh run of PVS Studio

https://code.wireshark.org/review/37059

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #36 from Gerrit Code Review  ---
Change 37059 had a related patch set uploaded by Guy Harris:
Fix some issues seen with a fresh run of PVS Studio

https://code.wireshark.org/review/37059

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #34 from Gerrit Code Review  ---
Change 37057 had a related patch set uploaded by Guy Harris:
stats_tree: plug a memory leak.

https://code.wireshark.org/review/37057

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #35 from Gerrit Code Review  ---
Change 37058 had a related patch set uploaded by Guy Harris:
stats_tree: plug a memory leak.

https://code.wireshark.org/review/37058

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #33 from Gerrit Code Review  ---
Change 37056 had a related patch set uploaded by Guy Harris:
stats_tree: plug a memory leak.

https://code.wireshark.org/review/37056

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #32 from Gerrit Code Review  ---
Change 37048 had a related patch set uploaded by Guy Harris:
stats_tree: plug a memory leak.

https://code.wireshark.org/review/37048

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #31 from Gerrit Code Review  ---
Change 37044 merged by Guy Harris:
Fix some issues seen with a fresh run of PVS Studio

https://code.wireshark.org/review/37044

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #28 from Gerrit Code Review  ---
Change 37045 had a related patch set uploaded by Guy Harris:
prefs: plug a memory leak.

https://code.wireshark.org/review/37045

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #30 from Gerrit Code Review  ---
Change 37047 had a related patch set uploaded by Guy Harris:
prefs: plug a memory leak.

https://code.wireshark.org/review/37047

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #29 from Gerrit Code Review  ---
Change 37046 had a related patch set uploaded by Guy Harris:
prefs: plug a memory leak.

https://code.wireshark.org/review/37046

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #27 from Gerrit Code Review  ---
Change 37044 had a related patch set uploaded by Martin Mathieson:
Fix some issues seen with a fresh run of PVS Studio

https://code.wireshark.org/review/37044

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #26 from Gerrit Code Review  ---
Change 37043 had a related patch set uploaded by Guy Harris:
prefs: plug a memory leak.

https://code.wireshark.org/review/37043

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #25 from Gerrit Code Review  ---
Change 37042 had a related patch set uploaded by Guy Harris:
epan/color filters: plug a memory leak.

https://code.wireshark.org/review/37042

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #24 from Gerrit Code Review  ---
Change 37041 had a related patch set uploaded by Guy Harris:
epan/color filters: plug a memory leak.

https://code.wireshark.org/review/37041

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #23 from Gerrit Code Review  ---
Change 37040 had a related patch set uploaded by Guy Harris:
epan/color filters: plug a memory leak.

https://code.wireshark.org/review/37040

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16544] travis' ppc64le builds randomly fail

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16544

--- Comment #2 from Gerrit Code Review  ---
Change 36997 merged by Peter Wu:
travis: allow ppc64le builds fail.

https://code.wireshark.org/review/36997

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16544] travis' ppc64le builds randomly fail

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16544

Peter Wu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||pe...@lekensteyn.nl
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Peter Wu  ---
(In reply to Dario Lombardo from comment #0)
> Success: https://travis-ci.org/github/crondaemon/wireshark/jobs/682133677

Ran for 22 min 59 sec, v3.3.0rc0-1140-ge548eceeac

> Out of disk space:
> https://travis-ci.org/github/crondaemon/wireshark/jobs/682368295

Ran for 28 sec, failed before debian-setup.sh could complete:

10 upgraded, 355 newly installed, 0 to remove and 75 not upgraded.
Need to get 114 MB of archives.
After this operation, 591 MB of additional disk space will be used.
E: You don't have enough free space in /var/cache/apt/archives/.

> Out of memory:
> https://travis-ci.org/github/crondaemon/wireshark/jobs/679380945

Ran for 17 min 5 sec, failed during linking and parallel builds:

[2110/2447] Linking C shared library run/libwireshark.so.0.0.0
FAILED: run/libwireshark.so.0.0.0
...
collect2: fatal error: ld terminated with signal 9 [Killed]
compilation terminated.

> Timeout: https://travis-ci.org/github/crondaemon/wireshark/jobs/681393155

Ran for 50 min, failed during ninja:

[1649/2449] Building C object
epan/dissectors/CMakeFiles/dissectors.dir/packet-pkcs12.c.o
The job exceeded the maximum time limit for jobs, and has been terminated.

> For this reason it would make sense to mark these builds allowed to fail. A
> reliable CI platform should not show random behaviors.

>From https://code.wireshark.org/review/36997, there are some other interesting
jobs:

Timeout: https://travis-ci.org/github/crondaemon/wireshark/jobs/681624115
Ran for 50 min, failed during debian-setup.sh:

Setting up fonts-dejavu-core (2.37-1) ...
The job exceeded the maximum time limit for jobs, and has been terminated.

Ran for 29 sec, out of disk space during debian-setup.sh, similar as above, but
for s390x instead of ppc64le:
https://travis-ci.org/github/crondaemon/wireshark/jobs/681945424

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #22 from Gerrit Code Review  ---
Change 37038 had a related patch set uploaded by Guy Harris:
epan/color filters: plug a memory leak.

https://code.wireshark.org/review/37038

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #20 from Gerrit Code Review  ---
Change 37036 had a related patch set uploaded by Guy Harris:
epan DTD parser: don't leak the full path string on error.

https://code.wireshark.org/review/37036

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #19 from Gerrit Code Review  ---
Change 37035 had a related patch set uploaded by Guy Harris:
epan DTD parser: don't leak the full path string on error.

https://code.wireshark.org/review/37035

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #21 from Gerrit Code Review  ---
Change 37037 had a related patch set uploaded by Guy Harris:
epan DTD parser: don't leak the full path string on error.

https://code.wireshark.org/review/37037

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16544] New: travis' ppc64le builds randomly fail

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16544

Bug ID: 16544
   Summary: travis' ppc64le builds randomly fail
   Product: Wireshark
   Version: Git
  Hardware: x86
OS: Linux
Status: UNCONFIRMED
  Severity: Major
  Priority: Low
 Component: Build process
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: lom...@gmail.com
  Target Milestone: ---

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
The ppc64le builds on travis are randomly failing. Further investigation showed
several reasons for it. I'm reporting here my findings so far.

Success: https://travis-ci.org/github/crondaemon/wireshark/jobs/682133677

Out of disk space:
https://travis-ci.org/github/crondaemon/wireshark/jobs/682368295

Out of memory: https://travis-ci.org/github/crondaemon/wireshark/jobs/679380945

Timeout: https://travis-ci.org/github/crondaemon/wireshark/jobs/681393155

For this reason it would make sense to mark these builds allowed to fail. A
reliable CI platform should not show random behaviors.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16543] Support for TLS 1.3 Authentication and Integrity only Cipher Suites draft

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16543

--- Comment #2 from Gerrit Code Review  ---
Change 37034 had a related patch set uploaded by Peter Wu:
[WIP] TLS: implement draft-camwinget-tls-ts13-macciphersuites-05

https://code.wireshark.org/review/37034

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #18 from Gerrit Code Review  ---
Change 37033 had a related patch set uploaded by Guy Harris:
epan DTD parser: don't leak the full path string on error.

https://code.wireshark.org/review/37033

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #17 from Gerrit Code Review  ---
Change 37032 merged by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37032

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #16 from Gerrit Code Review  ---
Change 37032 had a related patch set uploaded by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37032

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #14 from Gerrit Code Review  ---
Change 37031 had a related patch set uploaded by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37031

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #13 from Gerrit Code Review  ---
Change 37030 merged by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37030

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #15 from Gerrit Code Review  ---
Change 37031 merged by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37031

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #12 from Gerrit Code Review  ---
Change 37030 had a related patch set uploaded by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37030

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #11 from Gerrit Code Review  ---
Change 37027 merged by Guy Harris:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37027

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16491] Packet List Pane doesn't consume the entire pane.

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16491

--- Comment #5 from Gerrit Code Review  ---
Change 37029 had a related patch set uploaded by Tomasz Moń:
Qt: Stretch last packet list header section

https://code.wireshark.org/review/37029

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16063] Deleting a column produces a crash

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16063

--- Comment #12 from Gerrit Code Review  ---
Change 37029 had a related patch set uploaded by Tomasz Moń:
Qt: Stretch last packet list header section

https://code.wireshark.org/review/37029

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16543] New: Support for TLS 1.3 Authentication and Integrity only Cipher Suites draft

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16543

Bug ID: 16543
   Summary: Support for TLS 1.3 Authentication and Integrity only
Cipher Suites draft
   Product: Wireshark
   Version: 3.2.3
  Hardware: All
OS: All
Status: IN_PROGRESS
  Severity: Enhancement
  Priority: Low
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: pe...@lekensteyn.nl
  Target Milestone: ---

Created attachment 17745
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17745&action=edit
Packet capture for TLS13-SHA256-SHA256 and TLS13-SHA384-SHA384 sessions

Build Information:

--
Two new TLS 1.3 ciphers have been proposed that provide no record encryption.
It should be possible to show the "decrypted" contents, and optionally perform
authentication and integrity checks when the TLS 1.3 decryption secrets are
actually available.

Two two ciphers are:

   TLS_SHA256_SHA256  {0xC0, 0xB4}
   TLS_SHA384_SHA384  {0xC0, 0xB5}

Draft link:
https://tools.ietf.org/html/draft-camwinget-tls-ts13-macciphersuites-05

The generated trace was created using curl (built with WolfSSL) and WolfSSL
server example (git master, v4.4.0-stable-44-g3944c8eb7), roughly:

examples/server/server -gibv4
export SSLKEYLOGFILE=...
curl -vk https://localhost --ciphers TLS13-SHA256-SHA256
curl -vk https://localhost --ciphers TLS13-SHA384-SHA384

curl was built with curl-7_70_0-16-g9d47ff532 and a patch to enable
SSLKEYLOGFILE support.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16543] Support for TLS 1.3 Authentication and Integrity only Cipher Suites draft

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16543

--- Comment #1 from Peter Wu  ---
Created attachment 17746
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17746&action=edit
Key log file with TLS 1.3 secrets for both sessions

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #10 from Martin Mathieson  ---
(In reply to Balling from comment #7)
> Created attachment 17744 [details]
> New version for 3bb7d00d41e25f6832343ce54f3e554d392f2927
> 
> Here you are. Please try to fix memory leaks first, I do not know your API,
> all those g_string_free
> 
> These are level 1 and 2 warnings, level 3 is still the old file.

I did fix the 2 leaks you identified, there are others.  Not sure I
convincingly tested them, but hopefully there will be some review.  I suspect
they are far from the most important issues found by the scan though.  Help us
fix more?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #9 from Gerrit Code Review  ---
Change 37027 had a related patch set uploaded by Martin Mathieson:
Fix memory leak in export_object.c

https://code.wireshark.org/review/37027

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11743] Add FTDI USB dissector

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11743

--- Comment #44 from Gerrit Code Review  ---
Change 37025 had a related patch set uploaded by Tomasz Moń:
FTDI FT: Do not finalize empty composite tvb

https://code.wireshark.org/review/37025

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16335] PVS-Studio analyser long list of issues (i will give patches here and on gerrit)

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #8 from Jaap Keuter  ---
Can you remove items like these from the list:
/opt/SourceCode/wireshark/wiretap/capsa.c   139 err V570 The
'format_indicator' variable is assigned to itself.
This is a consequence of GUINT16_FROM_LE(), a file format to host order
conversion, which will be optimized away on an LE platform or produce the
proper conversion on a BE platform. Can you discriminate other possible false
positives from the list?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16542] New: The "all" merge mode doesn't necessarily check *all* IDBs

2020-05-02 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16542

Bug ID: 16542
   Summary: The "all" merge mode doesn't necessarily check *all*
IDBs
   Product: Wireshark
   Version: Git
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: Normal
  Priority: Medium
 Component: Capture file support (libwiretap)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: ghar...@sonic.net
  Target Milestone: ---

Build Information:
N/A
--
The documentation for mergecap says:

   −I  
   Sets the Interface Description Block (IDB) merge mode to use during
   merging.  mergecap −I provides a list of the available IDB merge
   modes.

   Every input file has one or more IDBs, which describe the
   interface(s) the capture was performed on originally. This includes
   encapsulation type, interface name, etc. When mergecap merges
   multiple input files, it has to merge these IDBs somehow for the
   new merged output file. This flag controls how that is
   accomplished. The currently available modes are:

* 'B': no merging of IDBs is performed, and instead all IDBs
are
 copied to the merged output file.
* 'B':  IDBs are merged only if all input files have the same
number
 of IDBs, and each IDB matches their respective entry
in the
 other files. This is the default mode.
* 'B':  Any and all duplicate IDBs are merged into one IDB,
regardless
 of what file they are in.

   Note that an IDB is only considered a matching duplicate if it has
   the same encapsulation type, name, speed, time precision, comments,
   description, etc.

The only way to check all of the IDBs in a file is to read it to the end; there
is *no* guarantee that all the IDBs will appear right after the first SHB (nor
is there any guarantee that there will only be one SHB!).  The pcapng spec
specifically (and intentionally!) allows IDBs to appear after packet blocks, as
long as the IDB for the interface on which a packet arrives appears before all
packets on that interface.

In wiretap/merge.c, merge_open_in_files() just opens the files; it doesn't read
all the way to the end.  merge_files_common() calls merge_open_in_files() and,
later, calls generate_merged_idb() if the file being written is a pcapng file. 
generate_merged_idb() calls all_idbs_are_duplicates() if the merge mode is
IDB_MERGE_MODE_ALL_SAME; all_idbs_are_duplicates() looks at the interface lists
of the files.

This means that it is *not* guaranteed to see the full interface lists, just
the interfaces that appear at the beginning of the file.

The options I see are

1) read the entire file;

2) don't claim that the "all" mode is guaranteed to check all of the
interfaces.

The second option is more costly; the latter is less correct, but maybe it's
good enough for most purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe