[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

--- Comment #6 from Alexis La Goutte  ---
It is a idea but if you want to make more complicated stuff like (t=XX, l=XX)
with t = type and l = length ? (often used on TLV dissector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

--- Comment #5 from Michael Mann  ---
(stupid tab button.  Continuing...)

enum field_data {
PI_FIELD_COMPLETE, //Show field name and value
PI_FIELD_VALUE, //Show just field value
PI_FIELD_VS_ONLY //Show just field value_string
(and I'm sure we could come up with a few other categories)

What I want to be able to do with proto_item_append_field is "lazy processing"
and only populate the field/text value when it needs to be there, just like
proto_tree_add_item (and friends).  I think the internals are there to do it, I
just haven't figured out how. 
proto_item_append_text has to do more processing when it's called and can't
offload until later.  That's what I want the big benefit of
proto_item_append_field to be.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

--- Comment #4 from Michael Mann  ---
This enhancement probably started with an eye towards TLVs, but I also had the
"wanting to copy value to parent tree" case in mind.
I think a proto_tree_add_tlv could be a possibility, but I was also thinking
about something like proto_item_append_field.

Rough signature:
enum field_data {
PI_FIELD_COMPLETE, PI_FIELD_VALUE, PI_FIELD_VS_ONLY};

void proto_item_append_field(proto_item* parent_item, proto_item* field_item,
enum field_data);

Pseudocode:
parent = proto_tree_add_item(tree, hf, tvb, offset, 2, ENC_BIG_ENDIAN);
item = proto_tree_add_item(tree, hf_other, tvb, offset, 2, ENC_BIG_ENDIAN);
/* Add value to parent */
proto_item_append_field(parent, item, PI_FIELD_VALUE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

Peter Wu  changed:

   What|Removed |Added

 CC||pe...@lekensteyn.nl

--- Comment #3 from Peter Wu  ---
In the Netlink dissector I encountered this similar TLV problem, but there I
have nested attributes like this:

Attribute: Nested attributes
Len: 24
Type: 0x8007, Nested, Nested attributes (7)
Attribute: IP_FROM
Len: 12
Type: 0x8001, Nested, IP_FROM (1)
Attribute: IPv4 address
Len: 8
Type: 0x4001, IPv4 address (1)
IPv4 address: 127.0.0.1

Would be great to have something like:

Attribute: Nested attributes
Len: 24
Type: 0x8007, Nested, Nested attributes (7)
Attribute: IP_FROM: 127.0.0.1<--- changed here
Len: 12
Type: 0x8001, Nested, IP_FROM (1)
Attribute: IPv4 address
Len: 8
Type: 0x4001, IPv4 address (1)
IPv4 address: 127.0.0.1

I think that this is not covered by the proposed patch right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

Peter Wu  changed:

   What|Removed |Added

 CC||francois.schneider@airbus.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

--- Comment #2 from Gerrit Code Review  ---
Change 17109 had a related patch set uploaded by Francois Schneider:
proto.c: add API that copies type and value of an item to the text of the
parent tree.

https://code.wireshark.org/review/17109

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

Uli Heilmeier  changed:

   What|Removed |Added

 CC||u...@heilmeier.eu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11952] Create API to more easily have fields copied to higher tree

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11952

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

--- Comment #1 from Alexis La Goutte  ---
Good idea

Like PROTO_SET_TLV_TYPE(...) ? (like there is PROTO_ITEM_SET_GENERATED...)

a new proto_tree_add_tlv ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe