[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

Gerrit Code Review  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

--- Comment #6 from Gerrit Code Review  ---
Change 17889 merged by Jaap Keuter:
ICMPv6: Add support for LLN Routing Metrics (RFC 6551)

https://code.wireshark.org/review/17889

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

--- Comment #5 from Jaap Keuter  ---
The errored packet is related to line 2533 in your change of packet-icmpv6.c. 

The (incorrect) length value '1' causes the metric_len variable to underflow,
rolling over to 255. Then it continues to dissect the data as DAG Metric
Container ad infinitum. Or more precisely, until that TVB runs out of data.

This should not happen, as in, your dissector should withstand protocol errors
in the packet it receives (which are the circumstances Wireshark gets called in
to help) as well as possible. Changing this to gint should work fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

--- Comment #4 from francisco javier sanchez-roselly 
 ---
(In reply to Jaap Keuter from comment #3)
> Created attachment 14981 [details]
> Sample packet with protocol error

the unique difference i have detected is 'Length' field in 'Metric/Constraint'
valued as 0x02, i.e. Node Energy Object. i have checked rfc6551 and this object
may contain several sub-objects 2 bytes sized -as i think currently no TLVs are
defined-. so i do not catch the error.

nevertheless, the sample includes an two Link Color Objects, as the first one
is Type 1, it must be a recorded and flag R is not set. so i must fix this
error.

> This capture contains one errored field, which should not cause the rest of
> the packet to be dissected incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

--- Comment #3 from Jaap Keuter  ---
Created attachment 14981
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14981=edit
Sample packet with protocol error

This capture contains one errored field, which should not cause the rest of the
packet to be dissected incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

Jaap Keuter  changed:

   What|Removed |Added

  Attachment #14952|... |RFC 6551 sample capture
description||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12951] Implement RFC 6551 dissection in ICMPv6 dissector

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12951

Jaap Keuter  changed:

   What|Removed |Added

URL||https://tools.ietf.org/html
   ||/rfc6551
   Hardware|x86 |All
Version|unspecified |Git
Summary|rfc6551 sample  |Implement RFC 6551
   ||dissection in ICMPv6
   ||dissector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe