[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #10 from Gerrit Code Review  ---
Change 18202 merged by Anders Broman:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18202

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Gerrit Code Review  changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #9 from Gerrit Code Review  ---
Change 18201 merged by Anders Broman:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18201

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #8 from Gerrit Code Review  ---
Change 18202 had a related patch set uploaded by Jaap Keuter:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18202

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #7 from Gerrit Code Review  ---
Change 18201 had a related patch set uploaded by Jaap Keuter:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18201

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Jacek  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #6 from Jacek  ---
thanks guys.

Will this be on the HEAD now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Gerrit Code Review  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #5 from Gerrit Code Review  ---
Change 18195 merged by Jeff Morriss:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18195

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Jaap Keuter  changed:

   What|Removed |Added

 Status|CONFIRMED   |IN_PROGRESS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-14 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #4 from Gerrit Code Review  ---
Change 18195 had a related patch set uploaded by Jaap Keuter:
Retrieve CLNP option values from the right place

https://code.wireshark.org/review/18195

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-10 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Jaap Keuter  changed:

   What|Removed |Added

 Status|INCOMPLETE  |CONFIRMED

--- Comment #3 from Jaap Keuter  ---
(In reply to Jacek from comment #0)

> as per Table 8 "Reason for discard parameter values" from ISO-8473

Or as per Table 9 "Reason for discard parameter values" from X.233, a publicly
accessible resource.

After some digging it becomes clear the iso-options dissector writer tried to
be smart by highlighting the error position in the packet as well as presenting
the error. He forgot however that the data for presentation would be retrieved
from the highlighted position, which is wrong, hence this bug. 

Obvious choice would be to feed dissect_option_rfd() with field=0, but the
other users of these functions have to be checked how these expect this to
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-10 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

--- Comment #2 from Jacek  ---
Created attachment 14982
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14982=edit
pcap with ER NPDU example

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-10 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

--- Comment #1 from Alexis La Goutte  ---
Hi Jacek,

Can you attach your pcap ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12993] CLNP dissector does not parse ER NPDU properly

2016-10-10 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12993

Alexis La Goutte  changed:

   What|Removed |Added

 Status|UNCONFIRMED |INCOMPLETE
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe