[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

--- Comment #4 from Gerrit Code Review  ---
Change 18247 merged by Anders Broman:
wslua: Do not crash on the root tree item

https://code.wireshark.org/review/18247

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

Gerrit Code Review  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-17 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

--- Comment #3 from Gerrit Code Review  ---
Change 18247 had a related patch set uploaded by Peter Wu:
wslua: Do not crash on the root tree item

https://code.wireshark.org/review/18247

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

--- Comment #2 from Redford  ---
(In reply to Jaap Keuter from comment #1)
> See the very last section (2.11) of README.dissector[1], which states that
> tree may be NULL and your code has to work either way.
> 
> [1]
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob_plain;f=doc/
> README.dissector

This README is for writing dissectors in C, not Lua. Even if you would pass
`nil` to string.format that doesn't cause a crash in standard Lua interpreter.
The bug here seems to break Lua safety - you can't dereference invalid pointer
in Lua, this is only possible when there's a bug in its engine or in
Wireshark's extensions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13017] Lua dissector crashes on "string.format("%s", tree.text)"

2016-10-15 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13017

--- Comment #1 from Jaap Keuter  ---
See the very last section (2.11) of README.dissector[1], which states that tree
may be NULL and your code has to work either way.

[1]
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob_plain;f=doc/README.dissector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe