[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #14 from Gerrit Code Review  ---
Change 19644 had a related patch set uploaded by Alexis La Goutte:
OpenFlow( (v5/1.4): Add complete dissection of error messages

https://code.wireshark.org/review/19644

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #13 from Gerrit Code Review  ---
Change 19602 had a related patch set uploaded by Alexis La Goutte:
OpenFlow (v4/1.3): rename dissect_openflow_payload_v4 to
dissect_openflow_message_v4

https://code.wireshark.org/review/19602

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #12 from Gerrit Code Review  ---
Change 19459 merged by Michael Mann:
OpenFlow (v4/1.3): Add complete dissection of error messages

https://code.wireshark.org/review/19459

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

Gerrit Code Review  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #11 from Alexis La Goutte  ---
(In reply to Arc from comment #10)
> Thanks, we will wait. I think, you can close this bug.

the bug will be automatically close when fix merged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #10 from Arc  ---
Thanks, we will wait. I think, you can close this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #9 from Alexis La Goutte  ---
(In reply to Arc from comment #8)
> Exactly what is needed! It will saves my (and not only my) nerves. When this
> patchset will be available in release?

if it is validated/merged in next major release (in june)
but nighty build will be available when merged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #8 from Arc  ---
Exactly what is needed! It will saves my (and not only my) nerves. When this
patchset will be available in release?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #7 from Gerrit Code Review  ---
Change 19459 had a related patch set uploaded by Alexis La Goutte:
OpenFlow (v4/1.3): Add complete dissection of error messages

https://code.wireshark.org/review/19459

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #6 from Arc  ---
Created attachment 15133
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15133=edit
pcap with error

In most cases whole OF message included into corresponding error message,
because OF messages relatively small (avg 100 bytes, in most cases even less).
Also lenght of whole (with included message) error message specified in field
"Length". Here pcap with more error messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #5 from Alexis La Goutte  ---
(In reply to Michael Mann from comment #4)
> Created attachment 15117 [details]
> Patch for ROLE_REQUEST
> 
> Here's a quick patch for the capture provided.  It fixes the issue for the
> ROLE_REQUEST packet provided, but seems to open a can or worms as to how far
> that can go.
> Since I don't know the protocol, others can comment on how far this patch
> has to be taken.  Do the switch statement need to be broken up for each time
> with the request reparsed? (Should the complete reparse be a preference? - I
> would vote no, but I'm not sure of the popularity of including the complete
> request in the error response)

It is like ICMP where the payload is include (but size can be limited...) (may
be look how to it is dissect on ICMP)

The problem to call all function will be to get some malformed frame (because
limited frame size...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

Michael Mann  changed:

   What|Removed |Added

  Attachment #15117|0   |1
   is patch||
  Attachment #15117|application/mbox|text/plain
  mime type||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

Michael Mann  changed:

   What|Removed |Added

 CC||mman...@netscape.net

--- Comment #4 from Michael Mann  ---
Created attachment 15117
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15117=edit
Patch for ROLE_REQUEST

Here's a quick patch for the capture provided.  It fixes the issue for the
ROLE_REQUEST packet provided, but seems to open a can or worms as to how far
that can go.
Since I don't know the protocol, others can comment on how far this patch has
to be taken.  Do the switch statement need to be broken up for each time with
the request reparsed? (Should the complete reparse be a preference? - I would
vote no, but I'm not sure of the popularity of including the complete request
in the error response)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #3 from Arc  ---
It would be great! The limit of 64 bytes is not common for all switches. Many
of them includes full OF-message in error body.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

Alexis La Goutte  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||anders.bro...@ericsson.com
 Ever confirmed|0   |1

--- Comment #2 from Alexis La Goutte  ---
The problem is to limit to only 64 first bytes...
May be add a option for force to decode !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13221] OpenFlow error messages dissected incorrectly

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13221

--- Comment #1 from Arc  ---
Created attachment 15116
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15116=edit
Graphical explanations of the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe