[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

Michael Mann  changed:

   What|Removed |Added

   See Also||https://bugs.wireshark.org/
   ||bugzilla/show_bug.cgi?id=12
   ||535

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

Michael Mann  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

--- Comment #8 from Gerrit Code Review  ---
Change 21356 merged by Guy Harris:
Improve ixveriwave dissector

https://code.wireshark.org/review/21356

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

--- Comment #7 from Guy Harris  ---
(In reply to Michael Mann from comment #6)
> packet-ieee80211.c seem to already be integrated

All but some were integrated, and the most recent commit to packet-ieee80211.c
gets the last of them, so there's no need for any of Ixia's packet-ieee80211.c
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

--- Comment #6 from Michael Mann  ---
(In reply to Guy Harris from comment #5)
> The changes to wiretap/pcap-common.c are utterly hopelessly wrong; a
> LINKTYPE_ of 261 is already officially assigned to "Z-Wave RF profileR1
> andR2 packets, as specified by ITU-T Recommendation G.9959, with some MAC
> layer fields moved.", and Ixia do *NOT* get to use it for their own
> purposes.  If they want a LINKTYPE_ value for pcap and pcapng files, they
> need to ask for it, and get a value of our (tcpdump.org's) choice assigned
> to it.

This is where the "where appropriate" in the bug title comes in.  
https://code.wireshark.org/review/21356 was my first attempt at picking the
"appropriate" (which didn't include pcap-common.c changes, packet-ieee80211.c
seem to already be integrated), but as already noted in the bug, should
probably restore some of the macros created.  I'd like that review to be the
continuation of the patch in this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

--- Comment #5 from Guy Harris  ---
The changes to wiretap/pcap-common.c are utterly hopelessly wrong; a LINKTYPE_
of 261 is already officially assigned to "Z-Wave RF profile R1 and R2 packets,
as specified by ITU-T Recommendation G.9959, with some MAC layer fields
moved.", and Ixia do *NOT* get to use it for their own purposes.  If they want
a LINKTYPE_ value for pcap and pcapng files, they need to ask for it, and get a
value of our (tcpdump.org's) choice assigned to it.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

--- Comment #4 from Gerrit Code Review  ---
Change 21356 had a related patch set uploaded by Michael Mann:
Improve ixveriwave dissector

https://code.wireshark.org/review/21356

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

Michael Mann  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |IN_PROGRESS
 CC||mman...@netscape.net

--- Comment #3 from Michael Mann  ---
(In reply to Jörg Mayer from comment #2)
> I looked at the patch and while some of it might be applicable, they will
> need to be selected manually and especially the real veriwave specific
> changes need to be found and applied manually - as we changed these files
> significantly.

Do you have capture files to verify against?  There's definitely some
hacks/reverse engineering in the code.  I've started to clean it up, but I
don't know how to test.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

--- Comment #2 from Jörg Mayer  ---
I looked at the patch and while some of it might be applicable, they will need
to be selected manually and especially the real veriwave specific changes need
to be found and applied manually - as we changed these files significantly.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13652] Import latest Ixia Veriwave code where appropriate

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13652

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

--- Comment #1 from Alexis La Goutte  ---
do you have try to apply on 2.2.1 and rebase ?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe