[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

João Valverde  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #34 from Gerrit Code Review  ---
Change 23084 merged by João Valverde:
RADIUS: Initialize vendor attribute type to zero

https://code.wireshark.org/review/23084

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #33 from Gerrit Code Review  ---
Change 23082 merged by João Valverde:
RADIUS: Add dictionary support for format= with BEGIN-VENDOR

https://code.wireshark.org/review/23082

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #32 from Gerrit Code Review  ---
Change 23084 had a related patch set uploaded by João Valverde:
RADIUS: Initialize vendor attribute type to zero

https://code.wireshark.org/review/23084

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #31 from Gerrit Code Review  ---
Change 23082 had a related patch set uploaded by João Valverde:
RADIUS: Add dictionary support for format= with BEGIN-VENDOR

https://code.wireshark.org/review/23082

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #30 from João Valverde  ---
(In reply to Marius Paliga from comment #29)
> (In reply to João Valverde from comment #28)
> > (In reply to Marius Paliga from comment #27)
> > > After changes from Bug 13938 (removed redundant VENDOR keyword) and
> > > optimization disabled there is a change, but the decoding is still 
> > > incorrect.
> > > 
> > 
> > Have you pulled change Ic43363d93f6d573ddb8d3de3e0bd62624124d104 too?
> 
> No (I built from master-2.4 branch).
> Built again from master branch (including your change) and the decoding is
> correct now.
> 
> Is is possible to merge it also to master-2.4?

Yes, I'll backport to 2.4 and check the general state of that branch.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #29 from Marius Paliga  ---
(In reply to João Valverde from comment #28)
> (In reply to Marius Paliga from comment #27)
> > After changes from Bug 13938 (removed redundant VENDOR keyword) and
> > optimization disabled there is a change, but the decoding is still 
> > incorrect.
> > 
> 
> Have you pulled change Ic43363d93f6d573ddb8d3de3e0bd62624124d104 too?

No (I built from master-2.4 branch).
Built again from master branch (including your change) and the decoding is
correct now.

Is is possible to merge it also to master-2.4?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

João Valverde  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Ever confirmed|1   |0
 Resolution|FIXED   |---

--- Comment #28 from João Valverde  ---
(In reply to Marius Paliga from comment #27)
> After changes from Bug 13938 (removed redundant VENDOR keyword) and
> optimization disabled there is a change, but the decoding is still incorrect.
> 

Have you pulled change Ic43363d93f6d573ddb8d3de3e0bd62624124d104 too?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #27 from Marius Paliga  ---
After changes from Bug 13938 (removed redundant VENDOR keyword) and
optimization disabled there is a change, but the decoding is still incorrect.

Extended values are taken to decode Vendor-Specific and
Extended-Vendor-Specific-1 are decoded as unknown:


RADIUS Protocol
Code: Access-Accept (2)
Packet identifier: 0x1 (1)
Length: 183
Authenticator: 4546148f8caabcd344549bc6c6ada779
Attribute Value Pairs
AVP: l=19 t=User-Name(1): 00:00:00:00:00:05
AVP Type: 1
AVP Length: 19
User-Name: 00:00:00:00:00:05
AVP: l=21 t=Vendor-Specific(26) v=Alcatel-Lucent (formerly 'Panthera
Networks, Inc.')(6527)
AVP Type: 26
AVP Length: 21
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=15 t=Alc-Ext-Attribute4(12): [wrong length for IP address]
VSA Type: 12
VSA Length: 15
AVP: l=25 t=Vendor-Specific(26) v=Alcatel-Lucent (formerly 'Panthera
Networks, Inc.')(6527)
AVP Type: 26
AVP Length: 25
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=19 t=Alc-Ext-Attribute3(11): [unhandled integer length(17)]
VSA Type: 11
VSA Length: 19
AVP: l=12 t=Extended-Vendor-Specific-1(241.26) v=Alcatel-Lucent
(formerly 'Panthera Networks, Inc.')(6527)
AVP Type: 241
AVP Length: 12
AVP Extended Type: 26
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=5 t=Unknown-Attribute(9): 0005
VSA Type: 9
Unknown-Attribute: 0005
AVP: l=25 t=Vendor-Specific(26) v=Alcatel-Lucent (formerly 'Panthera
Networks, Inc.')(6527)
AVP Type: 26
AVP Length: 25
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=19 t=Unknown-Attribute(225):
30303a30303a30303a30303a30303a3035
VSA Type: 225
VSA Length: 19
Unknown-Attribute: 30303a30303a30303a30303a30303a3035
AVP: l=11 t=Extended-Vendor-Specific-1(241.26) v=Alcatel-Lucent
(formerly 'Panthera Networks, Inc.')(6527)
AVP Type: 241
AVP Length: 11
AVP Extended Type: 26
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=4 t=Unknown-Attribute(15): 353a35
VSA Type: 15
Unknown-Attribute: 353a35
AVP: l=20 t=Framed-IPv6-Prefix(97): 3ffe:0:0:5::/64
AVP Type: 97
AVP Length: 20
Framed-IPv6-Prefix: 00403ffe0005
AVP: l=18 t=Extended-Vendor-Specific-1(241.26) v=Alcatel-Lucent
(formerly 'Panthera Networks, Inc.')(6527)
AVP Type: 241
AVP Length: 18
AVP Extended Type: 26
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=11 t=Unknown-Attribute(14): 7461726765743a353a35
VSA Type: 14
Unknown-Attribute: 7461726765743a353a35
AVP: l=12 t=Extended-Vendor-Specific-1(241.26) v=Alcatel-Lucent
(formerly 'Panthera Networks, Inc.')(6527)
AVP Type: 241
AVP Length: 12
AVP Extended Type: 26
AVP Vendor ID: Alcatel-Lucent (formerly 'Panthera Networks, Inc.')
(6527)
VSA: l=5 t=Unknown-Attribute(10): 0005
VSA Type: 10
Unknown-Attribute: 0005

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #26 from Marius Paliga  ---
> 
> I don't know why but GCC 7 with -O2 and above is giving me problems. I'm
> suspicious of -foptimize-sibling-calls but calling compiler bug is always
> fraught with peril.
> 
> Can you try anyway with optimizations disabled (or clang) and check whether
> it solves anything?
> 
> And do report any outstanding bugs for this please.

Does not seem to help:

make CFLAGS='-g -O0' CXXFLAGS='-g -O0'

# tshark -T fields -e radius.Alc_Subsc_ID_Str
tshark: Some fields aren't valid:
radius.Alc_Subsc_ID_Str

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #25 from João Valverde  ---
(In reply to Marius Paliga from comment #24)
> ./autogen.sh
> ./configure --prefix=/opt/wireshark --with-lua --enable-warnings-as-errors=no
> make
> make install
> 
> 
> tshark -v
> TShark (Wireshark) 2.4.0 (8a3e6bbc3c from master.el6-2.4)
> 
> Copyright 1998-2017 Gerald Combs  and contributors.
> License GPLv2+: GNU GPL version 2 or later
> 
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> Compiled (64-bit) with libpcap, without POSIX capabilities, without libnl,
> with
> GLib 2.44.1, with zlib 1.2.3, without SMI, without c-ares, with Lua 5.1.4,
> with
> GnuTLS 3.5.11, with Gcrypt 1.4.5, with MIT Kerberos, without GeoIP, without
> nghttp2, without LZ4, without Snappy, with libxml2 2.7.6.
> 
> Running on Linux 2.6.32-696.1.1.el6.x86_64, with Intel(R) Xeon(R) CPU
> X3440  @ 2.53GHz (with SSE4.2), with 16072 MB of physical memory, with locale
> en_US.UTF-8, with libpcap version 1.7.2, with GnuTLS 3.5.11, with Gcrypt
> 1.4.5,
> with zlib 1.2.3.
> 
> Built using gcc 6.3.0.

I don't know why but GCC 7 with -O2 and above is giving me problems. I'm
suspicious of -foptimize-sibling-calls but calling compiler bug is always
fraught with peril.

Can you try anyway with optimizations disabled (or clang) and check whether it
solves anything?

And do report any outstanding bugs for this please.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #24 from Marius Paliga  ---
./autogen.sh
./configure --prefix=/opt/wireshark --with-lua --enable-warnings-as-errors=no
make
make install


tshark -v
TShark (Wireshark) 2.4.0 (8a3e6bbc3c from master.el6-2.4)

Copyright 1998-2017 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with libpcap, without POSIX capabilities, without libnl, with
GLib 2.44.1, with zlib 1.2.3, without SMI, without c-ares, with Lua 5.1.4, with
GnuTLS 3.5.11, with Gcrypt 1.4.5, with MIT Kerberos, without GeoIP, without
nghttp2, without LZ4, without Snappy, with libxml2 2.7.6.

Running on Linux 2.6.32-696.1.1.el6.x86_64, with Intel(R) Xeon(R) CPU
X3440  @ 2.53GHz (with SSE4.2), with 16072 MB of physical memory, with locale
en_US.UTF-8, with libpcap version 1.7.2, with GnuTLS 3.5.11, with Gcrypt 1.4.5,
with zlib 1.2.3.

Built using gcc 6.3.0.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #23 from João Valverde  ---
(In reply to Marius Paliga from comment #20)
> I just built windows version and everything is OK here. So I have problem
> just with linux version.

Can you confirm how you are building the Linux version? I'm seeing different
results with different build options.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #9 from Marius Paliga  ---
Created attachment 15607
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15607=edit
Dictionary with Extended-Vendor-Specific attributes

Attaching sample dictionary with both "normal" and extended attributes

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #8 from João Valverde  ---
@Marius Can you provide the full dictionary for this capture?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #7 from Gerrit Code Review  ---
Change 21913 had a related patch set uploaded by Michael Mann:
RADIUS: Fix gda9363e202

https://code.wireshark.org/review/21913

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #6 from João Valverde  ---
Change 21911 should prevent displaying a wrong EVS value type.

Next step would be to extend the parser for BEGIN-VENDOR and also the vendor
dictionary hash table with the larger key space.

Also add an EVS subtree to the UI instead of a VSA where appropriate.

The if (VSA || EVS) condition in dissect_attribute_value_pairs() should be
split into separate branches for sanity.

Feedback welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #5 from Gerrit Code Review  ---
Change 21911 had a related patch set uploaded by João Valverde:
RADIUS: Fix gda9363e202

https://code.wireshark.org/review/21911

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

--- Comment #4 from João Valverde  ---
Unless there is a bug in the dissector code (quite possible) I edited the title
to be more descriptive.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13745] RADIUS dictionary: BEGIN-VENDOR does not support format=Extended-Vendor-Specific-*

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13745

João Valverde  changed:

   What|Removed |Added

Summary|RADIUS: Vendor-Specific |RADIUS dictionary:
   |Extended Attributes (RFC|BEGIN-VENDOR does not
   |6929) are not correctly |support
   |decoded |format=Extended-Vendor-Spec
   ||ific-*

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe