[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

Uli Heilmeier  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|IN_PROGRESS |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #8 from Gerrit Code Review  ---
Change 25168 merged by Anders Broman:
CDP: Resolve 802.2 Protocol type protocols, show IPv6

https://code.wireshark.org/review/25168

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

Uli Heilmeier  changed:

   What|Removed |Added

 CC||u...@heilmeier.eu
 Ever confirmed|0   |1
 Status|UNCONFIRMED |IN_PROGRESS

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #7 from Garri  ---
Created attachment 16061
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16061=edit
CDPv2 packet with CLNS/AppleTalk/IPX addresses

I've failed to find any usable address of non-SNAP proto, but I've found that
AppleTalk (ethertype 0x809B) and IPX (ethertype 0x8137) protocols are not
resolved too. The CDP packet with CLNS, AppleTalk and IPX addresses is
attached.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #6 from Garri  ---
(In reply to Guy Harris from comment #5)
> That comment says
> 
>   Length of protocol field, 1 for PT = 1, and either 3 or 8 for
>   802.2 format depending if SNAP is used for PT = 2.
> 
> "Either 3 or 8" suggests that having protocols identified by an 802.2 SAP is
> possible, so there's no guarantee that the DSAP and SSAP are 0xAA with the
> 802.2 header followed by a SNAP header.
> 
> If by
> 
>   The OUI is 00 for ethernet and 
>   is the assigned Ethernet type code for the particular protocol.
> 
> they mean to indicate that they do not support OUI values other than 00,
> then checking the length may be sufficient (although tcpdump does check for
> 0300 as well as checking the protocol type for 86DD).

Thank you, I got the course of your thought. Unfortunately, I can't
find/generate CDP packets with SAP other than 0xAA at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #5 from Guy Harris  ---
(In reply to Garri from comment #4)
> (In reply to Guy Harris from comment #3)
> > (In reply to Garri from comment #0)
> > > Below is comment from cdpsnarf sources [1]:
> > > 
> > >   /*
> > >* The cool thing with protocols other than IP and ISO CLNS
> > >* (whose protocol length is 1 byte)
> > >* is that they all have a suffix of 0x0300 so we can
> > >* ignore it and store only the 2 last hex values (ex. 86dd for IPv6)
> > >* 
> > >*/
> > 
> > Have Cisco committed to that, or do they currently use only SNAP headers but
> > leave open the possibility of using 802.2 without a SNAP header, or do they,
> > in fact, use 802.2 without a SNAP header already?
> 
> Guy, please ignore this comment, the comment 1 is from more reliable source
> related to Cisco VPP product.

That comment says

  Length of protocol field, 1 for PT = 1, and either 3 or 8 for
  802.2 format depending if SNAP is used for PT = 2.

"Either 3 or 8" suggests that having protocols identified by an 802.2 SAP is
possible, so there's no guarantee that the DSAP and SSAP are 0xAA with the
802.2 header followed by a SNAP header.

If by

  The OUI is 00 for ethernet and 
  is the assigned Ethernet type code for the particular protocol.

they mean to indicate that they do not support OUI values other than 00,
then checking the length may be sufficient (although tcpdump does check for
0300 as well as checking the protocol type for 86DD).

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #4 from Garri  ---
(In reply to Guy Harris from comment #3)
> (In reply to Garri from comment #0)
> > Below is comment from cdpsnarf sources [1]:
> > 
> >   /*
> >* The cool thing with protocols other than IP and ISO CLNS
> >* (whose protocol length is 1 byte)
> >* is that they all have a suffix of 0x0300 so we can
> >* ignore it and store only the 2 last hex values (ex. 86dd for IPv6)
> >* 
> >*/
> 
> Have Cisco committed to that, or do they currently use only SNAP headers but
> leave open the possibility of using 802.2 without a SNAP header, or do they,
> in fact, use 802.2 without a SNAP header already?

Guy, please ignore this comment, the comment 1 is from more reliable source
related to Cisco VPP product.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #3 from Guy Harris  ---
(In reply to Garri from comment #0)
> Below is comment from cdpsnarf sources [1]:
> 
>   /*
>* The cool thing with protocols other than IP and ISO CLNS
>* (whose protocol length is 1 byte)
>* is that they all have a suffix of 0x0300 so we can
>* ignore it and store only the 2 last hex values (ex. 86dd for IPv6)
>* 
>*/

Have Cisco committed to that, or do they currently use only SNAP headers but
leave open the possibility of using 802.2 without a SNAP header, or do they, in
fact, use 802.2 without a SNAP header already?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #2 from Gerrit Code Review  ---
Change 25168 had a related patch set uploaded by Uli Heilmeier:
CDP: Resolve 802.2 Protocol type protocols

https://code.wireshark.org/review/25168

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14311] CDPv2 Addresses TLV: WS should recognize IPv6 proto and display IPv6 address in native form

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14311

--- Comment #1 from Garri  ---
Found useful comments in VPP sources [1]:

/*
  105   The address TLV looks as follows:
  106 
  107  
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  108   |Number of addresses   
|
  109  
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  110   |   IDRP encoded address   
|
  111  
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  112 
  113   An address is encoded in IDRP format:
  114 
  1150   1   2   3
  1160 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1
  117  
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  118   |   PT  |PT Length  |Protocol (variable) ...
  119  
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  120   |Address length |Address (variable) ...
  121  
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  122 
  123   PT: Protocol type
  124   1 = NLPID format
  125   2 = 802.2 format
  126 
  127   PT Length:
  128   Length of protocol field, 1 for PT = 1, and either 3 or 8
for
  129   802.2 format depending if SNAP is used for PT = 2.
  130 
  131   The encodings for the other protocols have the following
format:
  132 
  133   field:<---OUI-->
  134 | | | | | | | |  |
  135   bytes:0 1 2 3 4 5 6 7  8
  136 
  137   where the first 3 bytes are 0x03 for SNAP encoded
addresses.
  138   The OUI is 00 for ethernet and 
  139   is the assigned Ethernet type code for the particular protocol.
  140   e.g. for DECnet the encoding is 03 00 6003.
  141for IPv6   the encoding is 03 00 86DD
  142 */


[1] https://docs.fd.io/vpp/17.10/d2/d71/cdp__protocol_8h_source.html

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe