https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14320
Bug ID: 14320
Summary: Duplicate code to dissect docsis modem capabilities
Product: Wireshark
Version: Git
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: Enhancement
Priority: Low
Component: Dissection engine (libwireshark)
Assignee: bugzilla-ad...@wireshark.org
Reporter: bruno.verstu...@excentis.com
Target Milestone: ---
Build Information:
TShark (Wireshark) 2.5.0 (v2.5.0rc0-2301-g3f2f1641)
Copyright 1998-2018 Gerald Combs <ger...@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (64-bit) with libpcap, with POSIX capabilities (Linux), with libnl 3,
with GLib 2.48.2, with zlib 1.2.8, with SMI 0.4.8, with c-ares 1.10.0, with Lua
5.2.4, with GnuTLS 3.4.10, with Gcrypt 1.6.5, with MIT Kerberos, with GeoIP,
with nghttp2 1.7.1, with LZ4, with Snappy, with libxml2 2.9.3.
Running on Linux 4.4.0-21-generic, with Intel(R) Core(TM)2 CPU 6600 @
2.40GHz, with 7917 MB of physical memory, with locale en_US.UTF-8, with libpcap
version 1.7.4, with GnuTLS 3.4.10, with Gcrypt 1.6.5, with zlib 1.2.8, binary
plugins supported (15 loaded).
Built using gcc 5.4.0 20160609.
--
There are lots of places in the code where the docsis modem capabilities are
decoded:
* plugins/docsis/packet-tlv.c: dissect_modemcap
* epan/dissectors/packet-bootp.c: dissect_docsis_cm_cap
* epan/dissectors/packet-dhcpv6.c: dissect_modemcap
DOCSIS 3.1 adds a lot of modem capabilities that are not implemented yet. These
have to be added to the code in the 3 places described above.
An other approach could be to use 1 implementation (e.g. the one in the docsis
plugin), and to call this dissector from the other places.
Extra complications with this approach:
* in packet-bootp, modem capabilities can appear both in option 60 and option
125. In option 60, the modem capabilities are formatted as an ascii string.
* existing display filters can change
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
