[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking sometimes doesn't work

2018-01-13 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

 CC||rkn...@gmail.com

--- Comment #4 from Guy Harris  ---
When you click on a new packet, ProtoTree::rowsInserted() is handed start and
end values that correspond to what you see in a *completely unexpanded* tree,
so it only checks the *top-level* rows to see if *they* should be expanded.

I'm not sure whether, when a row is expanded, ProtoTree::rowsInserted() is then
called to reflect the additional rows.  That doesn't *appear* to be happening.

We probably need to handle expanded vs. collapsed differently in the ProtoTree
class.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking sometimes doesn't work

2018-01-13 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #3 from Guy Harris  ---
It looks as if ProtoNode::isExpanded() isn't being called for *all* nodes when
you click on a packet.  It needs to be.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking sometimes doesn't work

2018-01-13 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

Summary|Subtree expand/collapse |Subtree expand/collapse
   |tracking doesn't work   |tracking sometimes doesn't
   ||work

--- Comment #2 from Guy Harris  ---
But, to open up tcp.flags, I first have to open up tcp - and that *does* open
up when I click on another packet.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe