[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

Anders Broman  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|IN_PROGRESS |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #9 from Gerrit Code Review  ---
Change 27546 merged by Anders Broman:
Add missing image file to distribution tarball

https://code.wireshark.org/review/27546

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #8 from Gerrit Code Review  ---
Change 27546 had a related patch set uploaded by Jaap Keuter:
Add missing image file to distribution tarball

https://code.wireshark.org/review/27546

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

Jaap Keuter  changed:

   What|Removed |Added

 Blocks||14676


Referenced Bugs:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14676
[Bug 14676] Files missing from docbook CMake file
-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #7 from Gerrit Code Review  ---
Change 27455 merged by Anders Broman:
Add missing image file to distribution tarball

https://code.wireshark.org/review/27455

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #6 from Gerrit Code Review  ---
Change 27455 had a related patch set uploaded by Jaap Keuter:
Add missing image file to distribution tarball

https://code.wireshark.org/review/27455

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

Jaap Keuter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |IN_PROGRESS
 Ever confirmed|0   |1

--- Comment #5 from Jaap Keuter  ---
Back to the original bug: "The docbook/wsug_graphics/ws-tcp-analysis.png file
isn't included in the Wireshark 2.6.0 release tarball." This is to be patched
in docbook/Makefile.am, where the distribution files are defined. 

The other issues with missing files in docbook/CMakeLists.txt is a build
dependency issue, not a packaging issue. Therefore the comment "This seems to
apply to git master as well." seems to be no longer relevant since distribution
(or any build step for that matter) is no longer driven by (autotools
generated) makefiles, but through git-archive (via
tools/git-export-release.sh).

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #4 from Christopher Maynard  ---
All 15* files not listed in docbook/CMakeLists.txt are listed in
docbook/Makefile.am and docbook/Makefile.in.

*NOTE: I had missed docbook/wsug_src/ws-capture-interface-details.png earlier,
and it is used and is listed in Makefile.am and Makefile.in too.

docbook/wsug_src/WSUG_chapter_capture.asciidoc:635:image::wsug_graphics/ws-capture-interface-details.png[{screenshot-attrs}]

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #3 from Christopher Maynard  ---
I forgot to include the image files included in docbook/wsug_graphics/toolbar/,
so after including those, I did not find any other image files listed in
docbook/CMakeLists.txt that are not included in the tarball besides
ws-tcp-analysis.png.

However, there are a few files that are included in the tarball that are not
listed in docbook/CMakeLists.txt:

1) docbook/wsug_graphics/captureOptions.png
Apparently not used.

2) docbook/wsug_graphics/ws-capture-options-compile-selected-bpfs.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:454:image::wsug_graphics/ws-capture-options-compile-selected-bpfs.png[{screenshot-attrs}]

3) ws-capture-options-manage-interfaces.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:468:image::wsug_graphics/ws-capture-options-manage-interfaces.png[{screenshot-attrs}]

4) docbook/wsug_graphics/ws-capture-options-manage-interfaces-local.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:489:image::wsug_graphics/ws-capture-options-manage-interfaces-local.png[{screenshot-attrs}]

5) docbook/wsug_graphics/ws-capture-options-manage-interfaces-pipes.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:474:image::wsug_graphics/ws-capture-options-manage-interfaces-pipes.png[{screenshot-attrs}]

6) docbook/wsug_graphics/ws-capture-options-manage-interfaces-remote.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:508:image::wsug_graphics/ws-capture-options-manage-interfaces-remote.png[{screenshot-attrs}]

7) docbook/wsug_graphics/ws-capture-options-manage-interfaces-remote-plus.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:554:image::wsug_graphics/ws-capture-options-manage-interfaces-remote-plus.png[{screenshot-attrs}]

8) docbook/wsug_graphics/ws-capture-options-output.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:653:image::wsug_graphics/ws-capture-options-output.png[{screenshot-attrs}]

9) docbook/wsug_graphics/ws-capture-options-settings.png
docbook/wsug_src/WSUG_chapter_capture.asciidoc:361:image::wsug_graphics/ws-capture-options-settings.png[{screenshot-attrs}]

10) docbook/wsug_graphics/ws-gui-interface-options.png
docbook/wsug_src/WSUG_chapter_customize.asciidoc:692:image::wsug_graphics/ws-gui-interface-options.png[{screenshot-attrs}]

11) docbook/wsug_graphics/ws-stats-compare.png
docbook/wsug_src/WSUG_chapter_statistics.asciidoc:403:image::wsug_graphics/ws-stats-compare.png[{screenshot-attrs}]

12) docbook/wsug_graphics/ws-statusbar-filter.png
docbook/wsug_src/WSUG_chapter_use.asciidoc:1015:image::wsug_graphics/ws-statusbar-filter.png[{statusbar-attrs}]

13) docbook/wsug_graphics/ws-statusbar-profile.png
docbook/wsug_src/WSUG_chapter_use.asciidoc:994:image::wsug_graphics/ws-statusbar-profile.png[{pdf-scaledwidth},height=192]

14) docbook/wsug_graphics/ws-tel-rtpstream-analysis.png
docbook/wsug_src/WSUG_chapter_telephony.asciidoc:26:image::wsug_graphics/ws-tel-rtpstream-analysis.png[{screenshot-attrs}]

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #2 from Christopher Maynard  ---
(In reply to Jaap Keuter from comment #1)
> Looking at docbook/CMakeFiles.txt symbol WSUG_GRAPHICS I see many more files
> present in the repository directory than listed for this symbol, one of them
> being ws-tcp-analysis.png. Does that mean that other files(*) are missing
> from the tarball, or are these other image files redundant and ready for
> removal?

There are 111 docbook/wsug_graphics/*.png files that are currently included in
the tarball, whereas I count 129 entries in docbook/CMakeLists.txt.  Of those
not included, only ws-tcp-analysis.png caused a problem when building the
documentation.  I don't know what the story is with the other 17 missing files.

./wsug_src/WSUG_chapter_advanced.asciidoc:346:image::wsug_graphics/ws-tcp-analysis.png[{screenshot-attrs}]

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14634] File missing from release tarball

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14634

--- Comment #1 from Jaap Keuter  ---
Looking at docbook/CMakeFiles.txt symbol WSUG_GRAPHICS I see many more files
present in the repository directory than listed for this symbol, one of them
being ws-tcp-analysis.png. Does that mean that other files(*) are missing from
the tarball, or are these other image files redundant and ready for removal?

(*) eg:
ws-capture-interface-details.png
ws-capture-options-compile-selected-bpfs.png
ws-capture-options-manage-interfaces-pipes.png
ws-statusbar-profile.png
etc.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe