[Wireshark-bugs] [Bug 5450] Reassembly function works with V1.2.1, but doesn't work with V1.4.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5450 Jonathan Atkins jonathancatk...@gmail.com changed: What|Removed |Added CC||jonathancatk...@gmail.com --- Comment #1 from Jonathan Atkins jonathancatk...@gmail.com 2010-12-16 15:36:43 PST --- I have the same problem, though I have not checked the return values in the same way. I have to set the filter for my protocol and hit reload and then it works right. I am following the same procedure as in the dev docs and also demonstrated and working in the wai protocol decoder. I have had no other success in figuring out why it fails to reassemble without the above mentioned work-around yet. Loading a file with only my protocol's packets makes no difference, I still have to set the filter and reload. Clearing the filter and reloading undoes the work-around to the initial state. -- Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 5450] Reassembly function works with V1.2.1, but doesn't work with V1.4.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5450 Jeff Morriss jeff.morriss...@gmail.com changed: What|Removed |Added CC||jeff.morriss...@gmail.com --- Comment #2 from Jeff Morriss jeff.morriss...@gmail.com 2010-12-16 16:31:23 PST --- Reassembly only happens on the first pass through the file. I'm not aware of this changing between 1.2 and 1.4, but I haven't paid attention to the reassembly stuff. This means that your dissector(s) need to be sure to call the reassembly functions even when (!tree). Could that be the problem? Jonathan's comments about the different behavior with and without a display filter (which controls whether or not tree is set) makes me suspect it. -- Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 5450] Reassembly function works with V1.2.1, but doesn't work with V1.4.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5450 Jonathan Atkins jonathancatk...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #3 from Jonathan Atkins jonathancatk...@gmail.com 2010-12-16 17:03:22 PST --- (In reply to comment #2) Reassembly only happens on the first pass through the file. I'm not aware of this changing between 1.2 and 1.4, but I haven't paid attention to the reassembly stuff. This means that your dissector(s) need to be sure to call the reassembly functions even when (!tree). Could that be the problem? Jonathan's comments about the different behavior with and without a display filter (which controls whether or not tree is set) makes me suspect it. that was it! my reassembly now happens without the filter. Thanks! I dunno what changed between versions but it revealed this coding style error. Suggest to update docs to remind developer to always do the fragment processing whether or not tree is non-null. -- Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 5450] Reassembly function works with V1.2.1, but doesn't work with V1.4.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5450 --- Comment #4 from Jeff Morriss jeff.morriss...@gmail.com 2010-12-16 17:29:02 PST --- README.developer, at least, says: Note, however, that you must fill in column information, create conversations, reassemble packets, build any other persistent state needed for dissection, and call subdissectors regardless of whether tree is NULL or not. This might be inconvenient to do without In fact it also says that in 1.2-latest. Anyway, glad we got it solved! -- Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
