[Wireshark-commits] master-2.0 636d667: Fix typo.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=636d66734d8eade99431a8fbe74a4dd26a28db7e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

636d667 by Guy Harris (g...@alum.mit.edu):

Fix typo.

Change-Id: I417de6124925dbfd9599ec7e90e287eb971457a3
Reviewed-on: https://code.wireshark.org/review/11687
Reviewed-by: Guy Harris 
(cherry picked from commit e2193fe6fdecb46f8bd1ecf40addd3838d0622e5)
Reviewed-on: https://code.wireshark.org/review/11688


Actions performed:

from  3a962d4   Call wtap_dump_open_check() in wtap_dump_init_dumper().
adds  636d667   Fix typo.


Summary of changes:
 wiretap/merge.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e2193fe: Fix typo.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2193fe6fdecb46f8bd1ecf40addd3838d0622e5
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e2193fe by Guy Harris (g...@alum.mit.edu):

Fix typo.

Change-Id: I417de6124925dbfd9599ec7e90e287eb971457a3
Reviewed-on: https://code.wireshark.org/review/11687
Reviewed-by: Guy Harris 


Actions performed:

from  6ae50eb   Call wtap_dump_open_check() in wtap_dump_init_dumper().
adds  e2193fe   Fix typo.


Summary of changes:
 wiretap/merge.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6a56224: [docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and subTLV 33

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a56224c18ec0ed19ad1a6e2b9172d330eeb14f0
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6a56224 by AdrianSimionov (daniel.simio...@gmail.com):

[docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and 
subTLV 33

Change-Id: I63410d90e65a46aaeb534cca56e8797ebe00bf6f
Reviewed-on: https://code.wireshark.org/review/11685
Reviewed-by: Alexis La Goutte 
Tested-by: Alexis La Goutte 
Reviewed-by: Pascal Quantin 


Actions performed:

from  e2193fe   Fix typo.
adds  6a56224   [docsis->packet-tlv.c] Update for modem capabilities TLV 5, 
subTLV 2 and subTLV 33


Summary of changes:
 plugins/docsis/packet-tlv.c |   14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 1094da4: [docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and subTLV 33

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1094da41ace07e64abfaa01c70e2b89f4a8c6b30
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1094da4 by AdrianSimionov (daniel.simio...@gmail.com):

[docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and 
subTLV 33

Change-Id: I63410d90e65a46aaeb534cca56e8797ebe00bf6f
Reviewed-on: https://code.wireshark.org/review/11685
Reviewed-by: Alexis La Goutte 
Tested-by: Alexis La Goutte 
Reviewed-by: Pascal Quantin 
(cherry picked from commit 6a56224c18ec0ed19ad1a6e2b9172d330eeb14f0)
Reviewed-on: https://code.wireshark.org/review/11698


Actions performed:

from  636d667   Fix typo.
adds  1094da4   [docsis->packet-tlv.c] Update for modem capabilities TLV 5, 
subTLV 2 and subTLV 33


Summary of changes:
 plugins/docsis/packet-tlv.c |   14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0d497e8: Initial Sysdig syscall (event) support.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d497e812508b3d71716618e39647a107c206b1d
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

0d497e8 by Gerald Combs (ger...@zing.org):

Initial Sysdig syscall (event) support.

Add a dissector for reading Sysdig event blocks. It only handles plain
events but it's usable for reading trace files on hand here.

Use a script to generate various parts of the dissector. As an experiment,
update parts in-place instead of using a template.

Ultimately there should probably be a top-level "Syscall" or "Event"
dissector alongside the "Frame" dissector, which could then call this.
You could then directly compare an executable's system calls alongside
its network traffic.

For now leverage the pcapng_block dissector and keep everything under
"Frame".

Next steps:
- Items listed at the top of packet-sysdig-event.c.

Change-Id: I17077e8d7f40d10a946d61189ebc077d81c4da37
Reviewed-on: https://code.wireshark.org/review/11103
Petri-Dish: Gerald Combs 
Reviewed-by: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 


Actions performed:

from  6a56224   [docsis->packet-tlv.c] Update for modem capabilities TLV 5, 
subTLV 2 and subTLV 33
adds  0d497e8   Initial Sysdig syscall (event) support.


Summary of changes:
 epan/CMakeLists.txt   |1 +
 epan/dissectors/Makefile.common   |1 +
 epan/dissectors/packet-sysdig-event.c | 2207 +
 tools/Makefile.am |1 +
 tools/generate-sysdig-event.py|  345 ++
 wiretap/pcapng.c  |  118 +-
 wiretap/pcapng_module.h   |2 +
 wiretap/wtap.h|   15 +
 8 files changed, 2685 insertions(+), 5 deletions(-)
 create mode 100644 epan/dissectors/packet-sysdig-event.c
 create mode 100755 tools/generate-sysdig-event.py
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ec303c1: Add CMakeLists.txt.user* to .gitignore.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec303c13b3f8df1feeae449830f57f20660229eb
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

ec303c1 by Gerald Combs (ger...@wireshark.org):

Add CMakeLists.txt.user* to .gitignore.

Qt Creator uses CMakeLists.txt.user to store CMake build settings.

Change-Id: I600289183dcfbc03cd9b555c4b646e6cfb799b0e
Reviewed-on: https://code.wireshark.org/review/11700
Reviewed-by: Gerald Combs 


Actions performed:

from  0b05086   Apple calls it just "OS X" these days.
adds  ec303c1   Add CMakeLists.txt.user* to .gitignore.


Summary of changes:
 .gitignore |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 9bfc915: New 2.0 symbols.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9bfc9156c650543fce4b9339b4876cb2bcd449ba
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9bfc915 by Guy Harris (g...@alum.mit.edu):

New 2.0 symbols.

Change-Id: Ie85ac43891c5587b0998e26da683ef275b631657
Reviewed-on: https://code.wireshark.org/review/11706
Reviewed-by: Guy Harris 
(cherry picked from commit 67a6342da503c5753e35837aea0ade239714e1f7)
Reviewed-on: https://code.wireshark.org/review/11707


Actions performed:

from  2b4881f   Apple calls it just "OS X" these days.
adds  9bfc915   New 2.0 symbols.


Summary of changes:
 debian/libwireshark0.symbols |2 ++
 debian/libwiretap0.symbols   |2 ++
 debian/libwsutil0.symbols|2 ++
 3 files changed, 6 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 e9d1d00: Initial Sysdig syscall (event) support.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e9d1d003eaea57f2a94fd24b920a7c462b7ff4e0
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

e9d1d00 by Gerald Combs (ger...@zing.org):

Initial Sysdig syscall (event) support.

Add a dissector for reading Sysdig event blocks. It only handles plain
events but it's usable for reading trace files on hand here.

Use a script to generate various parts of the dissector. As an experiment,
update parts in-place instead of using a template.

Ultimately there should probably be a top-level "Syscall" or "Event"
dissector alongside the "Frame" dissector, which could then call this.
You could then directly compare an executable's system calls alongside
its network traffic.

For now leverage the pcapng_block dissector and keep everything under
"Frame".

Next steps:
- Items listed at the top of packet-sysdig-event.c.

Change-Id: I17077e8d7f40d10a946d61189ebc077d81c4da37
Reviewed-on: https://code.wireshark.org/review/11103
Petri-Dish: Gerald Combs 
Reviewed-by: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 
(cherry picked from commit 0d497e812508b3d71716618e39647a107c206b1d)
Reviewed-on: https://code.wireshark.org/review/11702


Actions performed:

from  0b5f601   Apple just calls it "OS X" these days.
adds  e9d1d00   Initial Sysdig syscall (event) support.


Summary of changes:
 docbook/release-notes.asciidoc|1 +
 epan/CMakeLists.txt   |1 +
 epan/dissectors/Makefile.common   |1 +
 epan/dissectors/packet-sysdig-event.c | 2207 +
 tools/Makefile.am |1 +
 tools/generate-sysdig-event.py|  345 ++
 wiretap/pcapng.c  |  118 +-
 wiretap/pcapng_module.h   |2 +
 wiretap/wtap.h|   15 +
 9 files changed, 2686 insertions(+), 5 deletions(-)
 create mode 100644 epan/dissectors/packet-sysdig-event.c
 create mode 100755 tools/generate-sysdig-event.py
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 67a6342: New 2.0 symbols.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67a6342da503c5753e35837aea0ade239714e1f7
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

67a6342 by Guy Harris (g...@alum.mit.edu):

New 2.0 symbols.

Change-Id: Ie85ac43891c5587b0998e26da683ef275b631657
Reviewed-on: https://code.wireshark.org/review/11706
Reviewed-by: Guy Harris 


Actions performed:

from  ec303c1   Add CMakeLists.txt.user* to .gitignore.
adds  67a6342   New 2.0 symbols.


Summary of changes:
 debian/libwireshark0.symbols |2 ++
 debian/libwiretap0.symbols   |2 ++
 debian/libwsutil0.symbols|2 ++
 3 files changed, 6 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 6b315b4: Update the release notes.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b315b461249246fda7a5589ad40377db106e9aa
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6b315b4 by Gerald Combs (ger...@wireshark.org):

Update the release notes.

Change-Id: Id1c4f50bb7a6f8b9a1fb0918b96f91371c5d974d
Reviewed-on: https://code.wireshark.org/review/11699
Reviewed-by: Guy Harris 


Actions performed:

from  1094da4   [docsis->packet-tlv.c] Update for modem capabilities TLV 5, 
subTLV 2 and subTLV 33
adds  6b315b4   Update the release notes.


Summary of changes:
 docbook/release-notes.asciidoc |   34 +++---
 1 file changed, 31 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 0b5f601: Apple just calls it "OS X" these days.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b5f6018afed4c58b86b0337934439a522025220
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0b5f601 by Guy Harris (g...@alum.mit.edu):

Apple just calls it "OS X" these days.

Change-Id: I702e5e4853c52f9a476f04145dcdf1720fd289fe
Reviewed-on: https://code.wireshark.org/review/11701
Reviewed-by: Guy Harris 


Actions performed:

from  6b315b4   Update the release notes.
adds  0b5f601   Apple just calls it "OS X" these days.


Summary of changes:
 docbook/release-notes.asciidoc |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 2b4881f: Apple calls it just "OS X" these days.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2b4881fe77102b7b62ca249d0af9899a57d73741
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2b4881f by Guy Harris (g...@alum.mit.edu):

Apple calls it just "OS X" these days.

Change-Id: I98905988ceb394d27307d1cbe883d8fe95ac23e4
Reviewed-on: https://code.wireshark.org/review/11703
Reviewed-by: Guy Harris 
(cherry picked from commit 0b05086754ad977d639ed7715a34b57b5e0ee28e)
Reviewed-on: https://code.wireshark.org/review/11704


Actions performed:

from  e9d1d00   Initial Sysdig syscall (event) support.
adds  2b4881f   Apple calls it just "OS X" these days.


Summary of changes:
 CMakeOptions.txt   |4 ++--
 README |2 +-
 README.cmake   |2 +-
 README.macos   |   10 +-
 configure.ac   |4 ++--
 doc/README.plugins |6 +++---
 doc/README.qt  |2 +-
 docbook/wsdg_src/WSDG_chapter_env_intro.asciidoc   |   15 +++
 docbook/wsdg_src/WSDG_chapter_sources.asciidoc |6 +++---
 .../wsdg_src/WSDG_chapter_userinterface.asciidoc   |2 +-
 .../wsug_src/WSUG_chapter_build_install.asciidoc   |6 +++---
 docbook/wsug_src/WSUG_chapter_customize.asciidoc   |4 ++--
 .../wsug_src/WSUG_chapter_introduction.asciidoc|6 +++---
 epan/prefs.c   |4 ++--
 help/faq.py|4 ++--
 packaging/macosx/ScriptExec/main.c |4 ++--
 .../macosx/Wireshark_package.pmdoc/index.xml.in|2 +-
 packaging/macosx/native-gtk/build-gtk.sh   |2 +-
 packaging/macosx/osx-app.sh|4 ++--
 ui/gtk/prefs_gui.c |4 ++--
 20 files changed, 46 insertions(+), 47 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0b05086: Apple calls it just "OS X" these days.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b05086754ad977d639ed7715a34b57b5e0ee28e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

0b05086 by Guy Harris (g...@alum.mit.edu):

Apple calls it just "OS X" these days.

Change-Id: I98905988ceb394d27307d1cbe883d8fe95ac23e4
Reviewed-on: https://code.wireshark.org/review/11703
Reviewed-by: Guy Harris 


Actions performed:

from  0d497e8   Initial Sysdig syscall (event) support.
adds  0b05086   Apple calls it just "OS X" these days.


Summary of changes:
 CMakeOptions.txt   |4 ++--
 README |2 +-
 README.cmake   |2 +-
 README.macos   |   10 +-
 configure.ac   |4 ++--
 doc/README.plugins |6 +++---
 doc/README.qt  |2 +-
 docbook/wsdg_src/WSDG_chapter_env_intro.asciidoc   |   15 +++
 docbook/wsdg_src/WSDG_chapter_sources.asciidoc |6 +++---
 .../wsdg_src/WSDG_chapter_userinterface.asciidoc   |2 +-
 .../wsug_src/WSUG_chapter_build_install.asciidoc   |6 +++---
 docbook/wsug_src/WSUG_chapter_customize.asciidoc   |4 ++--
 .../wsug_src/WSUG_chapter_introduction.asciidoc|6 +++---
 epan/prefs.c   |4 ++--
 help/faq.py|4 ++--
 packaging/macosx/ScriptExec/main.c |4 ++--
 .../macosx/Wireshark_package.pmdoc/index.xml.in|2 +-
 packaging/macosx/native-gtk/build-gtk.sh   |2 +-
 packaging/macosx/osx-app.sh|4 ++--
 ui/gtk/prefs_gui.c |4 ++--
 20 files changed, 46 insertions(+), 47 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 5679982: UDP: Don't throw malformed errors for empty UDP payload

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5679982d95f5ff755d9b1b791df5412961ca439b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5679982 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

UDP: Don't throw malformed errors for empty UDP payload

Change-Id: I7f5724e263ab81d42421d0cfcb1fc4b63a55d79e
Reviewed-on: https://code.wireshark.org/review/11590
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 541f352b5efa8b51769d49c7e62c2109b9c3651a)
Reviewed-on: https://code.wireshark.org/review/11712


Actions performed:

from  9bfc915   New 2.0 symbols.
adds  5679982   UDP: Don't throw malformed errors for empty UDP payload


Summary of changes:
 epan/dissectors/packet-udp.c |5 +
 1 file changed, 5 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 541f352: UDP: Don't throw malformed errors for empty UDP payload

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=541f352b5efa8b51769d49c7e62c2109b9c3651a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

541f352 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

UDP: Don't throw malformed errors for empty UDP payload

Change-Id: I7f5724e263ab81d42421d0cfcb1fc4b63a55d79e
Reviewed-on: https://code.wireshark.org/review/11590
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  c2afc9e   Change prototype of callbacks passed to wmem_tree_foreach 
so that they accept the node key as a first parameter.
adds  541f352   UDP: Don't throw malformed errors for empty UDP payload


Summary of changes:
 epan/dissectors/packet-udp.c |5 +
 1 file changed, 5 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b9b74fc: ISI: fix code will never be executed [-Wunreachable-code]

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9b74fcf57375209a8716434c5998168e44b57ca
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

b9b74fc by Alexis La Goutte (alexis.lagou...@gmail.com):

ISI: fix code will never be executed [-Wunreachable-code]

Change-Id: I24185128e664a0f7cc2b59d5d653582cddd04df1
Reviewed-on: https://code.wireshark.org/review/11686
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  905314f   Additional 2.1 symbols.
adds  b9b74fc   ISI: fix code will never be executed [-Wunreachable-code]


Summary of changes:
 epan/dissectors/packet-isi.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c2afc9e: Change prototype of callbacks passed to wmem_tree_foreach so that they accept the node key as a first parameter.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c2afc9edec79b247d02f42ba3c7cad2bc24b9f91
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

c2afc9e by Matthieu Coudron (matta...@gmail.com):

Change prototype of callbacks passed to wmem_tree_foreach so that they
accept the node key as a first parameter.

wmem_tree accepts all sort of keys (strings, integers, soon ranges),
thus it is of interest for various purposes (testing, greedy search) to
know the key of the node.

Change-Id: Ie748b917bef91f0b1ba8cce15bd1b471922641dc
Reviewed-on: https://code.wireshark.org/review/11683
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Evan Huus 
Reviewed-by: Michael Mann 


Actions performed:

from  b9b74fc   ISI: fix code will never be executed [-Wunreachable-code]
adds  c2afc9e   Change prototype of callbacks passed to wmem_tree_foreach 
so that they accept the node key as a first parameter.


Summary of changes:
 epan/dissectors/packet-aeron.c |2 +-
 epan/dissectors/packet-lbtrm.c |2 +-
 epan/dissectors/packet-lbtru.c |2 +-
 epan/prefs.c   |   10 +-
 epan/wmem/wmem_test.c  |2 +-
 epan/wmem/wmem_tree.c  |2 +-
 epan/wmem/wmem_tree.h  |2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 886de6b: ISI: Add Modelines info

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=886de6b91fcc18f6a1b3e275bd0566b27600252f
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

886de6b by Alexis La Goutte (alexis.lagou...@gmail.com):

ISI: Add Modelines info

Change-Id: I758c39698847d65447e0a7490104a9369c85f6cd
Reviewed-on: https://code.wireshark.org/review/11684
Reviewed-by: Michael Mann 


Actions performed:

from  541f352   UDP: Don't throw malformed errors for empty UDP payload
adds  886de6b   ISI: Add Modelines info


Summary of changes:
 epan/dissectors/packet-isi.c |   13 +
 1 file changed, 13 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.7%20x64/builds/234

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 9bfc9156c650543fce4b9339b4876cb2bcd449ba
Blamelist: Guy Harris 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/14611

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 67a6342da503c5753e35837aea0ade239714e1f7
Blamelist: Gerald Combs ,Guy Harris 
,Pascal Quantin 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 905314f: Additional 2.1 symbols.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=905314f25964ada5b7fed1ea1ffebf4913686ec9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

905314f by Guy Harris (g...@alum.mit.edu):

Additional 2.1 symbols.

Change-Id: Icf5d218e3e0a3336c80e04ed51a1ef5262cc9f28
Reviewed-on: https://code.wireshark.org/review/11711
Reviewed-by: Guy Harris 


Actions performed:

from  67a6342   New 2.0 symbols.
adds  905314f   Additional 2.1 symbols.


Summary of changes:
 debian/libwireshark0.symbols |8 
 1 file changed, 8 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d059714: ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d05971449b9826897c5d4fb06158f98f248f68d8
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d059714 by Alexis La Goutte (alexis.lagou...@gmail.com):

ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT

Change-Id: Ib9719ac893288b9f26acabb81158ed42b2351fb5
Reviewed-on: https://code.wireshark.org/review/11572
Reviewed-by: Michael Mann 
Petri-Dish: Anders Broman 
Reviewed-by: Anders Broman 


Actions performed:

from  20a7e7f   file.c: do not try to close a file descriptor that was 
previously already closed
adds  d059714   ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for 
ZBEE_ZCL_40_BIT_UINT


Summary of changes:
 epan/dissectors/packet-zbee-zcl.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3e5b253: RPC: call REPORT_DISSECTOR_BUG() rather than abort().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e5b2537f7fdff838f611f779fff526cdda1a2a3
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3e5b253 by Jeff Morriss (jeff.morriss...@gmail.com):

RPC: call REPORT_DISSECTOR_BUG() rather than abort().

Checking WIRESHARK_ABORT_ON_DISSECTOR_BUG here looks somewhat redundant but 
it's not:
it's needed to prevent REPORT_DISSECTOR_BUG() from throwing an exception 
when
we're not dissecting (when nobody's going to catch the exception).

Change-Id: I4dfc484bdf13bca236bfff1388d4399e26880ad7
Reviewed-on: https://code.wireshark.org/review/11272
Reviewed-by: Michael Mann 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  d059714   ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for 
ZBEE_ZCL_40_BIT_UINT
adds  3e5b253   RPC: call REPORT_DISSECTOR_BUG() rather than abort().


Summary of changes:
 epan/dissectors/packet-rpc.c |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 ce173bb: file.c: do not try to close a file descriptor that was previously already closed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce173bb6a8206f5a57a798482f91c52026cf2e44
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ce173bb by Pascal Quantin (pascal.quan...@gmail.com):

file.c: do not try to close a file descriptor that was previously already 
closed

Bug: 11684
Change-Id: Iaaa5958ea6192ef52b669c687082469b8c7c0219
Reviewed-on: https://code.wireshark.org/review/11656
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jim Young 
Reviewed-by: Anders Broman 
(cherry picked from commit 20a7e7fe42dfa9e5de91ebfffc2cfd128099fa6a)
Reviewed-on: https://code.wireshark.org/review/11668


Actions performed:

from  8fdef73   Treat "-" as "standard input" in the CLI, not in libwiretap.
adds  ce173bb   file.c: do not try to close a file descriptor that was 
previously already closed


Summary of changes:
 file.c |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.7%20x64/builds/225

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 6b5837c222fd43fb6c43b6aa2510f4ca3ee78828
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 827b7dd: Skip only the actual file descriptor close when writing to stdout.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=827b7dd75680b26e2bfddb0dac2f42f1dad69e7a
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

827b7dd by Guy Harris (g...@alum.mit.edu):

Skip only the actual file descriptor close when writing to stdout.

Have a "this is stdout" flag for a wtap_dumper, and have "open the
standard output for dumping" routines that set that flag.  When closing
a wtap_dumper, do most of the work regardless of whether we're writing
to the standard output or not (so that everything gets written out) and
only skip the closing of the underlying file descriptor.

Change-Id: I9f7e4d142b3bd598055d806b7ded1cb4c378de8e
Reviewed-on: https://code.wireshark.org/review/11673
Reviewed-by: Guy Harris 


Actions performed:

from  630ccbe   Make the dfilter time tests work regardless of what time 
zone the tests are being run in.
adds  827b7dd   Skip only the actual file descriptor close when writing to 
stdout.


Summary of changes:
 editcap.c   |8 ++--
 randpkt.c   |2 +-
 reordercap.c|4 +-
 tshark.c|4 +-
 wiretap/file_access.c   |  110 +++
 wiretap/file_wrappers.c |   16 +--
 wiretap/file_wrappers.h |2 +-
 wiretap/wtap-int.h  |1 +
 wiretap/wtap.h  |   26 +++
 9 files changed, 131 insertions(+), 42 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 6ce6985: Use WMEM_COPY_ADDRESS(), not copy_address_wmem().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ce6985e0a55f063dbd8791045524e11d48e97af
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6ce6985 by Guy Harris (g...@alum.mit.edu):

Use WMEM_COPY_ADDRESS(), not copy_address_wmem().

copy_address_wmem() exists in the trunk, but not in the 2.0 branch; in
that branch, you use WMEM_COPY_ADDRESS().

Change-Id: I45d63816aa16f213d5e98da477433ef76b1a11bd
Reviewed-on: https://code.wireshark.org/review/11675
Reviewed-by: Guy Harris 


Actions performed:

from  019557e   Skip only the actual file descriptor close when writing to 
stdout.
adds  6ce6985   Use WMEM_COPY_ADDRESS(), not copy_address_wmem().


Summary of changes:
 epan/dissectors/packet-giop.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 019557e: Skip only the actual file descriptor close when writing to stdout.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=019557eb88d13007fe44995137b586bc6fba0c8b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

019557e by Guy Harris (g...@alum.mit.edu):

Skip only the actual file descriptor close when writing to stdout.

Have a "this is stdout" flag for a wtap_dumper, and have "open the
standard output for dumping" routines that set that flag.  When closing
a wtap_dumper, do most of the work regardless of whether we're writing
to the standard output or not (so that everything gets written out) and
only skip the closing of the underlying file descriptor.

Change-Id: I80176dad0d9b5dff1b64c7d4703e0ab36501f547
Reviewed-on: https://code.wireshark.org/review/11674
Reviewed-by: Guy Harris 


Actions performed:

from  6b5837c   GIOP dissector: Replies are not correctly associated with 
requests
adds  019557e   Skip only the actual file descriptor close when writing to 
stdout.


Summary of changes:
 editcap.c   |8 ++--
 randpkt.c   |2 +-
 reordercap.c|4 +-
 tshark.c|4 +-
 wiretap/file_access.c   |  110 +++
 wiretap/file_wrappers.c |   16 +--
 wiretap/file_wrappers.h |2 +-
 wiretap/wtap-int.h  |1 +
 wiretap/wtap.h  |   26 +++
 9 files changed, 131 insertions(+), 42 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 68d5d1d: RPC: call REPORT_DISSECTOR_BUG() rather than abort().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68d5d1d963357a75bbcb9e11e67d8295577c033c
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

68d5d1d by Jeff Morriss (jeff.morriss...@gmail.com):

RPC: call REPORT_DISSECTOR_BUG() rather than abort().

Checking WIRESHARK_ABORT_ON_DISSECTOR_BUG here looks somewhat redundant but 
it's not:
it's needed to prevent REPORT_DISSECTOR_BUG() from throwing an exception 
when
we're not dissecting (when nobody's going to catch the exception).

Change-Id: I4dfc484bdf13bca236bfff1388d4399e26880ad7
Reviewed-on: https://code.wireshark.org/review/11272
Reviewed-by: Michael Mann 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 3e5b2537f7fdff838f611f779fff526cdda1a2a3)
Reviewed-on: https://code.wireshark.org/review/11670


Actions performed:

from  ce173bb   file.c: do not try to close a file descriptor that was 
previously already closed
adds  68d5d1d   RPC: call REPORT_DISSECTOR_BUG() rather than abort().


Summary of changes:
 epan/dissectors/packet-rpc.c |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 dd736b9: ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd736b9c26d6a737400774ab3d0a37882583be54
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

dd736b9 by Alexis La Goutte (alexis.lagou...@gmail.com):

ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT

Change-Id: Ib9719ac893288b9f26acabb81158ed42b2351fb5
Reviewed-on: https://code.wireshark.org/review/11572
Reviewed-by: Michael Mann 
Petri-Dish: Anders Broman 
Reviewed-by: Anders Broman 
(cherry picked from commit d05971449b9826897c5d4fb06158f98f248f68d8)
Reviewed-on: https://code.wireshark.org/review/11671


Actions performed:

from  68d5d1d   RPC: call REPORT_DISSECTOR_BUG() rather than abort().
adds  dd736b9   ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for 
ZBEE_ZCL_40_BIT_UINT


Summary of changes:
 epan/dissectors/packet-zbee-zcl.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 6b5837c: GIOP dissector: Replies are not correctly associated with requests

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b5837c222fd43fb6c43b6aa2510f4ca3ee78828
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6b5837c by AndyL (andy.l...@s-a-m.com):

GIOP dissector: Replies are not correctly associated with requests

Added IP address and port number to the comp_req_list_entry so
get_mfn_from_fn_and_reqid can check for matching IP and port number
when searching for the reply to a request.

Change-Id: Iad00bca5c1104cf8c335001f84264fe55d2e45fc
Reviewed-on: https://code.wireshark.org/review/11599
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 0a993232bfbe182015f4ebb02d7af790f4be45bb)
Reviewed-on: https://code.wireshark.org/review/11672


Actions performed:

from  dd736b9   ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for 
ZBEE_ZCL_40_BIT_UINT
adds  6b5837c   GIOP dissector: Replies are not correctly associated with 
requests


Summary of changes:
 epan/dissectors/packet-giop.c |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0a99323: GIOP dissector: Replies are not correctly associated with requests

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a993232bfbe182015f4ebb02d7af790f4be45bb
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0a99323 by AndyL (andy.l...@s-a-m.com):

GIOP dissector: Replies are not correctly associated with requests

Added IP address and port number to the comp_req_list_entry so
get_mfn_from_fn_and_reqid can check for matching IP and port number
when searching for the reply to a request.

Change-Id: Iad00bca5c1104cf8c335001f84264fe55d2e45fc
Reviewed-on: https://code.wireshark.org/review/11599
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  3e5b253   RPC: call REPORT_DISSECTOR_BUG() rather than abort().
adds  0a99323   GIOP dissector: Replies are not correctly associated with 
requests


Summary of changes:
 epan/dissectors/packet-giop.c |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/9293

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 630ccbe2d74338bac6d8abe69705cf0401baa8c1
Blamelist: Anders Broman 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%207%20x64/builds/14488

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 827b7dd75680b26e2bfddb0dac2f42f1dad69e7a
Blamelist: Anders Broman ,Guy Harris 

BUILD FAILED: failed compile_4 test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b3fa7e5: Add a comment for is_stdout.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3fa7e5d3d70fdb2425f522b07786adbfd24bfb1
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

b3fa7e5 by Guy Harris (g...@alum.mit.edu):

Add a comment for is_stdout.

Change-Id: I88abb5a37a00ebc1a2a742ff36c8d6be75420dbe
Reviewed-on: https://code.wireshark.org/review/11677
Reviewed-by: Guy Harris 


Actions performed:

from  827b7dd   Skip only the actual file descriptor close when writing to 
stdout.
adds  b3fa7e5   Add a comment for is_stdout.


Summary of changes:
 wiretap/wtap-int.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6ae50eb: Call wtap_dump_open_check() in wtap_dump_init_dumper().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ae50ebf28cd40d5c7e1ef5493c22e896564c4f2
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6ae50eb by Guy Harris (g...@alum.mit.edu):

Call wtap_dump_open_check() in wtap_dump_init_dumper().

The callers of wtap_dump_init_dumper() always call
wtap_dump_open_check() first, with the same arguments in all cases; pull
the latter call into wtap_dump_init_dumper() itself.

Change-Id: I2b44dc3a018745e175b5c74ff1a346749fec2b71
Reviewed-on: https://code.wireshark.org/review/11681
Reviewed-by: Guy Harris 


Actions performed:

from  b3fa7e5   Add a comment for is_stdout.
adds  6ae50eb   Call wtap_dump_open_check() in wtap_dump_init_dumper().


Summary of changes:
 wiretap/file_access.c |   20 +---
 1 file changed, 5 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 3a962d4: Call wtap_dump_open_check() in wtap_dump_init_dumper().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a962d4d3e61fb9eeec0aa58135dd51ca4a1b1da
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3a962d4 by Guy Harris (g...@alum.mit.edu):

Call wtap_dump_open_check() in wtap_dump_init_dumper().

The callers of wtap_dump_init_dumper() always call
wtap_dump_open_check() first, with the same arguments in all cases; pull
the latter call into wtap_dump_init_dumper() itself.

Change-Id: I2b44dc3a018745e175b5c74ff1a346749fec2b71
Reviewed-on: https://code.wireshark.org/review/11681
Reviewed-by: Guy Harris 
(cherry picked from commit 6ae50ebf28cd40d5c7e1ef5493c22e896564c4f2)
Reviewed-on: https://code.wireshark.org/review/11682


Actions performed:

from  9d48e02   Add a comment for is_stdout.
adds  3a962d4   Call wtap_dump_open_check() in wtap_dump_init_dumper().


Summary of changes:
 wiretap/file_access.c |   20 +---
 1 file changed, 5 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 9d48e02: Add a comment for is_stdout.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d48e02f8a2d74a71b8563ca9f421199907a0f1b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9d48e02 by Guy Harris (g...@alum.mit.edu):

Add a comment for is_stdout.

Change-Id: I88abb5a37a00ebc1a2a742ff36c8d6be75420dbe
Reviewed-on: https://code.wireshark.org/review/11677
Reviewed-by: Guy Harris 
(cherry picked from commit b3fa7e5d3d70fdb2425f522b07786adbfd24bfb1)
Reviewed-on: https://code.wireshark.org/review/11678


Actions performed:

from  6ce6985   Use WMEM_COPY_ADDRESS(), not copy_address_wmem().
adds  9d48e02   Add a comment for is_stdout.


Summary of changes:
 wiretap/wtap-int.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x86 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.6%20x86/builds/212

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.6-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 6b5837c222fd43fb6c43b6aa2510f4ca3ee78828
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5055291: debian: Ship wireshark.1 in the package we ship /usr/bin/wireshark

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=505529190a5c7a8529713a921e59220964b5809b
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

5055291 by Balint Reczey (bal...@balintreczey.hu):

debian: Ship wireshark.1 in the package we ship /usr/bin/wireshark

Change-Id: I7935f412092d6dbb0f545803d82d9b42dfe5a638
Reviewed-on: https://code.wireshark.org/review/11694
Reviewed-by: Balint Reczey 


Actions performed:

from  2d1bf73   debian: Finish postinst of wireshark-common even when 
wireshark group is a user group
adds  5055291   debian: Ship wireshark.1 in the package we ship 
/usr/bin/wireshark


Summary of changes:
 .../{wireshark.manpages => wireshark-qt.manpages}  |0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename debian/{wireshark.manpages => wireshark-qt.manpages} (100%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b732f44: GTK: Add separate working desktop file for GTK+ Wireshark GUI

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b732f44d1e5e1c0ba5b863ddda69b04edab367a6
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

b732f44 by Balint Reczey (bal...@balintreczey.hu):

GTK: Add separate working desktop file for GTK+ Wireshark GUI

Change-Id: I52a749b7e2b9a4a5cb2968409e140b9d5f2002f6
Reviewed-on: https://code.wireshark.org/review/11696
Reviewed-by: Balint Reczey 


Actions performed:

from  7d86cc9   debian: Ship wireshark.desktop file in wireshark-qt
adds  b732f44   GTK: Add separate working desktop file for GTK+ Wireshark 
GUI


Summary of changes:
 Makefile.am|6 --
 debian/wireshark-gtk.install   |2 +-
 packaging/rpm/SPECS/wireshark.spec.in  |3 +++
 wireshark.desktop => wireshark-gtk.desktop |   10 +-
 4 files changed, 13 insertions(+), 8 deletions(-)
 copy wireshark.desktop => wireshark-gtk.desktop (97%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7d86cc9: debian: Ship wireshark.desktop file in wireshark-qt

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d86cc9194757afae54b216620d61a6eabb04e74
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

7d86cc9 by Balint Reczey (bal...@balintreczey.hu):

debian: Ship wireshark.desktop file in wireshark-qt

Change-Id: Idbf77e6a613c79e267f41d3e9d3c05617e9c6d99
Reviewed-on: https://code.wireshark.org/review/11695
Reviewed-by: Balint Reczey 


Actions performed:

from  5055291   debian: Ship wireshark.1 in the package we ship 
/usr/bin/wireshark
adds  7d86cc9   debian: Ship wireshark.desktop file in wireshark-qt


Summary of changes:
 debian/wireshark-qt.install |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f2ac2e4: debian: Move icon and mime info file to wireshark-common

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2ac2e477a19883bf1a4b76f25fa273c8b6e20af
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

f2ac2e4 by Balint Reczey (bal...@balintreczey.hu):

debian: Move icon and mime info file to wireshark-common

Change-Id: I4d8660b36810baa95f8b300af9790778dcba83a8
Reviewed-on: https://code.wireshark.org/review/11697
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Balint Reczey 


Actions performed:

from  b732f44   GTK: Add separate working desktop file for GTK+ Wireshark 
GUI
adds  f2ac2e4   debian: Move icon and mime info file to wireshark-common


Summary of changes:
 debian/wireshark-common.install |4 +++-
 debian/wireshark-gtk.install|2 --
 debian/wireshark-qt.install |2 --
 3 files changed, 3 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 de1faf3: debian: Drop menu support

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de1faf3af946ae4ad0788e4f023d095ec1c64b30
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

de1faf3 by Balint Reczey (bal...@balintreczey.hu):

debian: Drop menu support

Debian is migrating away from the Debian Menu system to adopt
Freedesktop Desktop Entry Specification instead. (.desktop files)
Packages providing .desktop files should not provide menu files.
https://lists.debian.org/debian-devel-announce/2015/09/msg0.html

Change-Id: I862deee870e9697c590a8323ba8ae2da892b7bb1
Reviewed-on: https://code.wireshark.org/review/11691
Reviewed-by: Balint Reczey 
(cherry picked from commit 18a54fcaa4071afb33c393b1270c1488e7a95131)
Reviewed-on: https://code.wireshark.org/review/11715


Actions performed:

from  5679982   UDP: Don't throw malformed errors for empty UDP payload
adds  de1faf3   debian: Drop menu support


Summary of changes:
 debian/rules |2 --
 debian/wireshark-gtk.install |1 -
 debian/wireshark.menu|5 -
 3 files changed, 8 deletions(-)
 delete mode 100644 debian/wireshark.menu
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 d42095a: debian: Ship wireshark.desktop file in wireshark-qt

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d42095a7ba9544d86818625e80957f5973aa0943
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d42095a by Balint Reczey (bal...@balintreczey.hu):

debian: Ship wireshark.desktop file in wireshark-qt

Change-Id: Idbf77e6a613c79e267f41d3e9d3c05617e9c6d99
Reviewed-on: https://code.wireshark.org/review/11695
Reviewed-by: Balint Reczey 
(cherry picked from commit 7d86cc9194757afae54b216620d61a6eabb04e74)
Reviewed-on: https://code.wireshark.org/review/11718


Actions performed:

from  51b4c32   debian: Finish postinst of wireshark-common even when 
wireshark group is a user group
adds  d42095a   debian: Ship wireshark.desktop file in wireshark-qt


Summary of changes:
 debian/wireshark-qt.install |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 51b4c32: debian: Finish postinst of wireshark-common even when wireshark group is a user group

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51b4c32ba1d8086ce6ebc1a3540e640e2b325ff8
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

51b4c32 by Balint Reczey (bal...@balintreczey.hu):

debian: Finish postinst of wireshark-common even when wireshark group is a 
user group

Failing postinst has been reported several times under LP#1447893

Change-Id: I196f246b34aa3be9d53f02b4e0092c802effc42a
Reviewed-on: https://code.wireshark.org/review/11693
Reviewed-by: Balint Reczey 
(cherry picked from commit 2d1bf738d71a4f4f6ac6832bba3889b2c39a471a)
Reviewed-on: https://code.wireshark.org/review/11717


Actions performed:

from  1cdaea2   debian: Add note to README.Debian to log in again to be 
able to capture packets
adds  51b4c32   debian: Finish postinst of wireshark-common even when 
wireshark group is a user group


Summary of changes:
 debian/wireshark-common.postinst |   13 -
 1 file changed, 8 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 1cdaea2: debian: Add note to README.Debian to log in again to be able to capture packets

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1cdaea26696c5cbf6c52228a690e40b2ade58475
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1cdaea2 by Balint Reczey (bal...@balintreczey.hu):

debian: Add note to README.Debian to log in again to be able to capture 
packets

Change-Id: Ifae1223d34f7ae071484fe47d1c88de166ed84ca
Reviewed-on: https://code.wireshark.org/review/11692
Reviewed-by: Balint Reczey 
(cherry picked from commit 927a55f914b319abb39923ce7efb1f1377927719)
Reviewed-on: https://code.wireshark.org/review/11716


Actions performed:

from  de1faf3   debian: Drop menu support
adds  1cdaea2   debian: Add note to README.Debian to log in again to be 
able to capture packets


Summary of changes:
 debian/README.Debian |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 cb81c7a: GTK: Add separate working desktop file for GTK+ Wireshark GUI

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb81c7aa9e038468bc93ddaee3602c77cabccf33
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

cb81c7a by Balint Reczey (bal...@balintreczey.hu):

GTK: Add separate working desktop file for GTK+ Wireshark GUI

Change-Id: I52a749b7e2b9a4a5cb2968409e140b9d5f2002f6
Reviewed-on: https://code.wireshark.org/review/11696
Reviewed-by: Balint Reczey 
(cherry picked from commit b732f44d1e5e1c0ba5b863ddda69b04edab367a6)
Reviewed-on: https://code.wireshark.org/review/11719


Actions performed:

from  d42095a   debian: Ship wireshark.desktop file in wireshark-qt
adds  cb81c7a   GTK: Add separate working desktop file for GTK+ Wireshark 
GUI


Summary of changes:
 Makefile.am|6 --
 debian/wireshark-gtk.install   |2 +-
 packaging/rpm/SPECS/wireshark.spec.in  |3 +++
 wireshark.desktop => wireshark-gtk.desktop |   10 +-
 4 files changed, 13 insertions(+), 8 deletions(-)
 copy wireshark.desktop => wireshark-gtk.desktop (97%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8930b0d: debian: Make make dist know about moving wireshark.1 to wireshark-qt and removal of wireshark.menu

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8930b0d5e0e5827f7cd72b9cb765e09bad0c3765
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

8930b0d by Balint Reczey (bal...@balintreczey.hu):

debian: Make make dist know about moving wireshark.1 to wireshark-qt and 
removal of wireshark.menu

Change-Id: I81b95e43beae7ca85bff9b2d5b4a6f498252f2b3
Reviewed-on: https://code.wireshark.org/review/11720
Reviewed-by: Balint Reczey 


Actions performed:

from  f2ac2e4   debian: Move icon and mime info file to wireshark-common
adds  8930b0d   debian: Make make dist know about moving wireshark.1 to 
wireshark-qt and removal of wireshark.menu


Summary of changes:
 Makefile.am |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 4afc1be: Qt: Freeze+thaw the main window during nested operations.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4afc1be888e86afd61b2f0229240016a79d31c70
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4afc1be by Gerald Combs (ger...@wireshark.org):

Qt: Freeze+thaw the main window during nested operations.

As noted in main_window.cpp:

// Our event loop becomes nested whenever we call update_progress_dlg, which
// includes several places in file.c. The GTK+ UI stays out of trouble by
// showing a modal progress dialog. We attempt to do the equivalent below by
// disabling parts of the main window. At a minumum the ProgressFrame in the
// main status bar must remain accessible.

Move the freeze+thaw code from captureFileRetapStarted and
captureFileRetapFinished to its own set of member functions. Call them
when we {,un}mark and {,un}ignore packets and note that we should
probably call them elsewhere. Disable mark and ignore actions when we
freeze and restore their states when we thaw.

Bug: 11681
Change-Id: I6f015f7f5f6c98cd48ace2c87f43f48efe51a88b
Reviewed-on: https://code.wireshark.org/review/11690
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 
(cherry picked from commit 757fe65474a37d94e7eba1b6b4bb6df23b69ba56)
Reviewed-on: https://code.wireshark.org/review/11722


Actions performed:

from  cb81c7a   GTK: Add separate working desktop file for GTK+ Wireshark 
GUI
adds  4afc1be   Qt: Freeze+thaw the main window during nested operations.


Summary of changes:
 ui/qt/main_window.cpp   |   55 +++
 ui/qt/main_window.h |6 +
 ui/qt/main_window_slots.cpp |   28 +++---
 3 files changed, 75 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 757fe65: Qt: Freeze+thaw the main window during nested operations.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=757fe65474a37d94e7eba1b6b4bb6df23b69ba56
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

757fe65 by Gerald Combs (ger...@wireshark.org):

Qt: Freeze+thaw the main window during nested operations.

As noted in main_window.cpp:

// Our event loop becomes nested whenever we call update_progress_dlg, which
// includes several places in file.c. The GTK+ UI stays out of trouble by
// showing a modal progress dialog. We attempt to do the equivalent below by
// disabling parts of the main window. At a minumum the ProgressFrame in the
// main status bar must remain accessible.

Move the freeze+thaw code from captureFileRetapStarted and
captureFileRetapFinished to its own set of member functions. Call them
when we {,un}mark and {,un}ignore packets and note that we should
probably call them elsewhere. Disable mark and ignore actions when we
freeze and restore their states when we thaw.

Bug: 11681
Change-Id: I6f015f7f5f6c98cd48ace2c87f43f48efe51a88b
Reviewed-on: https://code.wireshark.org/review/11690
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Gerald Combs 


Actions performed:

from  8930b0d   debian: Make make dist know about moving wireshark.1 to 
wireshark-qt and removal of wireshark.menu
adds  757fe65   Qt: Freeze+thaw the main window during nested operations.


Summary of changes:
 ui/qt/main_window.cpp   |   55 +++
 ui/qt/main_window.h |6 +
 ui/qt/main_window_slots.cpp |   28 +++---
 3 files changed, 75 insertions(+), 14 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 18a54fc: debian: Drop menu support

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=18a54fcaa4071afb33c393b1270c1488e7a95131
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

18a54fc by Balint Reczey (bal...@balintreczey.hu):

debian: Drop menu support

Debian is migrating away from the Debian Menu system to adopt
Freedesktop Desktop Entry Specification instead. (.desktop files)
Packages providing .desktop files should not provide menu files.
https://lists.debian.org/debian-devel-announce/2015/09/msg0.html

Change-Id: I862deee870e9697c590a8323ba8ae2da892b7bb1
Reviewed-on: https://code.wireshark.org/review/11691
Reviewed-by: Balint Reczey 


Actions performed:

from  886de6b   ISI: Add Modelines info
adds  18a54fc   debian: Drop menu support


Summary of changes:
 debian/rules |2 --
 debian/wireshark-gtk.install |1 -
 debian/wireshark.menu|5 -
 3 files changed, 8 deletions(-)
 delete mode 100644 debian/wireshark.menu
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2d1bf73: debian: Finish postinst of wireshark-common even when wireshark group is a user group

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d1bf738d71a4f4f6ac6832bba3889b2c39a471a
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

2d1bf73 by Balint Reczey (bal...@balintreczey.hu):

debian: Finish postinst of wireshark-common even when wireshark group is a 
user group

Failing postinst has been reported several times under LP#1447893

Change-Id: I196f246b34aa3be9d53f02b4e0092c802effc42a
Reviewed-on: https://code.wireshark.org/review/11693
Reviewed-by: Balint Reczey 


Actions performed:

from  927a55f   debian: Add note to README.Debian to log in again to be 
able to capture packets
adds  2d1bf73   debian: Finish postinst of wireshark-common even when 
wireshark group is a user group


Summary of changes:
 debian/wireshark-common.postinst |   13 -
 1 file changed, 8 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 927a55f: debian: Add note to README.Debian to log in again to be able to capture packets

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=927a55f914b319abb39923ce7efb1f1377927719
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

927a55f by Balint Reczey (bal...@balintreczey.hu):

debian: Add note to README.Debian to log in again to be able to capture 
packets

Change-Id: Ifae1223d34f7ae071484fe47d1c88de166ed84ca
Reviewed-on: https://code.wireshark.org/review/11692
Reviewed-by: Balint Reczey 


Actions performed:

from  18a54fc   debian: Drop menu support
adds  927a55f   debian: Add note to README.Debian to log in again to be 
able to capture packets


Summary of changes:
 debian/README.Debian |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe