[Wireshark-commits] master f142595: Lua: Validate ProtoExpert.new arguments

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f142595db72955260976d4257592032bef7d492a
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

f142595 by Stig Bjørlykke (s...@bjorlykke.org):

Lua: Validate ProtoExpert.new arguments

Change-Id: I0da829041cda48a35341c315a7889b557b6334d7
Reviewed-on: https://code.wireshark.org/review/12527
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  2fd168c   epan: Don't export deregister functions
adds  f142595   Lua: Validate ProtoExpert.new arguments


Summary of changes:
 epan/wslua/wslua_proto_expert.c |   49 ++-
 1 file changed, 48 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 f0aeef8: Lua: Validate ProtoExpert.new arguments

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0aeef83b1a376dba7cff5d953b18e5510161897
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f0aeef8 by Stig Bjørlykke (s...@bjorlykke.org):

Lua: Validate ProtoExpert.new arguments

Change-Id: I0da829041cda48a35341c315a7889b557b6334d7
Reviewed-on: https://code.wireshark.org/review/12527
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit f142595db72955260976d4257592032bef7d492a)
Reviewed-on: https://code.wireshark.org/review/12528


Actions performed:

from  6aaaf16   Qt: Reload Lua expert infos
adds  f0aeef8   Lua: Validate ProtoExpert.new arguments


Summary of changes:
 epan/wslua/wslua_proto_expert.c |   49 ++-
 1 file changed, 48 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3120d1f: Fix memory leaks in all_ifaces when interface list changes

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3120d1f8012377820dbc011713377ff9daab5f5c
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

3120d1f by Mikael Kanstrup (mikael.kanst...@gmail.com):

Fix memory leaks in all_ifaces when interface list changes

Valgrind report leaks of several allocations like these:
590 bytes in 50 blocks are possibly lost in loss record 29,818 of 31,670
   at 0x4C2B6CD: malloc (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0xCB9C8A7: __vasprintf_chk (vasprintf_chk.c:82)
   by 0xA3D8DCA: g_vasprintf (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
   by 0xA3B846C: g_strdup_vprintf (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
   by 0xA3B850B: g_strdup_printf (in 
/lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
   by 0x6F4B51: scan_local_interfaces (iface_lists.c:254)
   by 0x6EF3D8: iface_mon_handler2 (iface_monitor.c:113)
   by 0xBE56F1D: ??? (in /lib/libnl-3.so.200.3.0)
   by 0xBA16F19: ??? (in /usr/lib/libnl-route-3.so.200.3.0)
   by 0xBE54E5E: nl_cache_parse (in /lib/libnl-3.so.200.3.0)
   by 0xBE585CA: nl_msg_parse (in /lib/libnl-3.so.200.3.0)
   by 0x6EF372: iface_mon_handler (iface_monitor.c:123)

When the list of network interfaces is updated allocations done
for global_capture_opts.all_ifaces elements leak memory. Fixed by
introducing a helper function to be used for removing an interface_t
element from all_ifaces array. While at it also fixed misc leaks when
updating individual allocated records of all_ifaces elements.

Change-Id: I035e6936a44edeef2ebe4780931c14cde99e93a4
Reviewed-on: https://code.wireshark.org/review/12209
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  f142595   Lua: Validate ProtoExpert.new arguments
adds  3120d1f   Fix memory leaks in all_ifaces when interface list changes


Summary of changes:
 capture_opts.c  |   44 +++
 capture_opts.h  |3 +++
 ui/gtk/capture_dlg.c|8 +++
 ui/iface_lists.c|5 +++-
 ui/qt/capture_filter_edit.cpp   |1 +
 ui/qt/capture_interfaces_dialog.cpp |1 +
 ui/qt/interface_tree.cpp|   12 --
 ui/qt/manage_interfaces_dialog.cpp  |3 +++
 8 files changed, 68 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1a40ce9: ENIP: Add sanity check when connection info not available

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a40ce95c546468cf4ae9d1b0980c613a6d1fe3b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

1a40ce9 by D. Ulis (daul...@gmail.com):

ENIP: Add sanity check when connection info not available

If the connection info is not available, ensure that enough connected data 
is available to meet the minimum explicit message size.

Change-Id: I6c8bf54dda4adbf23749d2a2c8c19f4ea2bc5222
Reviewed-on: https://code.wireshark.org/review/12520
Reviewed-by: Anders Broman 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3120d1f   Fix memory leaks in all_ifaces when interface list changes
adds  1a40ce9   ENIP: Add sanity check when connection info not available


Summary of changes:
 epan/dissectors/packet-enip.c |7 +++
 1 file changed, 7 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6586926: MIPv6: Add support for "Home Agent Switch Message" Mobility Header

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6586926a477a4c504ee1b7672757f728cef7b0b3
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6586926 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

MIPv6: Add support for "Home Agent Switch Message" Mobility Header

Specification in RFC 5142.

Change-Id: I30d2f4591f1659b74dce5839e4439aa86f1c5e85
Reviewed-on: https://code.wireshark.org/review/12519
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  1a40ce9   ENIP: Add sanity check when connection info not available
adds  6586926   MIPv6: Add support for "Home Agent Switch Message" Mobility 
Header


Summary of changes:
 epan/dissectors/packet-mip6.c |   87 +++--
 1 file changed, 75 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 febc943: ENIP: Add sanity check when connection info not available

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=febc9431fcea82a41f13e87bd4b1ecd985b60966
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

febc943 by D. Ulis (daul...@gmail.com):

ENIP: Add sanity check when connection info not available

If the connection info is not available, ensure that enough connected data 
is available to meet the minimum explicit message size.

Conflicts:
epan/dissectors/packet-enip.c

Change-Id: I6c8bf54dda4adbf23749d2a2c8c19f4ea2bc5222
Reviewed-on: https://code.wireshark.org/review/12520
Reviewed-by: Anders Broman 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
Reviewed-on: https://code.wireshark.org/review/12533
Petri-Dish: Michael Mann 
Reviewed-by: D. Ulis 


Actions performed:

from  f0aeef8   Lua: Validate ProtoExpert.new arguments
adds  febc943   ENIP: Add sanity check when connection info not available


Summary of changes:
 epan/dissectors/packet-enip.c |8 
 1 file changed, 8 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 66bbc40: Lua: Check for empty name in ProtoField

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66bbc40a47ab6092f2feab145cf942bc97a7652a
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

66bbc40 by Stig Bjørlykke (s...@bjorlykke.org):

Lua: Check for empty name in ProtoField

The check in tmp_fld_check_assert() does terminate with g_error
if given an empty string as name, so we have to check for this.

Change-Id: I084e3e715bd319484a52f60ef90c1a2aea30df1b
Reviewed-on: https://code.wireshark.org/review/12534
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit b031e538f707cead2aa3e9d956eb88ff1d0db4fc)
Reviewed-on: https://code.wireshark.org/review/12535


Actions performed:

from  febc943   ENIP: Add sanity check when connection info not available
adds  66bbc40   Lua: Check for empty name in ProtoField


Summary of changes:
 epan/wslua/wslua_proto_field.c |   25 +
 1 file changed, 25 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b031e53: Lua: Check for empty name in ProtoField

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b031e538f707cead2aa3e9d956eb88ff1d0db4fc
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

b031e53 by Stig Bjørlykke (s...@bjorlykke.org):

Lua: Check for empty name in ProtoField

The check in tmp_fld_check_assert() does terminate with g_error
if given an empty string as name, so we have to check for this.

Change-Id: I084e3e715bd319484a52f60ef90c1a2aea30df1b
Reviewed-on: https://code.wireshark.org/review/12534
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  6586926   MIPv6: Add support for "Home Agent Switch Message" Mobility 
Header
adds  b031e53   Lua: Check for empty name in ProtoField


Summary of changes:
 epan/wslua/wslua_proto_field.c |   25 +
 1 file changed, 25 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3d3698a: ULP: register dissector for application/vnd.omaloc-supl-init media

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d3698a671c8b451fd81975cd3e0951342b9f019
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3d3698a by Pascal Quantin (pascal.quan...@gmail.com):

ULP: register dissector for application/vnd.omaloc-supl-init media

Bug: 11875
Change-Id: Ifb6cdd424ef0062bebb4c4e67ad603461042f111
Reviewed-on: https://code.wireshark.org/review/12538
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Reviewed-by: Anders Broman 


Actions performed:

from  021a695   Consistently use spaces rather than tabs.
adds  3d3698a   ULP: register dissector for 
application/vnd.omaloc-supl-init media


Summary of changes:
 asn1/ulp/packet-ulp-template.c |1 +
 epan/dissectors/packet-ulp.c   |1 +
 2 files changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2ebfa30: IPv6: Dest/Hop extension header register_info fixup

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ebfa30ffd8c5ef76d06f1705cb7e7797bda954a
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2ebfa30 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

IPv6: Dest/Hop extension header register_info fixup

Fixes 90d971014574da1e5615eff1e588d3fb2f9070d2.

Change-Id: I334c8b1816e08163fc68970b19586734b8194087
Reviewed-on: https://code.wireshark.org/review/12532
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  3d3698a   ULP: register dissector for 
application/vnd.omaloc-supl-init media
adds  2ebfa30   IPv6: Dest/Hop extension header register_info fixup


Summary of changes:
 epan/dissectors/packet-ipv6.c |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Clang Code Analysis while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Clang%20Code%20Analysis/builds/3440

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: clang-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] a33209d69e95d025466f4efaebe22f6ae686c214
Blamelist: Michael Mann ,Pascal Quantin 


BUILD FAILED: failed valgrind-wireshark

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win64-libs rev 432: /tags/2015-12-11/

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win64-libs=432

User: pascal
Date: 2015/12/11 09:14 PM

Log:
 Update USBPcap installer
 
 NSIS script modified to:
 - check for KB 3033929 presence on Windows 7 / 2008R2 (as we sign drivers with 
a SHA2 certificate)
 - do not delete the installation folder if not empty

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b8b77ae: Clamp zooming so that we don't get zero or negative font sizes.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8b77aecc38f8ada88de78939e4d35d0fa535bd4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

b8b77ae by Guy Harris (g...@alum.mit.edu):

Clamp zooming so that we don't get zero or negative font sizes.

Those are obviously wrong.

Also, clean up some stuff left over from the GTK+ 1.x days; GTK+ 2.x
doesn't expose raw XLFD font names, it lets you specify a font by name
and size, and font_zoom() doesn't determine whether the font is
resizeable - it just constructs a new font name/size pair and leaves it
up to its callers to try to load the font, so "there's no such font as
Wingdings Gothic" and "you can't blow up Fraktur to 10 million points"
both show up as errors loading the font by name.

Bug: 8854
Change-Id: I6af142c75c9ebabd1a95308c203f8cb1f36dd82f
Reviewed-on: https://code.wireshark.org/review/12549
Reviewed-by: Guy Harris 


Actions performed:

from  2ebfa30   IPv6: Dest/Hop extension header register_info fixup
adds  b8b77ae   Clamp zooming so that we don't get zero or negative font 
sizes.


Summary of changes:
 ui/gtk/font_utils.c   |   28 +---
 ui/gtk/font_utils.h   |2 +-
 ui/gtk/main.c |8 +---
 ui/gtk/prefs_font_color.c |5 ++---
 4 files changed, 17 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5a26599: cmake: Fix platform introspection for inet_aton() [-Wredundant-decls]

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a26599a4bd3b5788b318abbeb0e7f140051ccf1
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

5a26599 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

cmake: Fix platform introspection for inet_aton() [-Wredundant-decls]

Change-Id: Icd6b8de0a70dd33e70bb0ad4d5c39ffc15454e8c
Reviewed-on: https://code.wireshark.org/review/12559
Reviewed-by: Guy Harris 


Actions performed:

from  4454fb0   Ping on Windows isn't necessarily IPv4-only.
adds  5a26599   cmake: Fix platform introspection for inet_aton() 
[-Wredundant-decls]


Summary of changes:
 cmakeconfig.h.in |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 80df76a: tfshark: Declare 'local_wtap_read' static [-Wmissing-prototypes]

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80df76a28f077824d874102a171758757188fdf9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

80df76a by João Valverde (joao.valve...@tecnico.ulisboa.pt):

tfshark: Declare 'local_wtap_read' static [-Wmissing-prototypes]

Change-Id: Iea791f656415e45fe1edfdd5179dbd277d69dac9
Reviewed-on: https://code.wireshark.org/review/12554
Reviewed-by: Guy Harris 


Actions performed:

from  5a26599   cmake: Fix platform introspection for inet_aton() 
[-Wredundant-decls]
adds  80df76a   tfshark: Declare 'local_wtap_read' static 
[-Wmissing-prototypes]


Summary of changes:
 tfshark.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6c38ec1: Update USBPcap installer packaged

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c38ec1aab82d5347451ba3a0058cd81f4218daa
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6c38ec1 by Pascal Quantin (pascal.quan...@gmail.com):

Update USBPcap installer packaged

NSIS script modified to:
- check for KB 3033929 presence on Windows 7 / 2008R2 (as we sign drivers 
with a SHA2 certificate)
- do not delete the installation folder if not empty

Bug: 11766
Change-Id: I5c7b6378b0775bb75c1b9e58e503997176c12213
Reviewed-on: https://code.wireshark.org/review/12546
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  80df76a   tfshark: Declare 'local_wtap_read' static 
[-Wmissing-prototypes]
adds  6c38ec1   Update USBPcap installer packaged


Summary of changes:
 Makefile.nmake   |2 +-
 config.nmake |4 ++--
 packaging/nsis/wireshark.nsi |4 ++--
 tools/win-setup.ps1  |8 
 4 files changed, 9 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.7%20x64/builds/435

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] dbd3e6b3929927f972d03af007fd7e15e304cb16
Blamelist: Pascal Quantin 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 aa16686: Clamp zooming so that we don't get zero or negative font sizes.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa1668673b64a93721693bec4587a614b5078214
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

aa16686 by Guy Harris (g...@alum.mit.edu):

Clamp zooming so that we don't get zero or negative font sizes.

Those are obviously wrong.

Also, clean up some stuff left over from the GTK+ 1.x days; GTK+ 2.x
doesn't expose raw XLFD font names, it lets you specify a font by name
and size, and font_zoom() doesn't determine whether the font is
resizeable - it just constructs a new font name/size pair and leaves it
up to its callers to try to load the font, so "there's no such font as
Wingdings Gothic" and "you can't blow up Fraktur to 10 million points"
both show up as errors loading the font by name.

Bug: 8854
Change-Id: I6af142c75c9ebabd1a95308c203f8cb1f36dd82f
Reviewed-on: https://code.wireshark.org/review/12549
Reviewed-by: Guy Harris 
(cherry picked from commit b8b77aecc38f8ada88de78939e4d35d0fa535bd4)
Reviewed-on: https://code.wireshark.org/review/12550


Actions performed:

from  66bbc40   Lua: Check for empty name in ProtoField
adds  aa16686   Clamp zooming so that we don't get zero or negative font 
sizes.


Summary of changes:
 ui/gtk/font_utils.c   |   28 +---
 ui/gtk/font_utils.h   |2 +-
 ui/gtk/main.c |8 +---
 ui/gtk/prefs_font_color.c |5 ++---
 4 files changed, 17 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-1.12 1a44ff1: Clamp zooming so that we don't get zero or negative font sizes.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a44ff1fe44d6879142ebb9875443287d3eba690
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-1.12
Repository: wireshark

Commits:

1a44ff1 by Guy Harris (g...@alum.mit.edu):

Clamp zooming so that we don't get zero or negative font sizes.

Those are obviously wrong.

Also, clean up some stuff left over from the GTK+ 1.x days; GTK+ 2.x
doesn't expose raw XLFD font names, it lets you specify a font by name
and size, and font_zoom() doesn't determine whether the font is
resizeable - it just constructs a new font name/size pair and leaves it
up to its callers to try to load the font, so "there's no such font as
Wingdings Gothic" and "you can't blow up Fraktur to 10 million points"
both show up as errors loading the font by name.

Bug: 8854
Change-Id: I6af142c75c9ebabd1a95308c203f8cb1f36dd82f
Reviewed-on: https://code.wireshark.org/review/12549
Reviewed-by: Guy Harris 
(cherry picked from commit b8b77aecc38f8ada88de78939e4d35d0fa535bd4)
Reviewed-on: https://code.wireshark.org/review/12551


Actions performed:

from  9c62fc6   6LowPAN: Check for NHC IPv6 No Next Header
adds  1a44ff1   Clamp zooming so that we don't get zero or negative font 
sizes.


Summary of changes:
 ui/gtk/font_utils.c   |   28 +---
 ui/gtk/font_utils.h   |2 +-
 ui/gtk/main.c |8 +---
 ui/gtk/prefs_font_color.c |5 ++---
 4 files changed, 17 insertions(+), 26 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4454fb0: Ping on Windows isn't necessarily IPv4-only.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4454fb02c7d37803d99c9a1228db35b2c8f75220
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

4454fb0 by Gerald Combs (ger...@wireshark.org):

Ping on Windows isn't necessarily IPv4-only.

The default prefix policy on modern versions of Windows prefers IPv6.
This in combination with the fact that our ping target (www.wireshark.org)
currently has both A and  records might result in ICMPv6 traffic
instead of ICMPv4. Update the capture test suite accordingly.

Change-Id: I5c88f24fb9458526ffd44c5003f09247b6999ce7
Reviewed-on: https://code.wireshark.org/review/12553
Reviewed-by: Gerald Combs 


Actions performed:

from  b8b77ae   Clamp zooming so that we don't get zero or negative font 
sizes.
adds  4454fb0   Ping on Windows isn't necessarily IPv4-only.


Summary of changes:
 test/suite-capture.sh |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 021a695: Consistently use spaces rather than tabs.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=021a695e62a5745bf73a06f701525814812ed030
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

021a695 by Guy Harris (g...@alum.mit.edu):

Consistently use spaces rather than tabs.

Change-Id: I9761b7ce0eb42c3b6dc39bd01179c302b2233e91
Reviewed-on: https://code.wireshark.org/review/12540
Reviewed-by: Guy Harris 


Actions performed:

from  b031e53   Lua: Check for empty name in ProtoField
adds  021a695   Consistently use spaces rather than tabs.


Summary of changes:
 epan/dissectors/packet-ieee80211-radio.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 478: / /trunk/packages/: USBPcapSetup-1.1.0.0-g794bf26-1.exe USBPcapSetup-1.1.0.0-g794bf26.exe /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=478

User: pascal
Date: 2015/12/11 08:47 PM

Log:
 Update USBPcap installer
 
 NSIS script modified to:
 - check for KB 3033929 presence on Windows 7 / 2008R2 (as we sign drivers with 
a SHA2 certificate)
 - do not delete the installation folder if not empty

Directory: /trunk/packages/
  ChangesPath   Action
  +0 -0  USBPcapSetup-1.1.0.0-g794bf26-1.exeAdded
  +0 -0  USBPcapSetup-1.1.0.0-g794bf26.exe  Removed

Directory: /trunk/
  ChangesPath  Action
  +3 -2  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2fd168c: epan: Don't export deregister functions

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2fd168c134092a4e0cc587f6c474dd38681a6c23
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

2fd168c by Stig Bjørlykke (s...@bjorlykke.org):

epan: Don't export deregister functions

Most of the deregister functions are used internally from Lua
while reloading plugins.  Don't export them for others to use.

Change-Id: I919dbfa807f696c38d409ca7206104a0fba1ae65
Reviewed-on: https://code.wireshark.org/review/12508
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  9cbb646   Changed references for IntraPAN to PAN ID Compression as 
per all versions 802.15.4-2006 and laterChange-Id: 
I99e66919c86712533cd37fef9d4c464b75444d93
adds  2fd168c   epan: Don't export deregister functions


Summary of changes:
 debian/libwireshark0.symbols |8 
 epan/expert.h|2 +-
 epan/funnel.h|2 +-
 epan/packet.c|2 +-
 epan/packet.h|9 +++--
 epan/prefs.h |2 +-
 epan/proto.h |2 +-
 7 files changed, 8 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.5 x86 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.5%20x86/builds/15651

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.5-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 80df76a28f077824d874102a171758757188fdf9
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 479: /trunk/ /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=479

User: pascal
Date: 2015/12/11 08:52 PM

Log:
 Fix typo

Directory: /trunk/
  ChangesPath  Action
  +1 -1  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win32-libs rev 480: /tags/2015-12-11/

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win32-libs=480

User: pascal
Date: 2015/12/11 08:58 PM

Log:
 Update USBPcap installer
 
 NSIS script modified to:
 - check for KB 3033929 presence on Windows 7 / 2008R2 (as we sign drivers with 
a SHA2 certificate)
 - do not delete the installation folder if not empty

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] wireshark-win64-libs rev 431: / /trunk/packages/: USBPcapSetup-1.1.0.0-g794bf26-1.exe USBPcapSetup-1.1.0.0-g794bf26.exe /trunk/: README.txt

[pascal]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev=Wireshark-win64-libs=431

User: pascal
Date: 2015/12/11 09:03 PM

Log:
 Update USBPcap installer
 
 NSIS script modified to:
 - check for KB 3033929 presence on Windows 7 / 2008R2 (as we sign drivers with 
a SHA2 certificate)
 - do not delete the installation folder if not empty

Directory: /trunk/packages/
  ChangesPath   Action
  +0 -0  USBPcapSetup-1.1.0.0-g794bf26-1.exeAdded
  +0 -0  USBPcapSetup-1.1.0.0-g794bf26.exe  Removed

Directory: /trunk/
  ChangesPath  Action
  +2 -1  README.txtModified

___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe