[Wireshark-commits] master 9663d8c: ERF: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9663d8c4771934be165eef59c7cdb75c19aa2558
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

9663d8c by Alexis La Goutte (alexis.lagou...@gmail.com):

ERF: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

Change-Id: Ibdf2eef90dff97498ddf9e11dfa14b7117ea4eab
Reviewed-on: https://code.wireshark.org/review/13326
Reviewed-by: Anders Broman 


Actions performed:

from  1c090e9   [LBMC] Bugfix stack-based buffer overflow in 
dissect_nhdr_extopt.
adds  9663d8c   ERF: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang


Summary of changes:
 epan/dissectors/packet-erf.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 174fa7e: MAUSB: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=174fa7e2f7662a080231fd31250d8bd1b23cd5b3
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

174fa7e by Alexis La Goutte (alexis.lagou...@gmail.com):

MAUSB: Fix Dead Store (Dead assignement/Dead increment) Warning found by 
Clang

Change-Id: I69b21ee05755cf849d52756ef4cad7bb3571762d
Reviewed-on: https://code.wireshark.org/review/13327
Reviewed-by: Anders Broman 


Actions performed:

from  9663d8c   ERF: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang
adds  174fa7e   MAUSB: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang


Summary of changes:
 epan/dissectors/packet-mausb.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5335f1d: DCM: ignore the upper flag bits of PDV in PDU DATA packet

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5335f1d065b1e30619ed7c2ba4a68b9df48ad157
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5335f1d by Rich Coe (richc...@gmail.com):

DCM: ignore the upper flag bits of PDV in PDU DATA packet

The DICOM protocol in PS3.8 E.2 says bits 2-7 should be set to zero by 
the
sender and not checked by the receiver.  The version of software 
sending a
bad PDV flags is PACSONE01AUG03.  The version of this software might be
2004-02-07 (or earlier) found at http://www.pacsone.net/download.htm

Change-Id: If4d9d8e63d7bdba0f8f1c50e49979ca15b5f9157
Reviewed-on: https://code.wireshark.org/review/13384
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  174fa7e   MAUSB: Fix Dead Store (Dead assignement/Dead increment) 
Warning found by Clang
adds  5335f1d   DCM: ignore the upper flag bits of PDV in PDU DATA 
packet


Summary of changes:
 epan/dissectors/packet-dcm.c |   32 +++-
 1 file changed, 23 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 60a0852: improved vuze-dht support

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=60a085269d3c5da6c5aeb52fdc52732307596840
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

60a0852 by Дмитрий Цветцих (dmitryc...@gmail.com):

improved vuze-dht support

Vuze have a very old documentation. The last version
of the protocol contains 2 new fields. This patch added
support of these fields. They are named "Generic Flags" and
"Generic Flags 2" as a getters in source code.

Change-Id: I2257b273537ee2d5316ebcde72ade6ad4ad8d299
Reviewed-on: https://code.wireshark.org/review/13395
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  72a9968   Don't use IP address strings as "names" for MAC addresses.
adds  60a0852   improved vuze-dht support


Summary of changes:
 epan/dissectors/packet-vuze-dht.c |   68 +
 1 file changed, 62 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 72a9968: Don't use IP address strings as "names" for MAC addresses.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=72a9968fabd30865bd972f13613f10b33ecc0272
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

72a9968 by Guy Harris (g...@alum.mit.edu):

Don't use IP address strings as "names" for MAC addresses.

Have a flag for addresses indicating whether the address is resolved to
a name or whether its "name" is just a printable version of the address.
If the name corresponding to an IP address isn't really a name, don't
assign it to a MAC address.

Clean up some code a bit (have a fill_dummy_ip6() corresponding to
fill_dummy_ip4()).

Bug: 10212
Change-Id: I9d0ffa2706be17842f832c64cea7acc5c1dc6536
Reviewed-on: https://code.wireshark.org/review/13412
Reviewed-by: Guy Harris 


Actions performed:

from  5335f1d   DCM: ignore the upper flag bits of PDV in PDU DATA 
packet
adds  72a9968   Don't use IP address strings as "names" for MAC addresses.


Summary of changes:
 epan/addr_resolv.c |   96 +++-
 epan/addr_resolv.h |9 ++---
 2 files changed, 54 insertions(+), 51 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 83dd13c: [iseries] fix iseries_check_file_type()

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83dd13cc56cd825219fa3209ae401b730414b413
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

83dd13c by Martin Kaiser (wiresh...@kaiser.cx):

[iseries] fix iseries_check_file_type()

check that we have a line that contains OBJECT PROTOCOL ETHERNET
(at the moment, we fail if there's a line containing OBJECT PROTOCOL but
 not ETHERNET and succeed otherwise
 -> a file with some random lines will be identified as iseries)

initialize our line buffer with 0s to make sure we don't access 
uninitialized
data while parsing

don't set wth->priv unless the file is really an iseries file

free the iseries struct if the file is not our type

Bug: 11985
Change-Id: I0ac7003c047f54ca025d02e59b56d1ff4e2a6be7
Reviewed-on: https://code.wireshark.org/review/13360
Petri-Dish: Martin Kaiser 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
(cherry picked from commit 96d585a5e9baef21e1eea8505d78305b034dc80e)
Reviewed-on: https://code.wireshark.org/review/13373
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Reviewed-by: Anders Broman 


Actions performed:

from  32fc1bc   [LBMC] Bugfix stack-based buffer overflow in 
dissect_nhdr_extopt.
adds  83dd13c   [iseries] fix iseries_check_file_type()


Summary of changes:
 wiretap/iseries.c |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fed3921: [OpenFlow v1] Dissect part of stats messages.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fed392137638dc604277a407fc05b41260f87f83
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

fed3921 by AndersBroman (anders.bro...@ericsson.com):

[OpenFlow v1] Dissect part of stats messages.

Bug: 12023
Change-Id: I09d53d25247be8f932375e1d0778211241b0907d
Reviewed-on: https://code.wireshark.org/review/13396
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  60a0852   improved vuze-dht support
adds  fed3921   [OpenFlow v1] Dissect part of stats messages.


Summary of changes:
 epan/dissectors/packet-openflow_v1.c |  173 +++---
 1 file changed, 161 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0cb2311: RTITCP: fix heuristic dissector

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cb2311a245d7a7a7375f818f8ce2fa11c9901ae
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0cb2311 by Pascal Quantin (pascal.quan...@gmail.com):

RTITCP: fix heuristic dissector

Ensure that 8 bytes are captured before checking magic content

Change-Id: I44465157b97169a5dc1c359a8e06b56e9572f8d5
Reviewed-on: https://code.wireshark.org/review/13423
Reviewed-by: Pascal Quantin 


Actions performed:

from  fca54f8   Waveagent: fix heuristic dissector
adds  0cb2311   RTITCP: fix heuristic dissector


Summary of changes:
 epan/dissectors/packet-rtitcp.c |3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%207%20x64/builds/15204

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] fca54f8c0d44db111ecfb62643ce548b460acc3f
Blamelist: Pascal Quantin 

BUILD FAILED: failed rsync

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fca54f8: Waveagent: fix heuristic dissector

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fca54f8c0d44db111ecfb62643ce548b460acc3f
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

fca54f8 by Pascal Quantin (pascal.quan...@gmail.com):

Waveagent: fix heuristic dissector

Heuristics should be based on the captured data, not the reported one

Change-Id: I6b9abdc80bb70c97196c6bddabb76efcccd58672
Reviewed-on: https://code.wireshark.org/review/13421
Reviewed-by: Pascal Quantin 


Actions performed:

from  56bffba   Qt: Update window title when preferences changed.
adds  fca54f8   Waveagent: fix heuristic dissector


Summary of changes:
 epan/dissectors/packet-waveagent.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 14.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 14.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Ubuntu%2014.04%20x64/builds/518

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: ubuntu-14.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] c835910bbcead2e2ef95458a1a53140113f5c7c3
Blamelist: Pascal Quantin 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 56bffba: Qt: Update window title when preferences changed.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56bffba031dfd22aced907bcd44ec7c981a820f9
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

56bffba by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Update window title when preferences changed.

When switching profile the prefs.gui_window_title may have changed
so ensure we update the main window title.

Change-Id: Ic1f9c7ac075d77c60cfbebb20624e597f7eb8449
Reviewed-on: https://code.wireshark.org/review/13418
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  630c814   [XML] Add application/vnd.3gpp.sms+xml
adds  56bffba   Qt: Update window title when preferences changed.


Summary of changes:
 ui/qt/main_window.cpp |1 +
 ui/qt/main_window.h   |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 e0c7bdc: Qt: Update window title when preferences changed.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0c7bdc09d9e3ff368fcb6c198cf7a7ff647e4ca
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

e0c7bdc by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Update window title when preferences changed.

When switching profile the prefs.gui_window_title may have changed
so ensure we update the main window title.

Change-Id: Ic1f9c7ac075d77c60cfbebb20624e597f7eb8449
Reviewed-on: https://code.wireshark.org/review/13418
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
(cherry picked from commit 56bffba031dfd22aced907bcd44ec7c981a820f9)
Reviewed-on: https://code.wireshark.org/review/13420
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  1f4977b   X509AF: make a local copy of algorithm_id in file scope for 
later use
adds  e0c7bdc   Qt: Update window title when preferences changed.


Summary of changes:
 ui/qt/main_window.cpp |1 +
 ui/qt/main_window.h   |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 b668ce4: Treat invalid (negative or too-large) values in the packet header as errors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b668ce44f5a0b8ca40399add5ae40468db4dc2b1
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b668ce4 by Guy Harris (g...@alum.mit.edu):

Treat invalid (negative or too-large) values in the packet header as errors.

Change-Id: I86564c485aacd3fcba3f3d8d9da492e0100155e8
Reviewed-on: https://code.wireshark.org/review/12299
Reviewed-by: Guy Harris 
(cherry picked from commit 943be4b755d46fa348bea3474af503c3b9f6dc39)
Reviewed-on: https://code.wireshark.org/review/13428


Actions performed:

from  78938ad   [iseries] return WTAP_OPEN_ERROR if file_seek() fails
adds  b668ce4   Treat invalid (negative or too-large) values in the packet 
header as errors.


Summary of changes:
 wiretap/iseries.c |   60 +
 1 file changed, 60 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f55bb2e: Note that using file_gets() for UCS-2 files is a bit of a hack.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f55bb2e27cd13e2b0574e86916cac94b7ff08714
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

f55bb2e by Guy Harris (g...@alum.mit.edu):

Note that using file_gets() for UCS-2 files is a bit of a hack.

Change-Id: I09cb8c8ea86c83f079c0882ca2f28e2f7c338b51
Reviewed-on: https://code.wireshark.org/review/13429
Reviewed-by: Guy Harris 


Actions performed:

from  106da4a   Fix indentation.
adds  f55bb2e   Note that using file_gets() for UCS-2 files is a bit of a 
hack.


Summary of changes:
 wiretap/iseries.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 106da4a: Fix indentation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=106da4ad5f8f2e18a0382148a3c746793a5c55e4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

106da4a by Guy Harris (g...@alum.mit.edu):

Fix indentation.

Change-Id: I9fc0b8f98439ac37d4356e742d8c411e2dce473f
Reviewed-on: https://code.wireshark.org/review/13425
Reviewed-by: Guy Harris 


Actions performed:

from  0cb2311   RTITCP: fix heuristic dissector
adds  106da4a   Fix indentation.


Summary of changes:
 wiretap/iseries.c |   62 ++---
 1 file changed, 31 insertions(+), 31 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 fc0151e: Fix indentation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc0151ef7c0dcfdf2085acb0187ea75272b884a1
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

fc0151e by Guy Harris (g...@alum.mit.edu):

Fix indentation.

Change-Id: I9fc0b8f98439ac37d4356e742d8c411e2dce473f
Reviewed-on: https://code.wireshark.org/review/13425
Reviewed-by: Guy Harris 
(cherry picked from commit 106da4ad5f8f2e18a0382148a3c746793a5c55e4)
Reviewed-on: https://code.wireshark.org/review/13426


Actions performed:

from  c835910   Waveagent: fix heuristic dissector
adds  fc0151e   Fix indentation.


Summary of changes:
 wiretap/iseries.c |   62 ++---
 1 file changed, 31 insertions(+), 31 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 78938ad: [iseries] return WTAP_OPEN_ERROR if file_seek() fails

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78938ad2ce91367375dd997786fab8f6e8ce24a9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

78938ad by Martin Kaiser (wiresh...@kaiser.cx):

[iseries] return WTAP_OPEN_ERROR if file_seek() fails

like it's done for the other file types

Change-Id: I8caa360b9c527ea642ee6b5102759ad341ad0030
Reviewed-on: https://code.wireshark.org/review/13359
Reviewed-by: Martin Kaiser 
(cherry picked from commit 8a0966c434231e515bc8c5e2130b8a7d8121b37f)
Reviewed-on: https://code.wireshark.org/review/13427
Reviewed-by: Guy Harris 


Actions performed:

from  fc0151e   Fix indentation.
adds  78938ad   [iseries] return WTAP_OPEN_ERROR if file_seek() fails


Summary of changes:
 wiretap/iseries.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 846f08b: Bluetooth: GATT: Better name resolution of handles

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=846f08b97ecd08b3b0c14accec4977919ac786ac
Submitter: Michal Labedzki (michal.labed...@tieto.com)
Changed: branch: master
Repository: wireshark

Commits:

846f08b by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: GATT: Better name resolution of handles

Print in Info column:
- service names while Discovery
- additional characteristic informations while Finding
- service name for characteristics, for example Handle: 0x002F (Battery 
Service: Battery Level)
- service name, characteristic name and additional configuration 
characteristic
  name while read/write/etc it, for example:
Handle: 0x0030 (Battery Service: Battery Level: Client Characteristic 
Configuration)
  Reason: "Client Characteristic Configuration" is configuration of 
characteristic,
  in this case "Battery Level". Service name may be useful is somebody 
involved own service
  with the same characteristic - "Battery Level".

Change-Id: I846755d58708ca60ad2a223b24a4a164b3c7cc14
Reviewed-on: https://code.wireshark.org/review/13390
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 
Tested-by: Michal Labedzki 


Actions performed:

from  aeeb2a9   Call the dissectors for types in TZSP packets individually.
adds  846f08b   Bluetooth: GATT: Better name resolution of handles


Summary of changes:
 epan/dissectors/packet-btatt.c |  183 
 1 file changed, 148 insertions(+), 35 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master aeeb2a9: Call the dissectors for types in TZSP packets individually.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aeeb2a99420f90121ffccaab817a51096e078c70
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

aeeb2a9 by Guy Harris (g...@alum.mit.edu):

Call the dissectors for types in TZSP packets individually.

That way, we know we're passing them the dissector data they expect.

Change-Id: I43aa1b751705eae77e082c537e8ffd6a4edc1a5f
Reviewed-on: https://code.wireshark.org/review/13430
Reviewed-by: Guy Harris 


Actions performed:

from  f55bb2e   Note that using file_gets() for UCS-2 files is a bit of a 
hack.
adds  aeeb2a9   Call the dissectors for types in TZSP packets individually.


Summary of changes:
 epan/dissectors/packet-ieee80211-prism.c |7 +-
 epan/dissectors/packet-tzsp.c|  171 +-
 2 files changed, 99 insertions(+), 79 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0dbe79c: Qt: Resize columns to contents in DecodeAs

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0dbe79c53fe40cd388bd84eac452cb48d204ef13
Submitter: Michal Labedzki (michal.labed...@tieto.com)
Changed: branch: master
Repository: wireshark

Commits:

0dbe79c by Michal Labedzki (michal.labed...@tieto.com):

Qt: Resize columns to contents in DecodeAs

If user first time run DecodeAs columns width are not enough,
so content are trimmed. Do resizing whenever add new item.

Change-Id: I378e2a5b2134479d961f3f00d398d8052f7e556d
Reviewed-on: https://code.wireshark.org/review/13392
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 


Actions performed:

from  846f08b   Bluetooth: GATT: Better name resolution of handles
adds  0dbe79c   Qt: Resize columns to contents in DecodeAs


Summary of changes:
 ui/qt/decode_as_dialog.cpp |6 ++
 1 file changed, 6 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/9976

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 0dbe79c53fe40cd388bd84eac452cb48d204ef13
Blamelist: Michal Labedzki 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 69b8f6c: sshdump: fix typo in extcap-config.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69b8f6ca552007e5d62097293c7474d7bb08f8e5
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

69b8f6c by Dario Lombardo (lom...@gmail.com):

sshdump: fix typo in extcap-config.

Change-Id: Ie6e60244e9ec6f80d37db9e46342c363825bc9ce
Reviewed-on: https://code.wireshark.org/review/13415
Petri-Dish: Dario Lombardo 
Reviewed-by: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 


Actions performed:

from  fed3921   [OpenFlow v1] Dissect part of stats messages.
adds  69b8f6c   sshdump: fix typo in extcap-config.


Summary of changes:
 extcap/sshdump.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5a8020a: X509AF: make a local copy of algorithm_id in file scope for later use

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a8020a1b6bb73fcb8bb7eb7d53177bc8a9fc703
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5a8020a by Pascal Quantin (pascal.quan...@gmail.com):

X509AF: make a local copy of algorithm_id in file scope for later use

Bug: 12002
Change-Id: Iff48863c1954f76d6fc34150d315d15295dc1f5c
Reviewed-on: https://code.wireshark.org/review/13406
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  69b8f6c   sshdump: fix typo in extcap-config.
adds  5a8020a   X509AF: make a local copy of algorithm_id in file scope for 
later use


Summary of changes:
 asn1/x509af/packet-x509af-template.c |2 +-
 asn1/x509af/x509af.cnf   |8 +++-
 epan/dissectors/packet-x509af.c  |   24 +++-
 3 files changed, 23 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 1f4977b: X509AF: make a local copy of algorithm_id in file scope for later use

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f4977b27ea4e3a0d95902ce1f5dea1edb546b5e
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1f4977b by Pascal Quantin (pascal.quan...@gmail.com):

X509AF: make a local copy of algorithm_id in file scope for later use

Bug: 12002
Change-Id: Iff48863c1954f76d6fc34150d315d15295dc1f5c
Reviewed-on: https://code.wireshark.org/review/13406
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 
(cherry picked from commit 5a8020a1b6bb73fcb8bb7eb7d53177bc8a9fc703)
Conflicts:
epan/dissectors/packet-x509af.c
Reviewed-on: https://code.wireshark.org/review/13417


Actions performed:

from  83dd13c   [iseries] fix iseries_check_file_type()
adds  1f4977b   X509AF: make a local copy of algorithm_id in file scope for 
later use


Summary of changes:
 asn1/x509af/packet-x509af-template.c |2 +-
 asn1/x509af/x509af.cnf   |8 +++-
 epan/dissectors/packet-x509af.c  |   22 ++
 3 files changed, 22 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 630c814: [XML] Add application/vnd.3gpp.sms+xml

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=630c8140c93c5318854def7b10260dffd3cf6f35
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

630c814 by AndersBroman (anders.bro...@ericsson.com):

[XML] Add application/vnd.3gpp.sms+xml

Change-Id: Id2067b8479840fe75150f40797aa2e7ae1ea96e3
Reviewed-on: https://code.wireshark.org/review/13416
Reviewed-by: Anders Broman 


Actions performed:

from  5a8020a   X509AF: make a local copy of algorithm_id in file scope for 
later use
adds  630c814   [XML] Add application/vnd.3gpp.sms+xml


Summary of changes:
 epan/dissectors/packet-xml.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe