[Wireshark-commits] master cadae1c: ISAKMP: Fix implicit conversion to shorter type.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cadae1c8bee9db26fb04fb790b7df23a0f0fd1bc
Submitter: João Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

cadae1c by João Valverde (joao.valve...@tecnico.ulisboa.pt):

ISAKMP: Fix implicit conversion to shorter type.

Change-Id: I6b3c20d3aa1ade39739cad560d9f27242a9c8a4a
Reviewed-on: https://code.wireshark.org/review/13479
Reviewed-by: João Valverde 


Actions performed:

from  fc511c3   CIP: Add support for Get Attributes All
adds  cadae1c   ISAKMP: Fix implicit conversion to shorter type.


Summary of changes:
 epan/dissectors/packet-isakmp.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e8d0d37: Try to fix compiler warnings.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8d0d3763a7d480ff905825a1cf847fa47482c87
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e8d0d37 by Guy Harris (g...@alum.mit.edu):

Try to fix compiler warnings.

Parenthesize differently and, while we're at it, don't use the useless
gsize data type - C has had size_t since C89, use it.  gsize's only
purpose is to use in APIs defined to take gsize arguments.

Change-Id: I7d68273e7e0f0e71947d3505cb283bfa216fce03
Reviewed-on: https://code.wireshark.org/review/13488
Reviewed-by: Guy Harris 


Actions performed:

from  f78d761   Fix DIAG_OFF() and DIAG_ON() calls.
adds  e8d0d37   Try to fix compiler warnings.


Summary of changes:
 epan/dissectors/packet-isakmp.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f78d761: Fix DIAG_OFF() and DIAG_ON() calls.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f78d7616b568782952a45cd2b8b08c74fe43a614
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

f78d761 by Guy Harris (g...@alum.mit.edu):

Fix DIAG_OFF() and DIAG_ON() calls.

DIAG_O{FF,N} take a warning flag name *without* the "W".

Change-Id: I00558e42804b9f2ec4e80fae7c739541880381ca
Reviewed-on: https://code.wireshark.org/review/13487
Reviewed-by: Guy Harris 


Actions performed:

from  e63fd92   lemon (tools): Fix Dereference of null pointer found by 
Clang analyzer
adds  f78d761   Fix DIAG_OFF() and DIAG_ON() calls.


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 19d43a0: sshdump: fix leak in ssh_open_remote_connection() (CID 1349731)

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19d43a03b671bfe73ba65ef664cb9ebb71192644
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

19d43a0 by Dario Lombardo (lom...@gmail.com):

sshdump: fix leak in ssh_open_remote_connection() (CID 1349731)

Change-Id: I55656d4600edb800fd93532345f7ea2c7fc16f7d
Reviewed-on: https://code.wireshark.org/review/13466
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  c260640   ISAKMP: Try to really fix implicit conversion warning on 
OSX 64 bit.
adds  19d43a0   sshdump: fix leak in ssh_open_remote_connection() (CID 
1349731)


Summary of changes:
 extcap/sshdump.c |   22 --
 1 file changed, 12 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-1.12 ca3cfe0: GSM A DTAP: fix display of calling/called party BCD number in parent tree

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca3cfe0d23293df1046f407c418a6c46e9ca5344
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-1.12
Repository: wireshark

Commits:

ca3cfe0 by Pascal Quantin (pascal.quan...@gmail.com):

GSM A DTAP: fix display of calling/called party BCD number in parent tree

Change-Id: I0a492d1c304c285b831f553158777843ad195c2d
Reviewed-on: https://code.wireshark.org/review/13481
Reviewed-by: Pascal Quantin 
(cherry picked from commit 5f5f16021e42ee3bb5078ae1ae0eb9474709c30a)
Conflicts:
epan/dissectors/packet-gsm_a_dtap.c
Reviewed-on: https://code.wireshark.org/review/13486


Actions performed:

from  2177a15   Call the "without FCS" version of the Ethernet dissector.
adds  ca3cfe0   GSM A DTAP: fix display of calling/called party BCD number 
in parent tree


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c |   48 +--
 1 file changed, 23 insertions(+), 25 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3343729: Fix warnings for qt_ui_utils.cpp [-Wcast-qual]

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3343729457e3cb4b02b16e7cc7265d26a928a429
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

3343729 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

Fix warnings for qt_ui_utils.cpp [-Wcast-qual]

Change-Id: Ie1d2779d9eaf59c2f440efa096f6707375f11c6f
Reviewed-on: https://code.wireshark.org/review/13443
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  fa0e874   [iso14443] dissect two more components of the ATQB
adds  3343729   Fix warnings for qt_ui_utils.cpp [-Wcast-qual]


Summary of changes:
 ui/qt/qt_ui_utils.cpp |8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/15164

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 7d6d893da3b20bd5313f5a53460a8714e974b7f0
Blamelist: Alexis La Goutte ,Michael Mann 


BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e63fd92: lemon (tools): Fix Dereference of null pointer found by Clang analyzer

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e63fd927f9556035439cd3cb24221e015ae7a295
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

e63fd92 by Alexis La Goutte (alexis.lagou...@gmail.com):

lemon (tools): Fix Dereference of null pointer found by Clang analyzer

Change-Id: Ica08d9372fbe3809eb078e0285cba2a49cee6b8d
Reviewed-on: https://code.wireshark.org/review/13331
Reviewed-by: Dario Lombardo 
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3343729   Fix warnings for qt_ui_utils.cpp [-Wcast-qual]
adds  e63fd92   lemon (tools): Fix Dereference of null pointer found by 
Clang analyzer


Summary of changes:
 tools/lemon/lemon.c |   47 +--
 1 file changed, 25 insertions(+), 22 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 14.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2014.04%20x64/builds/5293

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-14.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 7d6d893da3b20bd5313f5a53460a8714e974b7f0
Blamelist: Alexis La Goutte ,Michael Mann 


BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 b36dbfb: GSM A DTAP: fix display of calling/called party BCD number in parent tree

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b36dbfb9a91853597d2377049f77f82fd6e177ad
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b36dbfb by Pascal Quantin (pascal.quan...@gmail.com):

GSM A DTAP: fix display of calling/called party BCD number in parent tree

Change-Id: I0a492d1c304c285b831f553158777843ad195c2d
Reviewed-on: https://code.wireshark.org/review/13481
Reviewed-by: Pascal Quantin 
(cherry picked from commit 5f5f16021e42ee3bb5078ae1ae0eb9474709c30a)
Conflicts:
epan/dissectors/packet-gsm_a_dtap.c
Reviewed-on: https://code.wireshark.org/review/13484


Actions performed:

from  c98c845   Qt: fix a crash when trying to open TCP stream graph on a 
truncated TCP packet
adds  b36dbfb   GSM A DTAP: fix display of calling/called party BCD number 
in parent tree


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c |   46 +--
 1 file changed, 22 insertions(+), 24 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5f5f160: GSM A DTAP: fix display of calling/called party BCD number in parent tree

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f5f16021e42ee3bb5078ae1ae0eb9474709c30a
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

5f5f160 by Pascal Quantin (pascal.quan...@gmail.com):

GSM A DTAP: fix display of calling/called party BCD number in parent tree

Change-Id: I0a492d1c304c285b831f553158777843ad195c2d
Reviewed-on: https://code.wireshark.org/review/13481
Reviewed-by: Pascal Quantin 


Actions performed:

from  7d6d893   GSM A DTAP: get rid of a global buffer
adds  5f5f160   GSM A DTAP: fix display of calling/called party BCD number 
in parent tree


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c |   46 +--
 1 file changed, 22 insertions(+), 24 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/5432

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 7d6d893da3b20bd5313f5a53460a8714e974b7f0
Blamelist: Alexis La Goutte ,Michael Mann 


BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fa0e874: [iso14443] dissect two more components of the ATQB

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa0e87488f5dec9d8e98bcda9bc8b96ff80eac2f
Submitter: Martin Kaiser (wiresh...@kaiser.cx)
Changed: branch: master
Repository: wireshark

Commits:

fa0e874 by Martin Kaiser (wiresh...@kaiser.cx):

[iso14443] dissect two more components of the ATQB

Change-Id: I4fc1962a391549e880dcdf52dfa13a94d3568ea8
Reviewed-on: https://code.wireshark.org/review/13483
Reviewed-by: Martin Kaiser 


Actions performed:

from  5f5f160   GSM A DTAP: fix display of calling/called party BCD number 
in parent tree
adds  fa0e874   [iso14443] dissect two more components of the ATQB


Summary of changes:
 epan/dissectors/packet-iso14443.c |   30 --
 1 file changed, 24 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7d6d893: GSM A DTAP: get rid of a global buffer

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d6d893da3b20bd5313f5a53460a8714e974b7f0
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

7d6d893 by Pascal Quantin (pascal.quan...@gmail.com):

GSM A DTAP: get rid of a global buffer

Change-Id: Icdd58960ca2673ea19b1005c47f3b06f1165caa2
Reviewed-on: https://code.wireshark.org/review/13482
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  19d43a0   sshdump: fix leak in ssh_open_remote_connection() (CID 
1349731)
adds  7d6d893   GSM A DTAP: get rid of a global buffer


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c |   44 +--
 1 file changed, 21 insertions(+), 23 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9b8f526: That warning is bogus; squelch it with an otherwise-unnecessary cast.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b8f5261f71f12f86ff2e2e5f28688a0a7ba4ffa
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

9b8f526 by Guy Harris (g...@alum.mit.edu):

That warning is bogus; squelch it with an otherwise-unnecessary cast.

The compiler being used for the 64-bit OS X build is buggy; throw in an
otherwise-unnecessary cast to squelch its bogus warning.

Change-Id: Ie2104ba861493870191530ca391a089ca3951929
Reviewed-on: https://code.wireshark.org/review/13489
Reviewed-by: Guy Harris 


Actions performed:

from  e8d0d37   Try to fix compiler warnings.
adds  9b8f526   That warning is bogus; squelch it with an 
otherwise-unnecessary cast.


Summary of changes:
 epan/dissectors/packet-isakmp.c |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fc511c3: CIP: Add support for Get Attributes All

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc511c3f11d1e744adbf8fff6b1e46adc9776c94
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

fc511c3 by Michael Mann (mman...@netscape.net):

CIP: Add support for Get Attributes All

Get Attributes All is a predefined list of existing attribute IDs for a 
given class.  Add a new index for each attribute for their place in 
GetAttributesAll response. Then a hash table of classes for existing attributes 
are created to handle the GetAttributesAll service.

Added more TCP/IP object attributes since more have been added to the spec.
Moved TCP/IP object attributes all to ENIP dissector.

Bug: 11996
Change-Id: I7f50c9aadf04efdb17ef31f39e6a991c0a84bef2
Reviewed-on: https://code.wireshark.org/review/13186
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  db111c4   ISAKMP: Optimize loops
adds  fc511c3   CIP: Add support for Get Attributes All


Summary of changes:
 epan/dissectors/packet-cip.c   |  331 +++-
 epan/dissectors/packet-cip.h   |   35 +++-
 epan/dissectors/packet-cipsafety.c |  139 ++-
 epan/dissectors/packet-cipsafety.h |2 +-
 epan/dissectors/packet-enip.c  |  187 ++--
 epan/dissectors/packet-enip.h  |2 +-
 6 files changed, 473 insertions(+), 223 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master db111c4: ISAKMP: Optimize loops

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db111c4d9063bf145778ef41b139a6b9fdc0114c
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

db111c4 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

ISAKMP: Optimize loops

Change-Id: I2e7ae0c3d8cba4255dd725db39a02be8ecce94d8
Reviewed-on: https://code.wireshark.org/review/13469
Reviewed-by: João Valverde 
Petri-Dish: João Valverde 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  9f5a060   NFSv4.1 bugfixes
adds  db111c4   ISAKMP: Optimize loops


Summary of changes:
 epan/dissectors/packet-isakmp.c |   84 ---
 1 file changed, 26 insertions(+), 58 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/10001

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] db111c4d9063bf145778ef41b139a6b9fdc0114c
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3d570b5: Fix handling of the magic number.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d570b5a39f868209e4b38c43b0ba6bfefe8a9bf
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

3d570b5 by Guy Harris (g...@alum.mit.edu):

Fix handling of the magic number.

Just treat it as an array of bytes.  When checking for whether it's a
pcap file, also determine whether it's big-endian or little-endian.
Note that reading it in *host* byte order will tell you whether it's in
your byte order or byte-swapped; you have to know your byte order to
know whether that means little-endian or big-endian.

Have a #define for the magic number size, as all magic number values
must be that size, and use that as the size of the magic-number arrays.

Handle nanosecond timestamp resolution while we're at it.

Change-Id: I4d83579d919ae9f15888afca14317631d413ca51
Reviewed-on: https://code.wireshark.org/review/13490
Reviewed-by: Guy Harris 


Actions performed:

from  9b8f526   That warning is bogus; squelch it with an 
otherwise-unnecessary cast.
adds  3d570b5   Fix handling of the magic number.


Summary of changes:
 epan/dissectors/file-pcap.c |   67 ---
 1 file changed, 44 insertions(+), 23 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c260640: ISAKMP: Try to really fix implicit conversion warning on OSX 64 bit.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c2606407526080b56a21c9a2fb3c07daea0dc808
Submitter: João Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

c260640 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

ISAKMP: Try to really fix implicit conversion warning on OSX 64 bit.

Change-Id: I2cfb58fdd076a474946c3a51e522307f103d9319
Reviewed-on: https://code.wireshark.org/review/13480
Reviewed-by: João Valverde 


Actions performed:

from  cadae1c   ISAKMP: Fix implicit conversion to shorter type.
adds  c260640   ISAKMP: Try to really fix implicit conversion warning on 
OSX 64 bit.


Summary of changes:
 epan/dissectors/packet-isakmp.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9141bd9: Add more fields to packet_info structure and use them.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9141bd97001e4a728c88b2bc7507a2f8bd91cc90
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

9141bd9 by Guy Harris (g...@alum.mit.edu):

Add more fields to packet_info structure and use them.

Add fields for the absolute time stamp (and another field for a presence
flag for the absolute time stamp) and the packet encapsulation for the
packet.

This lets us remove the field for the packet encapsulation in the
frame_data structure; do so.

Change-Id: Ifb910a9a192414e2a53086f3f7b97f39ed36aa39
Reviewed-on: https://code.wireshark.org/review/13499
Reviewed-by: Guy Harris 


Actions performed:

from  2fb43f3   Use structure assignment for nstime_t.
adds  9141bd9   Add more fields to packet_info structure and use them.


Summary of changes:
 epan/dissectors/file-btsnoop.c  |6 ++--
 epan/dissectors/file-file.c |6 ++--
 epan/dissectors/file-pcap.c |2 +-
 epan/dissectors/file-pcapng.c   |2 +-
 epan/dissectors/packet-adwin.c  |6 ++--
 epan/dissectors/packet-afp.c|4 +--
 epan/dissectors/packet-afs.c|4 +--
 epan/dissectors/packet-aoe.c|4 +--
 epan/dissectors/packet-arp.c|   14 
 epan/dissectors/packet-bluetooth.c  |2 +-
 epan/dissectors/packet-btavdtp.c|   10 +++---
 epan/dissectors/packet-btavrcp.c|4 +--
 epan/dissectors/packet-bthci_cmd.c  |6 ++--
 epan/dissectors/packet-bthci_evt.c  |6 ++--
 epan/dissectors/packet-bthsp.c  |2 +-
 epan/dissectors/packet-camel.c  |6 ++--
 epan/dissectors/packet-classicstun.c|6 ++--
 epan/dissectors/packet-cops.c   |6 ++--
 epan/dissectors/packet-ctdb.c   |8 ++---
 epan/dissectors/packet-dcerpc.c |   12 +++
 epan/dissectors/packet-diameter.c   |6 ++--
 epan/dissectors/packet-dji-uav.c|4 +--
 epan/dissectors/packet-dmp.c|   20 +--
 epan/dissectors/packet-dns.c|6 ++--
 epan/dissectors/packet-enip.c   |4 +--
 epan/dissectors/packet-eth.c|2 +-
 epan/dissectors/packet-fc.c |8 ++---
 epan/dissectors/packet-fcp.c|   10 +++---
 epan/dissectors/packet-fddi.c   |2 +-
 epan/dissectors/packet-finger.c |6 ++--
 epan/dissectors/packet-frame.c  |   24 ++---
 epan/dissectors/packet-gadu-gadu.c  |4 +--
 epan/dissectors/packet-gtp.c|4 +--
 epan/dissectors/packet-gtpv2.c  |2 +-
 epan/dissectors/packet-h225.c   |   10 +++---
 epan/dissectors/packet-http.c   |4 +--
 epan/dissectors/packet-iax2.c   |6 ++--
 epan/dissectors/packet-icmp.c   |   14 
 epan/dissectors/packet-icmpv6.c |4 +--
 epan/dissectors/packet-ieee80211.c  |2 +-
 epan/dissectors/packet-ip.c |2 +-
 epan/dissectors/packet-ipmi.c   |6 ++--
 epan/dissectors/packet-ipv6.c   |2 +-
 epan/dissectors/packet-ipx.c|2 +-
 epan/dissectors/packet-iscsi.c  |8 ++---
 epan/dissectors/packet-lapd.c   |2 +-
 epan/dissectors/packet-ldap.c   |4 +--
 epan/dissectors/packet-ldss.c   |6 ++--
 epan/dissectors/packet-mac-lte.c|   36 ++--
 epan/dissectors/packet-megaco.c |2 +-
 epan/dissectors/packet-mgcp.c   |6 ++--
 epan/dissectors/packet-nbd.c|6 ++--
 epan/dissectors/packet-ncp.c|2 +-
 epan/dissectors/packet-ndmp.c   |6 ++--
 epan/dissectors/packet-nettl.c  |2 +-
 epan/dissectors/packet-nlm.c|4 +--
 epan/dissectors/packet-p_mul.c  |   24 ++---
 epan/dissectors/packet-pana.c   |6 ++--
 epan/dissectors/packet-radius.c |   10 +++---
 epan/dissectors/packet-reload-framing.c |6 ++--
 epan/dissectors/packet-reload.c |6 ++--
 epan/dissectors/packet-rlc-lte.c|2 +-
 epan/dissectors/packet-rlc.c|4 +--
 epan/dissectors/packet-ros.c|4 +--
 epan/dissectors/packet-rpc.c|8 ++---
 epan/dissectors/packet-rsvd.c   |2 +-
 epan/dissectors/packet-rsvp.c   |2 +-
 epan/dissectors/packet-rtcp.c   |6 ++--
 epan/dissectors/packet-rtitcp.c |6 ++--
 epan/dissectors/packet-rtnet.c  |2 +-
 epan/dissectors/packet-rtpproxy.c   |4 +--
 epan/dissectors/packet-sbc.c|4 +--
 epan/dissectors/packet-sbus.c   |   10 +++---
 epan/dissectors/packet-scsi.c   |2 +-
 epan/dissectors/packet-sctp.c   |   12 +++
 epan/dissectors/packet-sip.c|   12 +++
 

[Wireshark-commits] master 21ac67c: Fix template files to refer directly to pinfo->abs_ts.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21ac67cf3dc89f7626f565419507a08608bc444f
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

21ac67c by Guy Harris (g...@alum.mit.edu):

Fix template files to refer directly to pinfo->abs_ts.

Change-Id: I10ac1ee42ba17d3faf3d76f9d4d7fe8cba8043bc
Reviewed-on: https://code.wireshark.org/review/13500
Reviewed-by: Guy Harris 


Actions performed:

from  9141bd9   Add more fields to packet_info structure and use them.
adds  21ac67c   Fix template files to refer directly to pinfo->abs_ts.


Summary of changes:
 asn1/camel/packet-camel-template.c |6 +++---
 asn1/h225/packet-h225-template.c   |   10 +-
 asn1/ldap/packet-ldap-template.c   |4 ++--
 asn1/ros/packet-ros-template.c |4 ++--
 asn1/tcap/packet-tcap-template.c   |   22 +++---
 5 files changed, 23 insertions(+), 23 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a7f470f: More pinfo->fd->abs_ts to pinfo->abs_ts.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7f470fa2476459c2013f0ee3ffe09f94fb036c2
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

a7f470f by Guy Harris (g...@alum.mit.edu):

More pinfo->fd->abs_ts to pinfo->abs_ts.

Change-Id: I70db0a345cc4c5c57c454371deb4f92f9ac4b9ac
Reviewed-on: https://code.wireshark.org/review/13501
Reviewed-by: Guy Harris 


Actions performed:

from  21ac67c   Fix template files to refer directly to pinfo->abs_ts.
adds  a7f470f   More pinfo->fd->abs_ts to pinfo->abs_ts.


Summary of changes:
 epan/gcp.c   |2 +-
 epan/srt_table.c |2 +-
 epan/wslua/wslua_pinfo.c |2 +-
 plugins/ethercat/packet-esl.c|6 ++---
 ui/cli/tap-comparestat.c |2 +-
 ui/cli/tap-diameter-avp.c|4 ++--
 ui/cli/tap-iostat.c  |2 +-
 ui/cli/tap-rpcprogs.c|2 +-
 ui/gtk/compare_stat.c|2 +-
 ui/gtk/iax2_analysis.c   |4 ++--
 ui/gtk/io_stat.c |2 +-
 ui/gtk/rtp_analysis.c|4 ++--
 ui/mcast_stream.c|2 +-
 ui/qt/io_graph_dialog.cpp|2 +-
 ui/qt/lbm_lbtrm_transport_dialog.cpp |   40 +-
 ui/qt/lbm_lbtru_transport_dialog.cpp |   40 +-
 ui/qt/rtp_audio_stream.cpp   |2 +-
 ui/tap-rlc-graph.c   |4 ++--
 ui/tap-rtp-common.c  |2 +-
 ui/tap-tcp-stream.c  |4 ++--
 ui/tap_export_pdu.c  |4 ++--
 ui/voip_calls.c  |2 +-
 22 files changed, 68 insertions(+), 68 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e119532: Set the pinfo time stamps based on the frame_data time stamps.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e119532e11e5514ee7a397b80ef8edc4372b2406
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e119532 by Guy Harris (g...@alum.mit.edu):

Set the pinfo time stamps based on the frame_data time stamps.

That takes into account any time-shifting that's been done.

Change-Id: Ib4c01e7b055f5ac2fbcbe946c6094dcb70ae
Reviewed-on: https://code.wireshark.org/review/13502
Reviewed-by: Guy Harris 


Actions performed:

from  a7f470f   More pinfo->fd->abs_ts to pinfo->abs_ts.
adds  e119532   Set the pinfo time stamps based on the frame_data time 
stamps.


Summary of changes:
 epan/packet.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f3713e2: Avoid inhaling fumes. Do not use near open flame.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f3713e288b018cf2e9711b2dc2caaba87896bc02
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

f3713e2 by Guy Harris (g...@alum.mit.edu):

Avoid inhaling fumes.  Do not use near open flame.

Change-Id: I9040745b2878a9ba8a0677e19af6702c2a766ce2
Reviewed-on: https://code.wireshark.org/review/13496
Reviewed-by: Guy Harris 


Actions performed:

from  e406703   Fix handling of the byte order magic number.
adds  f3713e2   Avoid inhaling fumes.  Do not use near open flame.


Summary of changes:
 epan/dissectors/file-pcap.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 000de3c: Avoid inhaling fumes. Do not use near open flame.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=000de3cd5771b167d1d366de47fc86caa4ba5b35
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

000de3c by Guy Harris (g...@alum.mit.edu):

Avoid inhaling fumes.  Do not use near open flame.

Change-Id: I9040745b2878a9ba8a0677e19af6702c2a766ce2
Reviewed-on: https://code.wireshark.org/review/13496
Reviewed-by: Guy Harris 
(cherry picked from commit f3713e288b018cf2e9711b2dc2caaba87896bc02)
Reviewed-on: https://code.wireshark.org/review/13497


Actions performed:

from  c8eac6b   Fix handling of the byte order magic number.
adds  000de3c   Avoid inhaling fumes.  Do not use near open flame.


Summary of changes:
 epan/dissectors/file-pcap.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2fb43f3: Use structure assignment for nstime_t.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2fb43f3761f3bc813d85f3771b78a81007283871
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

2fb43f3 by Guy Harris (g...@alum.mit.edu):

Use structure assignment for nstime_t.

Change-Id: Iab049e7708642a306764d80839bf0d5139889212
Reviewed-on: https://code.wireshark.org/review/13498
Reviewed-by: Guy Harris 


Actions performed:

from  f3713e2   Avoid inhaling fumes.  Do not use near open flame.
adds  2fb43f3   Use structure assignment for nstime_t.


Summary of changes:
 epan/frame_data.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5fecf17: Get rid of now-unused expert info.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5fecf1795ef5365db69527e3b64d2234253cd5cb
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

5fecf17 by Guy Harris (g...@alum.mit.edu):

Get rid of now-unused expert info.

(If the magic number isn't something we recognize, we don't treat the
file as a pcap file, so it can never be "unknown".)

Change-Id: I7e8bac1ebd2cbfd6d603035428274a1098ff7544
Reviewed-on: https://code.wireshark.org/review/13491
Reviewed-by: Guy Harris 


Actions performed:

from  3d570b5   Fix handling of the magic number.
adds  5fecf17   Get rid of now-unused expert info.


Summary of changes:
 epan/dissectors/file-pcap.c |   10 --
 1 file changed, 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 cf4c9e2: Get rid of now-unused expert info.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf4c9e24c6a7c21fb4cf3e6225a379c05a4936b4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

cf4c9e2 by Guy Harris (g...@alum.mit.edu):

Get rid of now-unused expert info.

(If the magic number isn't something we recognize, we don't treat the
file as a pcap file, so it can never be "unknown".)

Change-Id: I7e8bac1ebd2cbfd6d603035428274a1098ff7544
Reviewed-on: https://code.wireshark.org/review/13491
Reviewed-by: Guy Harris 
(cherry picked from commit 5fecf1795ef5365db69527e3b64d2234253cd5cb)
Reviewed-on: https://code.wireshark.org/review/13493


Actions performed:

from  0551667   Fix handling of the magic number.
adds  cf4c9e2   Get rid of now-unused expert info.


Summary of changes:
 epan/dissectors/file-pcap.c |   10 --
 1 file changed, 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 0551667: Fix handling of the magic number.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0551667b1938759ba194179557f25cf2ec8f23b1
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0551667 by Guy Harris (g...@alum.mit.edu):

Fix handling of the magic number.

Just treat it as an array of bytes.  When checking for whether it's a
pcap file, also determine whether it's big-endian or little-endian.
Note that reading it in *host* byte order will tell you whether it's in
your byte order or byte-swapped; you have to know your byte order to
know whether that means little-endian or big-endian.

Have a #define for the magic number size, as all magic number values
must be that size, and use that as the size of the magic-number arrays.

Handle nanosecond timestamp resolution while we're at it.

Change-Id: Ia11b8be18892f2cc056c88fcdefe461dfd16818a
Reviewed-on: https://code.wireshark.org/review/13492
Reviewed-by: Guy Harris 


Actions performed:

from  b36dbfb   GSM A DTAP: fix display of calling/called party BCD number 
in parent tree
adds  0551667   Fix handling of the magic number.


Summary of changes:
 epan/dissectors/file-pcap.c |   67 ---
 1 file changed, 44 insertions(+), 23 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e406703: Fix handling of the byte order magic number.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e406703c5f8d341153e0b91cc16638c3a556ae49
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

e406703 by Guy Harris (g...@alum.mit.edu):

Fix handling of the byte order magic number.

Just treat it as an array of bytes.  When checking for whether it's a
pcapng file, also determine whether it's big-endian or little-endian.
Note that reading it in *host* byte order will tell you whether it's in
your byte order or byte-swapped; you have to know your byte order to
know whether that means little-endian or big-endian.

Have a #define for the byte-order magic number size, as all byte order
magic number values must be that size, and use that as the size of the
magic-number arrays.

Also use a #define for the SHB block type magic number.

Get rid of a now-unused expert info.  (If the magic number isn't
something we recognize, we don't treat the file as a pcap file, so it
can never be "unknown".)

Change-Id: Ic74cceac17d1490eb70a28f67cb4dbb512e031ac
Reviewed-on: https://code.wireshark.org/review/13494
Reviewed-by: Guy Harris 


Actions performed:

from  5fecf17   Get rid of now-unused expert info.
adds  e406703   Fix handling of the byte order magic number.


Summary of changes:
 epan/dissectors/file-pcapng.c |   54 -
 1 file changed, 26 insertions(+), 28 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 c8eac6b: Fix handling of the byte order magic number.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8eac6b3d8a391948aa17c10da26264eb55d4bb5
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

c8eac6b by Guy Harris (g...@alum.mit.edu):

Fix handling of the byte order magic number.

Just treat it as an array of bytes.  When checking for whether it's a
pcapng file, also determine whether it's big-endian or little-endian.
Note that reading it in *host* byte order will tell you whether it's in
your byte order or byte-swapped; you have to know your byte order to
know whether that means little-endian or big-endian.

Have a #define for the byte-order magic number size, as all byte order
magic number values must be that size, and use that as the size of the
magic-number arrays.

Also use a #define for the SHB block type magic number.

Get rid of a now-unused expert info.  (If the magic number isn't
something we recognize, we don't treat the file as a pcap file, so it
can never be "unknown".)

Change-Id: Ic74cceac17d1490eb70a28f67cb4dbb512e031ac
Reviewed-on: https://code.wireshark.org/review/13494
Reviewed-by: Guy Harris 
(cherry picked from commit e406703c5f8d341153e0b91cc16638c3a556ae49)
Reviewed-on: https://code.wireshark.org/review/13495


Actions performed:

from  cf4c9e2   Get rid of now-unused expert info.
adds  c8eac6b   Fix handling of the byte order magic number.


Summary of changes:
 epan/dissectors/file-pcapng.c |   54 -
 1 file changed, 26 insertions(+), 28 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 14.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2014.04%20x64/builds/5299

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-14.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 3d570b5a39f868209e4b38c43b0ba6bfefe8a9bf
Blamelist: Guy Harris 

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe