[Wireshark-commits] master 2858871: FC: Forget about MDS when dealing with ETHERTYPE_BRDWALK (CID 280012)

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2858871aacd13120cedc9ef93474d06a50a79cff
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2858871 by Jaap Keuter (jaap.keu...@xs4all.nl):

FC: Forget about MDS when dealing with ETHERTYPE_BRDWALK (CID 280012)

Since the MDS trailer is smaller anyway, no need to copy that code.

Change-Id: Ie3931cda3ef2386526cd81daee535d106e522875
Reviewed-on: https://code.wireshark.org/review/14253
Reviewed-by: Alexis La Goutte 


Actions performed:

from  c3b84af   Update the current XZ version.
adds  2858871   FC: Forget about MDS when dealing with ETHERTYPE_BRDWALK 
(CID 280012)


Summary of changes:
 epan/dissectors/packet-fc.c |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 09f0eac: Update PNG_VERSION to the only version that actually exists. At least with Qt5.5.1 there is no duplicate clang_64 in the qt path.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=09f0eac24aed61dfc6bfb9c17bc5fa959fd5e66e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

09f0eac by Joerg Mayer (jma...@loplof.de):

Update PNG_VERSION to the only version that actually exists.
At least with Qt5.5.1 there is no duplicate clang_64 in the qt path.

Change-Id: I2ac66f246b3c9dbe2155ee8394d31e7d560faaf9
Reviewed-on: https://code.wireshark.org/review/13000
Reviewed-by: Jörg Mayer 
(cherry picked from commit 945251627e76fbb54083e879610c5303c0470817)
Reviewed-on: https://code.wireshark.org/review/14260
Reviewed-by: Guy Harris 


Actions performed:

from  2cd1c4d   CMake updates - make CMAKE_VERSION configurable via 
environment variable - Fix download URL (no www. and httpS)
adds  09f0eac   Update PNG_VERSION to the only version that actually 
exists. At least with Qt5.5.1 there is no duplicate clang_64 in the qt path.


Summary of changes:
 macosx-setup.sh |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 2cd1c4d: CMake updates - make CMAKE_VERSION configurable via environment variable - Fix download URL (no www. and httpS)

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2cd1c4d597737b7a7e421706c9306c24d570ad63
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2cd1c4d by Joerg Mayer (jma...@loplof.de):

CMake updates
- make CMAKE_VERSION configurable via environment variable
- Fix download URL (no www. and httpS)

Change-Id: Id347b2f837d26063d889667f69bb1b4418e8e86d
Reviewed-on: https://code.wireshark.org/review/12934
Reviewed-by: Jörg Mayer 
(cherry picked from commit d1149414de0722d9205d7625ac8c7a1409605d27)
Reviewed-on: https://code.wireshark.org/review/14259
Reviewed-by: Guy Harris 


Actions performed:

from  3f9979c   Update the current XZ version.
adds  2cd1c4d   CMake updates - make CMAKE_VERSION configurable via 
environment variable - Fix download URL (no www. and httpS)


Summary of changes:
 macosx-setup.sh |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 3f9979c: Update the current XZ version.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f9979cea8d66f45f3c945f4d1ddc18a9b3ed409
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3f9979c by Guy Harris (g...@alum.mit.edu):

Update the current XZ version.

5.0.4 is no longer available; the current version is 5.0.8.

Change-Id: I982a4809ae87362837561297967a8eb63485676c
Ping-Bug: 12214
Reviewed-on: https://code.wireshark.org/review/14257
Reviewed-by: Guy Harris 
(cherry picked from commit c3b84afa1e9656db2d50f975da5f4d18b021b865)
Reviewed-on: https://code.wireshark.org/review/14258


Actions performed:

from  9b545ef   Don't show a progress bar when previewing for the Qt print 
dialog.
adds  3f9979c   Update the current XZ version.


Summary of changes:
 macosx-setup.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c3b84af: Update the current XZ version.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3b84afa1e9656db2d50f975da5f4d18b021b865
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

c3b84af by Guy Harris (g...@alum.mit.edu):

Update the current XZ version.

5.0.4 is no longer available; the current version is 5.0.8.

Change-Id: I982a4809ae87362837561297967a8eb63485676c
Ping-Bug: 12214
Reviewed-on: https://code.wireshark.org/review/14257
Reviewed-by: Guy Harris 


Actions performed:

from  68dede2   IrDA: Register a link-layer IrLAP address type".
adds  c3b84af   Update the current XZ version.


Summary of changes:
 macosx-setup.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 68dede2: IrDA: Register a link-layer IrLAP address type".

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68dede24d17f5f51096b62bc2dc76cb72b4136f8
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

68dede2 by Michael Mann (mman...@netscape.net):

IrDA: Register a link-layer IrLAP address type".

Was using AT_NONE as "unknown address type" instead of "no address".

Ping-Bug: 12205
Change-Id: Ic1d7022f8eaa3dfab9bb7b607eed264cc527c87c
Reviewed-on: https://code.wireshark.org/review/14242
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  c73cf3c   Don't show a progress bar when previewing for the Qt print 
dialog.
adds  68dede2   IrDA: Register a link-layer IrLAP address type".


Summary of changes:
 plugins/irda/packet-irda.c |   46 
 1 file changed, 38 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c73cf3c: Don't show a progress bar when previewing for the Qt print dialog.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c73cf3cd00c1fb144e67ef79ea55be41993b79be
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

c73cf3c by Guy Harris (g...@alum.mit.edu):

Don't show a progress bar when previewing for the Qt print dialog.

We don't do much work to do that - we don't print anything before the
first selected page, and once we're finished generating that page, we
terminate the printing process - so it shouldn't need a progress bar.
(If it needs a progress bar, We Have A Problem, as that slows down the
drawing of the dialog box.)

This should prevent the problem seen in bug 12040.

Bug: 12040
Change-Id: I129191e06fff3e1eb59a9631c7395b9e7f650809
Reviewed-on: https://code.wireshark.org/review/14255
Reviewed-by: Guy Harris 


Actions performed:

from  c0b29fc   Add a #define for the wildcard pattern that matches all 
files.
adds  c73cf3c   Don't show a progress bar when previewing for the Qt print 
dialog.


Summary of changes:
 file.c |   28 +++-
 file.h |4 +++-
 ui/gtk/print_dlg.c |2 +-
 ui/qt/export_dissection_dialog.cpp |2 +-
 ui/qt/print_dialog.cpp |   14 --
 ui/win32/file_dlg_win32.c  |4 ++--
 6 files changed, 30 insertions(+), 24 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 9b545ef: Don't show a progress bar when previewing for the Qt print dialog.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b545efa43ecc2d52aa560046f5418fe1521c867
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9b545ef by Guy Harris (g...@alum.mit.edu):

Don't show a progress bar when previewing for the Qt print dialog.

We don't do much work to do that - we don't print anything before the
first selected page, and once we're finished generating that page, we
terminate the printing process - so it shouldn't need a progress bar.
(If it needs a progress bar, We Have A Problem, as that slows down the
drawing of the dialog box.)

This should prevent the problem seen in bug 12040.

Bug: 12040
Change-Id: I129191e06fff3e1eb59a9631c7395b9e7f650809
Reviewed-on: https://code.wireshark.org/review/14255
Reviewed-by: Guy Harris 
(cherry picked from commit c73cf3cd00c1fb144e67ef79ea55be41993b79be)
Reviewed-on: https://code.wireshark.org/review/14256


Actions performed:

from  6a83965   Add a #define for the wildcard pattern that matches all 
files.
adds  9b545ef   Don't show a progress bar when previewing for the Qt print 
dialog.


Summary of changes:
 file.c |   28 +++-
 file.h |4 +++-
 ui/gtk/print_dlg.c |2 +-
 ui/qt/export_dissection_dialog.cpp |2 +-
 ui/qt/print_dialog.cpp |   14 --
 ui/win32/file_dlg_win32.c  |4 ++--
 6 files changed, 30 insertions(+), 24 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 6a83965: Add a #define for the wildcard pattern that matches all files.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a839658839edd29467347524618c14edfbf6fb0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6a83965 by Guy Harris (g...@alum.mit.edu):

Add a #define for the wildcard pattern that matches all files.

It's *.* on Windows, but just * on UN*X; add a header that provides the
definition, and use it instead of hardwiring *.*.

Call the entry "All Files", that being the conventional name, rather
than "Any File", whilst we're at it.

Change-Id: I6048e9f187af4b2cf5f0d87fc48e76afd91ff8b8
Reviewed-on: https://code.wireshark.org/review/14254
Reviewed-by: Guy Harris 


Actions performed:

from  2b00a28   Bump so version of libwireshark for have_field_extractors 
symbol added in 2.0.2
adds  6a83965   Add a #define for the wildcard pattern that matches all 
files.


Summary of changes:
 ui/Makefile.common |1 +
 ui/{console.h => all_files_wildcard.h} |   39 +++-
 ui/qt/capture_file_dialog.cpp  |   16 ++---
 ui/qt/extcap_argument_file.cpp |4 +++-
 ui/qt/main_window_slots.cpp|5 ++--
 ui/win32/file_dlg_win32.c  |   25 ++--
 6 files changed, 44 insertions(+), 46 deletions(-)
 copy ui/{console.h => all_files_wildcard.h} (66%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c0b29fc: Add a #define for the wildcard pattern that matches all files.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0b29fcddd6eb9c7956ff63836a71a1d90169daa
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

c0b29fc by Guy Harris (g...@alum.mit.edu):

Add a #define for the wildcard pattern that matches all files.

It's *.* on Windows, but just * on UN*X; add a header that provides the
definition, and use it instead of hardwiring *.*.

Call the entry "All Files", that being the conventional name, rather
than "Any File", whilst we're at it.

Change-Id: I7c29324fc5b41e93c150e1ec67f1529f171dc6a3
Reviewed-on: https://code.wireshark.org/review/14243
Reviewed-by: Guy Harris 


Actions performed:

from  be3af7c   802.15.4 Minimal support for MLME Payload IE with Enhanced 
Beacon Filter IE
adds  c0b29fc   Add a #define for the wildcard pattern that matches all 
files.


Summary of changes:
 ui/Makefile.common |1 +
 ui/{console.h => all_files_wildcard.h} |   39 +++-
 ui/qt/capture_file_dialog.cpp  |   16 ++---
 ui/qt/extcap_argument_file.cpp |4 +++-
 ui/qt/main_window_slots.cpp|5 ++--
 ui/win32/file_dlg_win32.c  |   25 ++--
 6 files changed, 44 insertions(+), 46 deletions(-)
 copy ui/{console.h => all_files_wildcard.h} (66%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master be3af7c: 802.15.4 Minimal support for MLME Payload IE with Enhanced Beacon Filter IE

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be3af7c9643d502e4d2a9f2aa20ff2f3dc1fa75a
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

be3af7c by Chris Brandson (chris.brand...@gmail.com):

802.15.4 Minimal support for MLME Payload IE with Enhanced Beacon Filter IE

Minimal support has been added for the MLME Payload IE and the Enhanced 
Beacon
Filter Sub-IE. Dissection of Payload IEs and Sub-IEs is supported making it
easy to add dissection for specific applications once this is known.

Change-Id: I3a4f237e17413ec3e7bbfd32ded0625fc97da11b
Reviewed-on: https://code.wireshark.org/review/13999
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  d679d11   make-version: Don't emit one common warning to stderr
adds  be3af7c   802.15.4 Minimal support for MLME Payload IE with Enhanced 
Beacon Filter IE


Summary of changes:
 epan/dissectors/packet-ieee802154.c |  382 ---
 epan/dissectors/packet-ieee802154.h |   71 +++
 2 files changed, 423 insertions(+), 30 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-02-29 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/10384

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] d679d1137d884e651b214d8b6e3fb8af2972ad46
Blamelist: João Valverde 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d679d11: make-version: Don't emit one common warning to stderr

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d679d1137d884e651b214d8b6e3fb8af2972ad46
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

d679d11 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

make-version: Don't emit one common warning to stderr

git rev-parse @{upstream} will (obviously) fail if there is no
upstream set for the current branch. This is fairly common and
not problematic. Don't emit an error message to stderr when it
fails.

Change-Id: I4989fb19b25fefff83335061151e360c78652e88
Reviewed-on: https://code.wireshark.org/review/14151
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: João Valverde 


Actions performed:

from  bf56f28   fuzz-test: Add missing new line
adds  d679d11   make-version: Don't emit one common warning to stderr


Summary of changes:
 make-version.pl |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bf56f28: fuzz-test: Add missing new line

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf56f28e7fa22c86fcf953c8586a5980c3a5e82d
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

bf56f28 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

fuzz-test: Add missing new line

Change-Id: I68f85cdbef24289cabb5e46905356c3cc1c39ad8
Reviewed-on: https://code.wireshark.org/review/14252
Reviewed-by: João Valverde 


Actions performed:

from  53252df   Support dissecting the TLV data format specified for Lwm2m
adds  bf56f28   fuzz-test: Add missing new line


Summary of changes:
 tools/fuzz-test.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] lts-1.8.2 8000c14: RSVP: copy all rsvp_request_key info in file scope

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8000c14035a7bed2232326f4294b5ac24dd20bff
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

8000c14 by Pascal Quantin (pascal.quan...@gmail.com):

RSVP: copy all rsvp_request_key info in file scope

This is needed as it is later used for comparisons in the request hash table

Conflicts:
epan/dissectors/packet-rsvp.c

Bug: 11793
Change-Id: I2ee1c894892c6ae88c4eac23237991b547a0983b
Reviewed-on: https://code.wireshark.org/review/12258
Reviewed-by: Michael Mann 
Reviewed-by: Pascal Quantin 
(cherry picked from commit 5d20997a35226fab09b87699fa7e6a30bf26ffd1)
Reviewed-on: https://code.wireshark.org/review/13765
Reviewed-by: Balint Reczey 
Reviewed-on: https://code.wireshark.org/review/14250


Actions performed:

from  f1ca44a   Fix out-of-bounds read in ascend_seek.
adds  8000c14   RSVP: copy all rsvp_request_key info in file scope


Summary of changes:
 epan/dissectors/packet-rsvp.c |   27 ++-
 1 file changed, 26 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] lts-1.8.2 f1ca44a: Fix out-of-bounds read in ascend_seek.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1ca44a1f9bcb7692ea1088a4c4ed408dc3b20ed
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

f1ca44a by Michael Mann (mman...@netscape.net):

Fix out-of-bounds read in ascend_seek.

Bug: 11794
Change-Id: I74517806b119729ae6d9780bbd4bb094701ff05e
Reviewed-on: https://code.wireshark.org/review/12266
Petri-Dish: Michael Mann 
Reviewed-by: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 338da1c0ea0b2f8595d3a7b6d6c9548f7da3e27b)
Reviewed-on: https://code.wireshark.org/review/12296
(cherry picked from commit 7abfa36686850a0d81ef1ef280a181d09e5e639c)
Reviewed-on: https://code.wireshark.org/review/12297
(cherry picked from commit 9cf09cf777cb5478d470436278db45ab42d84e06)
Reviewed-on: https://code.wireshark.org/review/13768
Reviewed-by: Balint Reczey 
(cherry picked from commit 38ede4e33b373ff5ff0aed2237ec0695d7c731b9)
Reviewed-on: https://code.wireshark.org/review/14245


Actions performed:

from  32e3f8d   DCOM: ensure to initialize IPv4 variable put on the stack
adds  f1ca44a   Fix out-of-bounds read in ascend_seek.


Summary of changes:
 wiretap/ascendtext.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] lts-1.8.2 32e3f8d: DCOM: ensure to initialize IPv4 variable put on the stack

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32e3f8d00f962654e36ef96325eda9c652bf435e
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

32e3f8d by Pascal Quantin (pascal.quan...@gmail.com):

DCOM: ensure to initialize IPv4 variable put on the stack

Bug: 11610
Change-Id: I920b88ab035ff34e7cff9eab8158aa2dabe2faac
Reviewed-on: https://code.wireshark.org/review/11134
Reviewed-by: Martin Kaiser 
(cherry picked from commit d34267d0503a67235bf259fd2f2f2d2bb8b18cf5)
Reviewed-on: https://code.wireshark.org/review/11136
Reviewed-by: Pascal Quantin 
(cherry picked from commit af920d25e2477b07c89cadcf913cd8d529bc0e71)
Reviewed-on: https://code.wireshark.org/review/13750
Reviewed-by: Balint Reczey 
(cherry picked from commit 47c80e6938657b1a45fde4fc67b211c396a98685)
Reviewed-on: https://code.wireshark.org/review/14244


Actions performed:

from  e0c9f25   WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to 
walk a packet and protect against a really big tag value
adds  32e3f8d   DCOM: ensure to initialize IPv4 variable put on the stack


Summary of changes:
 epan/dissectors/packet-dcom.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 53252df: Support dissecting the TLV data format specified for Lwm2m

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=53252df9204629b35ea9fef9b800bfc5bb1bdac6
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

53252df by Christoph Burger-Scheidlin (m...@christoph.burger-scheidlin.name):

Support dissecting the TLV data format specified for Lwm2m

Lightweight M2M is a protocol on top of CoAP that is used for
device management. The specification contains a custom payload
format - a simple type, length, value binary encoding.

This patch adds support for dissecting this payload format.
While not yet officially registered, the main open source
implementation of the lwm2m protocol - eclipse's leshan - uses this
content type 1542 for its messages.

Bug: 12110
Change-Id: Ib022d1f485c706f1d69ceec7200790448d080965
Reviewed-on: https://code.wireshark.org/review/13835
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  8ff3d1b   PIDL: regen pidl-generated dissectors
adds  53252df   Support dissecting the TLV data format specified for Lwm2m


Summary of changes:
 docbook/release-notes.asciidoc|1 +
 epan/CMakeLists.txt   |1 +
 epan/dissectors/Makefile.common   |1 +
 epan/dissectors/packet-coap.c |1 +
 epan/dissectors/packet-lwm2mtlv.c |  430 +
 5 files changed, 434 insertions(+)
 create mode 100644 epan/dissectors/packet-lwm2mtlv.c
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 8ff3d1b: PIDL: regen pidl-generated dissectors

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ff3d1bd75588b8829797d603df946545cb730e7
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

8ff3d1b by Aurelien Aptel (aap...@suse.com):

PIDL: regen pidl-generated dissectors

mapi dissectors skipped on purpose since they the output is
malformed. This was already the case before the samba sync.

Change-Id: Ib3b78459e3506c755aaa219433ac6b5865482f01
Signed-off-by: Aurelien Aptel 
Reviewed-on: https://code.wireshark.org/review/13968
Reviewed-by: Alexis La Goutte 


Actions performed:

from  62a0ebf   PIDL: sync pidl with samba repo
adds  8ff3d1b   PIDL: regen pidl-generated dissectors


Summary of changes:
 epan/dissectors/packet-dcerpc-atsvc.c |   12 +-
 epan/dissectors/packet-dcerpc-dfs.c   |  111 +++-
 epan/dissectors/packet-dcerpc-dnsserver.c |   27 +--
 epan/dissectors/packet-dcerpc-dssetup.c   |   12 +-
 epan/dissectors/packet-dcerpc-efs.c   |   20 +--
 epan/dissectors/packet-dcerpc-eventlog.c  |   12 +-
 epan/dissectors/packet-dcerpc-frsrpc.c|   31 +---
 epan/dissectors/packet-dcerpc-frstrans.c  |   40 ++---
 epan/dissectors/packet-dcerpc-lsa.c   |  239 +++---
 epan/dissectors/packet-dcerpc-mdssvc.c|4 +-
 epan/dissectors/packet-dcerpc-misc.c  |   16 +-
 epan/dissectors/packet-dcerpc-rfr.c   |2 +-
 epan/dissectors/packet-dcerpc-rfr.h   |2 +-
 epan/dissectors/packet-dcerpc-samr.c  |  262 -
 epan/dissectors/packet-dcerpc-winreg.c|   28 +--
 epan/dissectors/packet-dcerpc-witness.c   |8 +-
 epan/dissectors/packet-dcerpc-witness.h   |2 +-
 17 files changed, 210 insertions(+), 618 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 62a0ebf: PIDL: sync pidl with samba repo

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62a0ebf1e0aaee058532e6d324b18be5f6715ede
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

62a0ebf by Aurelien Aptel (aap...@suse.com):

PIDL: sync pidl with samba repo

Copy pidl from samba repo after all wireshark changes were applied.

Change-Id: I0d3fb780c3f79b3b873304bab0655d98564dfc71
Signed-off-by: Aurelien Aptel 
Reviewed-on: https://code.wireshark.org/review/13967
Reviewed-by: Alexis La Goutte 


Actions performed:

from  82057fb   Update mailmap with another of my email addresses.
adds  62a0ebf   PIDL: sync pidl with samba repo


Summary of changes:
 tools/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm  |   13 +-
 tools/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm  |   52 +++--
 tools/pidl/lib/Parse/Pidl/Samba4/NDR/Client.pm |   11 +-
 tools/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm |   66 --
 tools/pidl/lib/Parse/Pidl/Samba4/NDR/Server.pm |1 +
 tools/pidl/lib/Parse/Pidl/Samba4/Python.pm |  276 +++-
 tools/pidl/lib/Parse/Pidl/Samba4/Template.pm   |   27 ++-
 tools/pidl/lib/Parse/Pidl/Typelist.pm  |2 +-
 tools/pidl/lib/Parse/Pidl/Util.pm  |   16 +-
 tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm |5 -
 tools/pidl/pidl|   35 +--
 tools/pidl/wscript |5 +-
 12 files changed, 365 insertions(+), 144 deletions(-)
 mode change 100755 => 100644 tools/pidl/lib/wscript_build
 mode change 100755 => 100644 tools/pidl/wscript
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 82057fb: Update mailmap with another of my email addresses.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82057fbedf1622726581785de684ca81e9c9ec17
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

82057fb by Jeff Morriss (jeff.morriss...@gmail.com):

Update mailmap with another of my email addresses.

Change-Id: I9de850dff753988ab3322f0e5885df83625e5a48
Reviewed-on: https://code.wireshark.org/review/14240
Reviewed-by: Alexis La Goutte 


Actions performed:

from  3771a79   Fix randpktdump build in Windows.
adds  82057fb   Update mailmap with another of my email addresses.


Summary of changes:
 .mailmap |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3771a79: Fix randpktdump build in Windows.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3771a790b7b9ffccfa15130f15ebe2da966edfeb
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

3771a79 by Michael Mann (mman...@netscape.net):

Fix randpktdump build in Windows.

Change-Id: If749635d771443542285a74f05f37156123b2991
Reviewed-on: https://code.wireshark.org/review/14238
Reviewed-by: Michael Mann 


Actions performed:

from  a4e2263   extcap: Move extcap handling to base
adds  3771a79   Fix randpktdump build in Windows.


Summary of changes:
 extcap/randpktdump.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a4e2263: extcap: Move extcap handling to base

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4e2263ac4c15c9bfb78444b0b0747cae8022a9c
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

a4e2263 by Roland Knall (roland.kn...@br-automation.com):

extcap: Move extcap handling to base

Also add the extcap-version parameter to enable parsing of
version and helppage separately

Change-Id: I35ba5aa992940ffbb0cd9ebea8b7c3a1e8629d74
Reviewed-on: https://code.wireshark.org/review/14094
Petri-Dish: Roland Knall 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 
Reviewed-by: Roland Knall 


Actions performed:

from  0e5a73f   Only say we have a new resolved MAC address if it's 
actually *new*.
adds  a4e2263   extcap: Move extcap handling to base


Summary of changes:
 CMakeLists.txt   |2 +-
 extcap/androiddump.c |  201 --
 extcap/extcap-base.c |  191 +++
 extcap/extcap-base.h |   65 +++-
 extcap/randpktdump.c |  113 +++-
 extcap/sshdump.c |  123 --
 6 files changed, 375 insertions(+), 320 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 2b00a28: Bump so version of libwireshark for have_field_extractors symbol added in 2.0.2

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2b00a286c859f24b9c72158caf022fb3487ccf62
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2b00a28 by Balint Reczey (bal...@balintreczey.hu):

Bump so version of libwireshark for have_field_extractors symbol added in 
2.0.2

Change-Id: Ib6170f1cd4c4fdae868b008a3cb20a5c843b521b
Reviewed-on: https://code.wireshark.org/review/14235
Petri-Dish: Balint Reczey 
Tested-by: Balint Reczey 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Balint Reczey 


Actions performed:

from  4257f65   Only say we have a new resolved MAC address if it's 
actually *new*.
adds  2b00a28   Bump so version of libwireshark for have_field_extractors 
symbol added in 2.0.2


Summary of changes:
 epan/CMakeLists.txt |2 +-
 epan/Makefile.am|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

2016-02-29 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/653

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 4257f65af2ef08ff83d9cd108209f7b3fdba08e5
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 4257f65: Only say we have a new resolved MAC address if it's actually *new*.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4257f65af2ef08ff83d9cd108209f7b3fdba08e5
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4257f65 by Guy Harris (g...@alum.mit.edu):

Only say we have a new resolved MAC address if it's actually *new*.

If we aren't changing the resolved name, it's not new.

This prevents us from perpetually "resolving" the address.  If we have
ARP packets that cause us to map a MAC address to a host name, based on
the ARP packet saying the MAC address corresponds to a given resolved IP
address, then each time we dissect the packet, the address will be
"resolved" - and each time we have new resolved addresses as a result of
that, we'll redissect the displayed packets so that they show the
resolved address, and we'll forever be redissecting.

Change-Id: I445e92f407d52a4ed5986721ffcc472f86e99431
Reviewed-on: https://code.wireshark.org/review/14236
Reviewed-by: Guy Harris 
(cherry picked from commit 0e5a73fa4e8804c07cf56d6b0e47232ba536621c)
Reviewed-on: https://code.wireshark.org/review/14237


Actions performed:

from  9d1e45a   Use *, not *.*, as the wildcard pattern on UN*X.
adds  4257f65   Only say we have a new resolved MAC address if it's 
actually *new*.


Summary of changes:
 epan/addr_resolv.c |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0e5a73f: Only say we have a new resolved MAC address if it's actually *new*.

2016-02-29 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e5a73fa4e8804c07cf56d6b0e47232ba536621c
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

0e5a73f by Guy Harris (g...@alum.mit.edu):

Only say we have a new resolved MAC address if it's actually *new*.

If we aren't changing the resolved name, it's not new.

This prevents us from perpetually "resolving" the address.  If we have
ARP packets that cause us to map a MAC address to a host name, based on
the ARP packet saying the MAC address corresponds to a given resolved IP
address, then each time we dissect the packet, the address will be
"resolved" - and each time we have new resolved addresses as a result of
that, we'll redissect the displayed packets so that they show the
resolved address, and we'll forever be redissecting.

Change-Id: I445e92f407d52a4ed5986721ffcc472f86e99431
Reviewed-on: https://code.wireshark.org/review/14236
Reviewed-by: Guy Harris 


Actions performed:

from  d5f2db6   DISv7: parse PDU Status field
adds  0e5a73f   Only say we have a new resolved MAC address if it's 
actually *new*.


Summary of changes:
 epan/addr_resolv.c |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe