[Wireshark-commits] master 57f494c: autotools: Don't use AM_PROG_CC_C_O

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57f494c96e498908c327c0712f3d8199d8944f36
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

57f494c by João Valverde (joao.valve...@tecnico.ulisboa.pt):

autotools: Don't use AM_PROG_CC_C_O

Try to fix OSX build after commit g2728f56:

  configure.ac:76: error: AC_PROG_CC cannot be called after AM_PROG_CC_C_O
  aclocal-fallback/ax_prog_cc_for_build.m4:125: AX_PROG_CC_FOR_BUILD is 
expanded from...

Automake manual indicates this macro as obsolescent.

Change-Id: Ia110ad34d65cab91a55b9d57673356d5c4b3bfe3
Reviewed-on: https://code.wireshark.org/review/14403
Reviewed-by: João Valverde 


Actions performed:

from  95951ad   Add the pass number to the fuzz failure report.
adds  57f494c   autotools: Don't use AM_PROG_CC_C_O


Summary of changes:
 configure.ac |1 -
 1 file changed, 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-03-09 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/10470

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 2728f5673fd99f0c634ffe5e72a2eee02526bc00
Blamelist: João Valverde 

BUILD FAILED: failed shell_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 95951ad: Add the pass number to the fuzz failure report.

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95951ad6fa4c90bb9063086830128a137c1515e8
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

95951ad by Gerald Combs (ger...@wireshark.org):

Add the pass number to the fuzz failure report.

When adjusting MAX_PASSES it'd be nice to know how many passes it
normally takes to fail.

Change-Id: I335c26a1e6847371706da880b83773d142797da9
Reviewed-on: https://code.wireshark.org/review/14389
Reviewed-by: Alexis La Goutte 
Reviewed-by: Michael Mann 


Actions performed:

from  cc25153   DNS: Fix handling of the server part of EDNS0 Cookie Option
adds  95951ad   Add the pass number to the fuzz failure report.


Summary of changes:
 tools/test-common.sh |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master cc25153: DNS: Fix handling of the server part of EDNS0 Cookie Option

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc251536fbd195e0484356ff0e24ce5cae4c2806
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

cc25153 by Remi Gacogne (remi.gaco...@powerdns.com):

DNS: Fix handling of the server part of EDNS0 Cookie Option

cur_offset was not incremented for the server part, causing a
"Malformed packet" message.

Change-Id: I21cb876e0d70b1de0cb2f76d37edec4c2ec7c788
Reviewed-on: https://code.wireshark.org/review/14402
Reviewed-by: Michael Mann 


Actions performed:

from  f1d20ec   Add myself to AUTHORS.src
adds  cc25153   DNS: Fix handling of the server part of EDNS0 Cookie Option


Summary of changes:
 epan/dissectors/packet-dns.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master f1d20ec: Add myself to AUTHORS.src

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1d20ec24526c9a74c0c76f0f045490c69276a66
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

f1d20ec by João Valverde (joao.valve...@tecnico.ulisboa.pt):

Add myself to AUTHORS.src

Change-Id: Iaac1e06cbdbe3bdca465283fb28770fe7fdc9b06
Reviewed-on: https://code.wireshark.org/review/14385
Reviewed-by: João Valverde 


Actions performed:

from  2728f56   Use AX_PROG_CC_FOR_BUILD macro to identify compiler 
targeting the build host. (When cross-compiling, this is *not* the compiler 
used to build wireshark itself).
adds  f1d20ec   Add myself to AUTHORS.src


Summary of changes:
 AUTHORS |2 +-
 AUTHORS.src |1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2728f56: Use AX_PROG_CC_FOR_BUILD macro to identify compiler targeting the build host. (When cross-compiling, this is *not* the compiler used to build wireshark itself).

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2728f5673fd99f0c634ffe5e72a2eee02526bc00
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

2728f56 by Eric Anderson (ander...@cs.cmu.edu):

Use AX_PROG_CC_FOR_BUILD macro to identify compiler targeting the build 
host.
(When cross-compiling, this is *not* the compiler used to build wireshark 
itself).

Macro ax_prog_cc_for_build.m4 retrieved from 
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git

Change-Id: I035059d9315e0081dcf1ffbafd9ce6d7ad46700c
Reviewed-on: https://code.wireshark.org/review/4503
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Eric Anderson 
Reviewed-by: João Valverde 


Actions performed:

from  99db1c5   Remove superfluous pointer checks (CID-280599, 280600 and 
280601)
adds  2728f56   Use AX_PROG_CC_FOR_BUILD macro to identify compiler 
targeting the build host. (When cross-compiling, this is *not* the compiler 
used to build wireshark itself).


Summary of changes:
 Makefile.am  |1 +
 acinclude.m4 |4 +-
 aclocal-fallback/ax_prog_cc_for_build.m4 |  125 ++
 configure.ac |   15 ++--
 tools/lemon/Makefile.am  |   20 ++---
 5 files changed, 144 insertions(+), 21 deletions(-)
 create mode 100644 aclocal-fallback/ax_prog_cc_for_build.m4
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d12bd52: Added dissector for Metamako trailers.

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d12bd52a52788d2fd44cd43b95003906d2ae7b45
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d12bd52 by David Snowdon (da...@metamako.com):

Added dissector for Metamako trailers.

Change-Id: Ib9dc712f58b9e579ad8ef027864db0a1b31ebf52
Reviewed-on: https://code.wireshark.org/review/14282
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  6948e7c   generate_authors.pl: Use literal regex expression
adds  d12bd52   Added dissector for Metamako trailers.


Summary of changes:
 docbook/release-notes.asciidoc|1 +
 epan/dissectors/CMakeLists.txt|1 +
 epan/dissectors/Makefile.common   |1 +
 epan/dissectors/packet-metamako.c |  247 +
 4 files changed, 250 insertions(+)
 create mode 100644 epan/dissectors/packet-metamako.c
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 80dda81: AUTHORS: sort by name

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80dda81a61753ceff29820f29b755a61994c0bf5
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

80dda81 by Alexis La Goutte (alexis.lagou...@gmail.com):

AUTHORS: sort by name

Change-Id: I01980d1ab757decb7bb84649dbd41477978104c3
Reviewed-on: https://code.wireshark.org/review/14381
Reviewed-by: Alexis La Goutte 


Actions performed:

from  e82bdcb   AUTHORS: update .mailmap
adds  80dda81   AUTHORS: sort by name


Summary of changes:
 AUTHORS|  260 
 CMakeLists.txt |3 +-
 Makefile.am|2 +-
 3 files changed, 133 insertions(+), 132 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master-2.0 f862444: BGP: Fix detection of additional path

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8624442372471c68205e2af60ce1e513a2da123
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f862444 by Uli Heilmeier (u...@heilmeier.eu):

BGP: Fix detection of additional path

When additional path index are in use there must be more remaining data 
bytes.
Therefore we return only 1 when the len is greater 1.

Bug has been reported by Garri.

Bug: 12240
Change-Id: Ia24311dcedc450e4208df875bc254c9744dec5dd
Reviewed-on: https://code.wireshark.org/review/14396
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 48b807a364b3a6dfc6df6656dffbab1afc75617a)
Reviewed-on: https://code.wireshark.org/review/14397


Actions performed:

from  dd43f90   Fix indentation.
adds  f862444   BGP: Fix detection of additional path


Summary of changes:
 epan/dissectors/packet-bgp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 5f8003e: Add EditorConfig settings for most C files

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f8003e949d36f627dd7e46d98d32ef93cea333b
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

5f8003e by João Valverde (joao.valve...@tecnico.ulisboa.pt):

Add EditorConfig settings for most C files

Change-Id: I02e6d71290bbdf7504437b0d670955b3686b6b52
Reviewed-on: https://code.wireshark.org/review/14360
Reviewed-by: João Valverde 


Actions performed:

from  e22b400   Convert dissector modelines to EditorConfig file
adds  5f8003e   Add EditorConfig settings for most C files


Summary of changes:
 .editorconfig  |   47 +-
 Makefile.am|1 +
 caputils/.editorconfig |   21 +
 caputils/Makefile.am   |1 +
 epan/dfilter/.editorconfig |   57 
 epan/dfilter/Makefile.am   |1 +
 epan/ftypes/.editorconfig  |   41 
 epan/ftypes/Makefile.am|1 +
 epan/nghttp2/.editorconfig |8 ++
 epan/nghttp2/Makefile.am   |1 +
 epan/wslua/.editorconfig   |8 ++
 epan/wslua/Makefile.am |1 +
 ui/.editorconfig   |   29 ++
 ui/Makefile.am |1 +
 ui/cli/.editorconfig   |   87 +
 ui/cli/Makefile.am |1 +
 ui/gtk/.editorconfig   |  221 
 ui/gtk/Makefile.am |1 +
 ui/win32/.editorconfig |8 ++
 wiretap/.editorconfig  |  145 +
 wiretap/Makefile.am|1 +
 wsutil/.editorconfig   |  140 
 wsutil/Makefile.am |1 +
 23 files changed, 821 insertions(+), 2 deletions(-)
 create mode 100644 caputils/.editorconfig
 create mode 100644 epan/dfilter/.editorconfig
 create mode 100644 epan/ftypes/.editorconfig
 create mode 100644 epan/nghttp2/.editorconfig
 create mode 100644 epan/wslua/.editorconfig
 create mode 100644 ui/.editorconfig
 create mode 100644 ui/cli/.editorconfig
 create mode 100644 ui/gtk/.editorconfig
 create mode 100644 ui/win32/.editorconfig
 create mode 100644 wiretap/.editorconfig
 create mode 100644 wsutil/.editorconfig
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master bb8f3cd: AUTHORS: Update some e-mail address from AUTHORS.src for avoid duplicate entry

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb8f3cd6010c907e16c03f9554b85ea7328347b8
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

bb8f3cd by Alexis La Goutte (alexis.lagou...@gmail.com):

AUTHORS: Update some e-mail address from AUTHORS.src for avoid duplicate 
entry

Change-Id: I3ee91a0da1732f4a65c799a7b057272bf8b437f5
Reviewed-on: https://code.wireshark.org/review/14358
Reviewed-by: Alexis La Goutte 


Actions performed:

from  48b807a   BGP: Fix detection of additional path
adds  bb8f3cd   AUTHORS: Update some e-mail address from AUTHORS.src for 
avoid duplicate entry


Summary of changes:
 AUTHORS |   38 +-
 AUTHORS.src |   24 
 2 files changed, 25 insertions(+), 37 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 9486959: AUTHORS: Use LF line endings and remove BOM

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94869593e304b470914f86c07ad45ab4c7acb0d6
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

9486959 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

AUTHORS: Use LF line endings and remove BOM

Change-Id: I03c582baa03238ac82916d8bf865a3bf25f04cd5
Reviewed-on: https://code.wireshark.org/review/14384
Reviewed-by: Alexis La Goutte 


Actions performed:

from  28b9f05   AUTHORS: Add <...> to git log email addresses
adds  9486959   AUTHORS: Use LF line endings and remove BOM


Summary of changes:
 AUTHORS.src   |2 +-
 tools/generate_authors.pl |7 +--
 2 files changed, 2 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6948e7c: generate_authors.pl: Use literal regex expression

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6948e7ca195b8651718e297ba9da4cae2e8480e9
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

6948e7c by João Valverde (joao.valve...@tecnico.ulisboa.pt):

generate_authors.pl: Use literal regex expression

Change-Id: I6828dc5f71930ce4121ab7ad24db5b0428cea7f3
Reviewed-on: https://code.wireshark.org/review/14383
Reviewed-by: João Valverde 


Actions performed:

from  5f8003e   Add EditorConfig settings for most C files
adds  6948e7c   generate_authors.pl: Use literal regex expression


Summary of changes:
 tools/generate_authors.pl |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3d6f269: Bluetooth: GATT: Pass data to GATT dissectors

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d6f2693705b031ea04fbab9d8b5108e519dc029
Submitter: Michal Labedzki (michal.labed...@tieto.com)
Changed: branch: master
Repository: wireshark

Commits:

3d6f269 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: GATT: Pass data to GATT dissectors

Now GATT dissectors need to have opcode to properly dissect attribute
or return expert info if possible (wrong usage).

Change-Id: Ife79bbf0682967a8bef8efadd8b242aa147315a7
Reviewed-on: https://code.wireshark.org/review/14314
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 


Actions performed:

from  fcce1e4   Bluetooth: GATT: Add a lot of attributes usage expert infos
adds  3d6f269   Bluetooth: GATT: Pass data to GATT dissectors


Summary of changes:
 epan/dissectors/packet-btatt.c |   15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master e22b400: Convert dissector modelines to EditorConfig file

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e22b4008c660dde31e67b4017b69e882a75ca3ef
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

e22b400 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

Convert dissector modelines to EditorConfig file

Change-Id: I467b6ca940d2f89346fde46b7348b00eab40092e
Reviewed-on: https://code.wireshark.org/review/14353
Reviewed-by: João Valverde 


Actions performed:

from  b63a8bd   Start adding EditorConfig files.
adds  e22b400   Convert dissector modelines to EditorConfig file


Summary of changes:
 .editorconfig |6 +
 epan/dissectors/.editorconfig | 2285 +
 epan/dissectors/Makefile.am   |1 +
 3 files changed, 2292 insertions(+)
 create mode 100644 epan/dissectors/.editorconfig
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 28b9f05: AUTHORS: Add <...> to git log email addresses

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=28b9f05b0b8d16b719beeea42db8465417a6902a
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

28b9f05 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

AUTHORS: Add <...> to git log email addresses

Change-Id: I936e4a25833906cac75d4d5b7359b5629d14b33d
Reviewed-on: https://code.wireshark.org/review/14382
Reviewed-by: Alexis La Goutte 


Actions performed:

from  80dda81   AUTHORS: sort by name
adds  28b9f05   AUTHORS: Add <...> to git log email addresses


Summary of changes:
 AUTHORS   |  588 ++---
 tools/generate_authors.pl |2 +-
 2 files changed, 295 insertions(+), 295 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e82bdcb: AUTHORS: update .mailmap

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e82bdcb53abde199873be257c32e30b18f16d8aa
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e82bdcb by Alexis La Goutte (alexis.lagou...@gmail.com):

AUTHORS: update .mailmap

Change-Id: Ic67b404457435c3c9d1bc54ca0c7809e71917945
Reviewed-on: https://code.wireshark.org/review/14380
Reviewed-by: Alexis La Goutte 


Actions performed:

from  bb8f3cd   AUTHORS: Update some e-mail address from AUTHORS.src for 
avoid duplicate entry
adds  e82bdcb   AUTHORS: update .mailmap


Summary of changes:
 .mailmap |7 +++
 AUTHORS  |   16 ++--
 2 files changed, 13 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 31d3a1b: Initialize write function pointers when copying a new wtap block option.

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31d3a1b3d47c7efe0214b4f9114867e36f709c9a
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

31d3a1b by Michael Mann (mman...@netscape.net):

Initialize write function pointers when copying a new wtap block option.

Issue found by Clang (Assigned value is garbage or undefined).

Change-Id: I9a3ab41dd01becbd454af02f2567ea3a2beeba40
Reviewed-on: https://code.wireshark.org/review/14399
Reviewed-by: Alexis La Goutte 


Actions performed:

from  9486959   AUTHORS: Use LF line endings and remove BOM
adds  31d3a1b   Initialize write function pointers when copying a new wtap 
block option.


Summary of changes:
 wiretap/wtap_opttypes.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master b63a8bd: Start adding EditorConfig files.

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b63a8bdcb7c44b6d3bf00ecfce24830c1827721d
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

b63a8bd by Gerald Combs (ger...@wireshark.org):

Start adding EditorConfig files.

Add EditorConfig files where we currently have consistent indentation.
This might let us get rid of our editor modeline footers at some point.

Change-Id: I156f8d25cfa0050786eb2186c4b2e6d183c3a9ce
Reviewed-on: https://code.wireshark.org/review/12383
Reviewed-by: João Valverde 


Actions performed:

from  4dae247   Qt: Remove unused version.h header
adds  b63a8bd   Start adding EditorConfig files.


Summary of changes:
 .editorconfig   |   24 
 Makefile.am |1 +
 ui/qt/.editorconfig |9 +
 ui/qt/Makefile.am   |1 +
 4 files changed, 35 insertions(+)
 create mode 100644 .editorconfig
 create mode 100644 ui/qt/.editorconfig
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 301fa00: Use field info length instead of packet length for protocol hierarchy stats.

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=301fa0057e30ac0826b3b65588064d98c688cc10
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

301fa00 by Michael Mann (mman...@netscape.net):

Use field info length instead of packet length for protocol hierarchy stats.

Bug: 1885
Change-Id: If2b68365880f3508ed82947a0d18e6c28d6e4db8
Reviewed-on: https://code.wireshark.org/review/14392
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3d6f269   Bluetooth: GATT: Pass data to GATT dissectors
adds  301fa00   Use field info length instead of packet length for protocol 
hierarchy stats.


Summary of changes:
 ui/proto_hier_stats.c |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master 48b807a: BGP: Fix detection of additional path

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48b807a364b3a6dfc6df6656dffbab1afc75617a
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

48b807a by Uli Heilmeier (u...@heilmeier.eu):

BGP: Fix detection of additional path

When additional path index are in use there must be more remaining data 
bytes.
Therefore we return only 1 when the len is greater 1.

Bug has been reported by Garri.

Bug: 12240
Change-Id: Ia24311dcedc450e4208df875bc254c9744dec5dd
Reviewed-on: https://code.wireshark.org/review/14396
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  bc59efc   Add packet-metamako.c to EditorConfig file
adds  48b807a   BGP: Fix detection of additional path


Summary of changes:
 epan/dissectors/packet-bgp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master fcce1e4: Bluetooth: GATT: Add a lot of attributes usage expert infos

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcce1e4bca92feafcaf3b63fede261469ff97ee8
Submitter: Michal Labedzki (michal.labed...@tieto.com)
Changed: branch: master
Repository: wireshark

Commits:

fcce1e4 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: GATT: Add a lot of attributes usage expert infos

Bluetooth Specifications specify properties of every characteristics
(read, write, indicate, notify, write without response, signed write etc.)
Check it and add expert info about invalid usage if detected use of wrong
opcode with the characteristic.

Change-Id: I98ad8280b9ee65b4015a021e732ea748cc9e7a83
Reviewed-on: https://code.wireshark.org/review/14313
Reviewed-by: Michal Labedzki 


Actions performed:

from  31d3a1b   Initialize write function pointers when copying a new wtap 
block option.
adds  fcce1e4   Bluetooth: GATT: Add a lot of attributes usage expert infos


Summary of changes:
 debian/libwireshark0.symbols   |2 +
 epan/dissectors/packet-bluetooth.c |   12 +-
 epan/dissectors/packet-btatt.c | 2375 +++-
 epan/dissectors/packet-btatt.h |5 +
 4 files changed, 2347 insertions(+), 47 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] master bc59efc: Add packet-metamako.c to EditorConfig file

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc59efc4e36e31f6511849fcec498ca9be16b29f
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

bc59efc by Pascal Quantin (pascal.quan...@gmail.com):

Add packet-metamako.c to EditorConfig file

Change-Id: I4f1a03c348e4b3e29164d90c0c1e2035eed6f2a1
Reviewed-on: https://code.wireshark.org/review/14395
Reviewed-by: Pascal Quantin 


Actions performed:

from  d12bd52   Added dissector for Metamako trailers.
adds  bc59efc   Add packet-metamako.c to EditorConfig file


Summary of changes:
 epan/dissectors/.editorconfig |3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe


[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-03-09 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/5881

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 6948e7ca195b8651718e297ba9da4cae2e8480e9
Blamelist: João Valverde 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 99db1c5: Remove superfluous pointer checks (CID-280599, 280600 and 280601)

2016-03-09 Thread Wireshark code review
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99db1c5c982360c5f8307f41eccc6417f83e6a84
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

99db1c5 by Jaap Keuter (jaap.keu...@xs4all.nl):

Remove superfluous pointer checks (CID-280599, 280600 and 280601)

The preceding code takes every effort to make sure that the
frac and end pointers are relevant pointers. Don't go back and
check for NULL yet again.

Change-Id: If805aee5a77a8c23eac7b074bd11d3743c5e1a3b
Reviewed-on: https://code.wireshark.org/review/14398
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Michael Mann 


Actions performed:

from  301fa00   Use field info length instead of packet length for protocol 
hierarchy stats.
adds  99db1c5   Remove superfluous pointer checks (CID-280599, 280600 and 
280601)


Summary of changes:
 editcap.c |   33 +++--
 1 file changed, 15 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe