[Wireshark-commits] master-2.0 279845c: DNS: Fix handling of the server part of EDNS0 Cookie Option

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=279845cbf3612baa2a6bff6d3e339021cd6e035c
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

279845c by Remi Gacogne (remi.gaco...@powerdns.com):

DNS: Fix handling of the server part of EDNS0 Cookie Option

cur_offset was not incremented for the server part, causing a
"Malformed packet" message.

Change-Id: I21cb876e0d70b1de0cb2f76d37edec4c2ec7c788
Reviewed-on: https://code.wireshark.org/review/14402
Reviewed-by: Michael Mann 
(cherry picked from commit cc251536fbd195e0484356ff0e24ce5cae4c2806)
Reviewed-on: https://code.wireshark.org/review/14410


Actions performed:

from  5b9637a   3GPP NAS: fix dissection of GMM Identity Request, Response 
and Authentication and Ciphering Failure messages
adds  279845c   DNS: Fix handling of the server part of EDNS0 Cookie Option


Summary of changes:
 epan/dissectors/packet-dns.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1fad333: Fix NSIS installer

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1fad3334c6c57964c626a567ba55962be3e7a4d1
Submitter: Jo?o Valverde (j...@v6e.pt)
Changed: branch: master
Repository: wireshark

Commits:

1fad333 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

Fix NSIS installer

Broken by gb7f6cf9.

Change-Id: I21a91cf56c16b7ffdf72da7bf68a556feb6a6c17
Reviewed-on: https://code.wireshark.org/review/14408
Petri-Dish: João Valverde 
Tested-by: Petri Dish Buildbot 
Reviewed-by: João Valverde 


Actions performed:

from  7bd1158   Remove double check for null (CID 1158871)
adds  1fad333   Fix NSIS installer


Summary of changes:
 doc/CMakeLists.txt |5 +
 1 file changed, 5 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7bd1158: Remove double check for null (CID 1158871)

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7bd1158b95fa896f7bdb978dce21d4dabe173238
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

7bd1158 by Jaap Keuter (jaap.keu...@xs4all.nl):

Remove double check for null (CID 1158871)

Make full use of our proper implementation of this macro by
giving it the pointer as is.

Change-Id: I0bbe73d19cc3f578b94ea2d4d904d6fa87b20b48
Reviewed-on: https://code.wireshark.org/review/14391
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3eafa0b   CIP: Improve info column information
adds  7bd1158   Remove double check for null (CID 1158871)


Summary of changes:
 epan/proto.c |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3eafa0b: CIP: Improve info column information

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3eafa0b4a64689a0889f6edb3f7d8ef19750101b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

3eafa0b by D. Ulis (daul...@gmail.com):

CIP: Improve info column information

1. Remove "Object" from CIP class names. It was already removed from some 
of the objects, the string "Object" is implied for all objects, and it helps 
reduce wordiness in the Info column.
2. Don't display Class/Symbol name in the Info column when it's inside a 
MSP.
3. Enable enhanced Info column by default now that some of the additional 
wordiness was removed by the above points.
4. Put single quotes around the symbol name in the Info column. This makes 
it more obvious that something is a symbol instead of an actual class name from 
the spec, and would prevent ambiguity if the symbol name was something like 
"Identity".
5. Print the CIP service for both requests/responses in CIP Safety 
processing. This was already added to normal CIP.
6. Display Class/Symbol and service on the Service Packet in the MSP tree. 
This makes it easier to find without expanding every MSP item.

Change-Id: I7197dd4bf3dad6d7bdba247d3d7ab76cca52c785
Reviewed-on: https://code.wireshark.org/review/14325
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: D. Ulis 
Reviewed-by: Michael Mann 


Actions performed:

from  e0fe8c2   3GPP NAS: fix dissection of GMM Identity Request, Response 
and Authentication and Ciphering Failure messages
adds  3eafa0b   CIP: Improve info column information


Summary of changes:
 epan/dissectors/packet-cip.c   |  248 +++-
 epan/dissectors/packet-cip.h   |4 +-
 epan/dissectors/packet-cipsafety.c |   14 +-
 3 files changed, 141 insertions(+), 125 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64

2016-03-10 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.7%20x64/builds/689

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.0] 5b9637aff289afc9331971e5e8c513f88b2b26e1
Blamelist: Pascal Quantin 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 5b9637a: 3GPP NAS: fix dissection of GMM Identity Request, Response and Authentication and Ciphering Failure messages

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b9637aff289afc9331971e5e8c513f88b2b26e1
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5b9637a by Pascal Quantin (pascal.quan...@gmail.com):

3GPP NAS: fix dissection of GMM Identity Request, Response and 
Authentication and Ciphering Failure messages

Bug: 12246
Change-Id: I0cad1c951c4939bde41c281cfc0cf5b4a08ea2a3
Reviewed-on: https://code.wireshark.org/review/14406
Reviewed-by: Pascal Quantin 
(cherry picked from commit e0fe8c2543e1a2d15938531090dc60b4298ec3db)
Reviewed-on: https://code.wireshark.org/review/14407


Actions performed:

from  e9fe789   Qt: Check for selected interface in filterEdited()
adds  5b9637a   3GPP NAS: fix dissection of GMM Identity Request, Response 
and Authentication and Ciphering Failure messages


Summary of changes:
 epan/dissectors/packet-gsm_a_gm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e0fe8c2: 3GPP NAS: fix dissection of GMM Identity Request, Response and Authentication and Ciphering Failure messages

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0fe8c2543e1a2d15938531090dc60b4298ec3db
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e0fe8c2 by Pascal Quantin (pascal.quan...@gmail.com):

3GPP NAS: fix dissection of GMM Identity Request, Response and 
Authentication and Ciphering Failure messages

Bug: 12246
Change-Id: I0cad1c951c4939bde41c281cfc0cf5b4a08ea2a3
Reviewed-on: https://code.wireshark.org/review/14406
Reviewed-by: Pascal Quantin 


Actions performed:

from  283d2c8   GTPv2 conversation time response
adds  e0fe8c2   3GPP NAS: fix dissection of GMM Identity Request, Response 
and Authentication and Ciphering Failure messages


Summary of changes:
 epan/dissectors/packet-gsm_a_gm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 283d2c8: GTPv2 conversation time response

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=283d2c8c2dff6543a401abce3c54686cf1c6e9ad
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

283d2c8 by glores (gloria.pozu...@bics.com):

GTPv2 conversation time response

Change-Id: Ice7a08a47b091e4e47cd13b04b7dd7ed74a0f950
Reviewed-on: https://code.wireshark.org/review/14328
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  e139763   Qt: Check for selected interface in filterEdited()
adds  283d2c8   GTPv2 conversation time response


Summary of changes:
 epan/dissectors/packet-gtpv2.c |   11 +++
 1 file changed, 11 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-03-10 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/5894

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] b7f6cf979c0ae5ad806d4d808b5291c6906ce866
Blamelist: Balint Reczey 

BUILD FAILED: failed compile_5

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 e9fe789: Qt: Check for selected interface in filterEdited()

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e9fe789e0b647b84723c89e333470b2731ff6693
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

e9fe789 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Check for selected interface in filterEdited()

Add a check for selected filters in filterEdited() to avoid a
out-of-bounds index into ui->interfaceTree->selectedItems().

Bug: 12241
Bug: 12245
Change-Id: Ie18fc34a17427dd5330a5a617051cbc061555e0c
Reviewed-on: https://code.wireshark.org/review/14404
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit e13976339be6fa8ee06177b85268d29c81dc7995)
Reviewed-on: https://code.wireshark.org/review/14405


Actions performed:

from  f862444   BGP: Fix detection of additional path
adds  e9fe789   Qt: Check for selected interface in filterEdited()


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e139763: Qt: Check for selected interface in filterEdited()

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e13976339be6fa8ee06177b85268d29c81dc7995
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

e139763 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Check for selected interface in filterEdited()

Add a check for selected filters in filterEdited() to avoid a
out-of-bounds index into ui->interfaceTree->selectedItems().

Bug: 12241
Bug: 12245
Change-Id: Ie18fc34a17427dd5330a5a617051cbc061555e0c
Reviewed-on: https://code.wireshark.org/review/14404
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  b7f6cf9   Add doc/CMakeLists.txt
adds  e139763   Qt: Check for selected interface in filterEdited()


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-03-10 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/70

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] b7f6cf979c0ae5ad806d4d808b5291c6906ce866
Blamelist: Balint Reczey 

BUILD FAILED: failed compile_5

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master b7f6cf9: Add doc/CMakeLists.txt

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7f6cf979c0ae5ad806d4d808b5291c6906ce866
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: master
Repository: wireshark

Commits:

b7f6cf9 by João Valverde (joao.valve...@tecnico.ulisboa.pt):

Add doc/CMakeLists.txt

Change-Id: I387e893dc5b8b38569f7189d078fdc1853ba012f
Reviewed-on: https://code.wireshark.org/review/14269
Reviewed-by: Balint Reczey 


Actions performed:

from  57f494c   autotools: Don't use AM_PROG_CC_C_O
adds  b7f6cf9   Add doc/CMakeLists.txt


Summary of changes:
 CMakeLists.txt   |  159 +---
 debian/tshark.manpages   |2 +-
 debian/wireshark-common.manpages |   24 ++---
 debian/wireshark-dev.manpages|6 +-
 debian/wireshark-qt.manpages |2 +-
 doc/CMakeLists.txt   |  185 ++
 doc/Makefile.am  |3 +-
 7 files changed, 205 insertions(+), 176 deletions(-)
 create mode 100644 doc/CMakeLists.txt
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] lts-1.8.2 bf92b0e: Limit my_dgt_tbcd_unpack() in writing to global buffer

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf92b0ea7e8257c963a426012412b87ba5e23702
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

bf92b0e by Balint Reczey (bal...@balintreczey.hu):

Limit my_dgt_tbcd_unpack() in writing to global buffer

Ping-Bug: 11797
Change-Id: I3b0843f05dc15de8db34a40290afcd8370f84b3d
Reviewed-on: https://code.wireshark.org/review/14378
Reviewed-by: Balint Reczey 


Actions performed:

from  39509e4   Diameter: check IPv6 prefix length before copying it in 
e_in6_addr structure
adds  bf92b0e   Limit my_dgt_tbcd_unpack() in writing to global buffer


Summary of changes:
 epan/dissectors/packet-ansi_a.c   |   10 --
 epan/dissectors/packet-gsm_a_common.c |8 +++-
 2 files changed, 15 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] lts-1.8.2 39509e4: Diameter: check IPv6 prefix length before copying it in e_in6_addr structure

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39509e4568e93ec54670860635a97203cb7f30ab
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

39509e4 by Pascal Quantin (pascal.quan...@gmail.com):

Diameter: check IPv6 prefix length before copying it in e_in6_addr structure

Conflicts:
epan/dissectors/packet-diameter.c

Bug: 11792
Change-Id: I37a07044d40f10e9a1a90025d90753fdb3db2278
Reviewed-on: https://code.wireshark.org/review/12248
Petri-Dish: Pascal Quantin 
Reviewed-by: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 
(cherry picked from commit aaa28a9d39158ca1033bbd3372cf423abbf4f202)
Reviewed-on: https://code.wireshark.org/review/12252
(cherry picked from commit 644bc7868dda0717f7e49ec01e07e0043f7385fb)
Reviewed-on: https://code.wireshark.org/review/13763
Reviewed-by: Balint Reczey 
Reviewed-on: https://code.wireshark.org/review/14377


Actions performed:

from  e86b1e9   ber: avoid deep recursion for constructed strings
adds  39509e4   Diameter: check IPv6 prefix length before copying it in 
e_in6_addr structure


Summary of changes:
 epan/dissectors/packet-diameter.c |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] lts-1.8.2 e86b1e9: ber: avoid deep recursion for constructed strings

2016-03-10 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e86b1e9f557e2cd1ae365dd96623226cff974795
Submitter: Balint Reczey (bal...@balintreczey.hu)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

e86b1e9 by Peter Wu (pe...@lekensteyn.nl):

ber: avoid deep recursion for constructed strings

Bound the recursion depth to avoid a stack overflow while parsing a
deeply nested constructed string.

Call chain before this patch:

 - dissect_ber_octet_string
   - dissect_ber_constrained_octet_string
 - reassemble_octet_string (called for constructed types)
   - dissect_ber_octet_string *recursion*

After this patch, the reassemble_octet_string will throw if the maximum
recursion depth is reached.

Conflicts:
epan/dissectors/packet-ber.c

Bug: 11822
Change-Id: I6753e3c9f5dcbfab0e4c174418b2c7eb784d64d2
Reviewed-on: https://code.wireshark.org/review/14108
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 9ff932bf5ea554f9e94ee1364284aff9eb3fd619)
Reviewed-on: https://code.wireshark.org/review/14110
(cherry picked from commit 307bbd253fc61657935eca992ec9325dbfff3274)
Reviewed-on: https://code.wireshark.org/review/14111
(cherry picked from commit 8f7a26e8fcf878bb55601edae5032caf71c2e587)
Reviewed-on: https://code.wireshark.org/review/14348
Reviewed-by: Balint Reczey 
Reviewed-on: https://code.wireshark.org/review/14376


Actions performed:

from  512f778   Add boundary check for 802.11 decryption
adds  e86b1e9   ber: avoid deep recursion for constructed strings


Summary of changes:
 epan/dissectors/packet-ber.c |   20 +---
 1 file changed, 17 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe